How was code reviewed before employing GitHub PR?

[shin...@gmail.com]

Hello,

I'm interested in understanding the code review process of Rails.

I find that GitHub PR was used by Rails since the end of 2009,

and I want to know, before that, how code review was conducted.

Through a code review mailing list? or any other code review systems?

Are there archives of those reviews?

Anyone knows? Thank you!

Shin

[Frederick Cheung]

You used to post your patches on the rails trac instance, and later the lighthouse tracker. Looks like the trac instance no longer exists, but the lighthouse data is still at https://rails.lighthouseapp.com. Discussion took place there & on the rails-core mailing list and the rails-contrib IRC channel.

Fred

[xx x]

I see.

Thank you very much! Fred.

Shin

--
You received this message because you are subscribed to a topic in the Google Groups "Ruby on Rails: Talk" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/rubyonrails-talk/nhcS6DVK3l4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to rubyonrails-ta...@googlegroups.com.
To post to this group, send email to rubyonra...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rubyonrails-talk/c43689da-127e-4075-ae87-41819a932f98%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.