Add origin as part of `redirect_to.action_controller` Instrumentation

24 views
Skip to first unread message

Austin Story

unread,
Nov 22, 2019, 3:09:38 PM11/22/19
to Ruby on Rails: Core
Requesting to extend an existing feature


I would like to add 'origin' to the 'redirect_to.action_controller' instrumentation.  This change will allow subscribers to the notification to report on both where we are going and where we are coming from


A real world use case for this, we have a lot of developers in our code base and would like to know when someone is using redirect_to and dropping `utm_campaign` query params in the process.



Rafael Mendonça França

unread,
Nov 22, 2019, 3:33:55 PM11/22/19
to rubyonra...@googlegroups.com
Please open the PR.
--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-co...@googlegroups.com.

Austin Story

unread,
Nov 26, 2019, 7:26:38 AM11/26/19
to Ruby on Rails: Core
Done, https://github.com/rails/rails/pull/37801

Thanks for all you do for rails Rafael


On Friday, November 22, 2019 at 2:33:55 PM UTC-6, Rafael Mendonça França wrote:
Please open the PR.

On Fri, Nov 22, 2019, at 3:09 PM, Austin Story wrote:
Requesting to extend an existing feature


I would like to add 'origin' to the 'redirect_to.action_controller' instrumentation.  This change will allow subscribers to the notification to report on both where we are going and where we are coming from


A real world use case for this, we have a lot of developers in our code base and would like to know when someone is using redirect_to and dropping `utm_campaign` query params in the process.




--
You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rubyonra...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages