Get list of users who approved the review-request

9 views
Skip to first unread message

ketan khandagale

unread,
Sep 23, 2021, 10:50:16 AM9/23/21
to Review Board Community
Im trying to build a check before submitting the change, that if the reivew is approved my specific users or not. for doing this validation i need to get list of users who gave ship it.
but the api which rb provides just returns the ship-it count.

Do you have any idea how to do this ? or is there any workaround ?

im using 3.0 version.

Christian Hammond

unread,
Oct 5, 2021, 5:36:49 PM10/5/21
to revie...@googlegroups.com
Hi Ketan,

I'm sorry for the late reply.

The best approach is to do this via an extension, making use of ReviewRequestApprovalHook.

This is used to define custom logic on what constitutes an approved review request. Then, client-side, APIs can check the "approved" flag on a review request's payload, which will reflect the result of that calculation. This is the recommended approach at this time, as it's faster, future-proof (working with things like repository pre-commit hooks that check for this state), and can do things like directly query the database or a central configuration for the information you need.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/f0e43247-42d1-470f-b76b-66ad81afff25n%40googlegroups.com.


--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board
Reply all
Reply to author
Forward
0 new messages