'rbt post' command for updating review request with new commit

[Goran Žauhar]

Hi all,

I have a question about updating review request with new commit.

In blog post - https://blog.beanbaginc.com/2015/01/26/an-effective-rbtools-workflow-for-git/ in section "Need to make some changes?" it has been mentioned it is users choice to amend existing commit or create new one with fixes. Updating review request with amended commit works without issues. But I am having troubles with updating review request with new commit with fixes. In your example what would 'rbt post' command look like if we chose to create new commit with fixes instead of amending existing one?

Thank you,

Goran

[David Trowbridge]

If you're adding fix-up commits rather than amending, you'd want to post the range of commits for the whole branch corresponding to the change. This can use git's revision syntax, for example, if you branched off master:

rbt post -r XX master..HEAD

By default, rbt post will post all changes between the configured TRACKING_BRANCH and your current HEAD, so if that's set correctly for your current branch (either in .reviewboardrc or the default of "origin/master"), "rbt post -u" should still do the right thing.

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/48c3c5cc-e0f9-442c-a8b2-08df75b9e6da%40googlegroups.com.

[Goran Žauhar]

I thought I had tried this obvious and easy solution. I guess I didn't.

Nevertheless thank you David for the answer. Everything works now!

Goran

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.