Does reviewboard 2.5.4 support binary file?

[Rick Liu]

Environment:
OS: Ubuntu 14.04 x64
Reviewboard: 2.5.4
Python 2.7.6
RBTools 0.7.5


We use "rbt post" to post a review contains binary file.
The web front-end correctly identified the file as binary file in diff view.
But:
1.
I can't find any link to download the new binary file to be submitted.
2.
When I "ship-it" to submit the review,
it failed to be merged into SVN.

I googled the binary support for reviewboard.
Some said yes and some said no,
so I'm confused here.

Thanks,

Rick

[Christian Hammond]

Hi Rick,

There isn't currently a standard for binary files in diffs, and Subversion has no support whatsoever. You can attach binary files to review requests as file attachments.

Marking Ship It doesn't merge changes, so that still has to be done locally. Presumably, you have those binary files in your working directory, and can commit them along with the code changes.

We have plans for more intelligently handling binary files, and are aiming to provide that as part of Review Board 3.5 (3.0 is in development right now).

Christian

-- 
Christian Hammond

President/CEO of Beanbag

Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Rick Liu]

Hi Christian,

Than you for the information,
and that's the plan I'm doing right now.

I created a BASH script wrapper on top of rbt command line tool
to handle "rbt post" that contains binary changes,
and tar all the changed binaries into a single tarball to attach to a review.

Some side-notes:
While developing the wrapper script,
I found out there's no "rbt attach" update commands to update specific attachment.
I see "Update" feature is available on Web UI.

Another thing is SVN property changes handling (svn propset, proplist).
"rbt diff / rbt patch" is able to correctly handling the changes in "SVN property".

eg. (rbt diff)
Index: x86_64/dd
===================================================================
--- x86_64/dd    (revision 7144)
+++ x86_64/dd    (working copy)

Property changes on: x86_64/dd
___________________________________________________________________
Added: opensource
## -0,0 +1 ##
+ON
\ No newline at end of property

And when I do "rbt patch",
the corresponding SVN property changes applied correctly.

But from the WebUI,
I can't find any trace to the changed file "dd".
Unlike binary file change,
the webUI diff would still show:
This is a binary file. The content cannot be displayed.

I'd suggest it should display the same as "rbt diff".






Rick

[Rajan M]

Hi,

In my review, I have binary files and non-binary files in the Changeset. 

Basically, I don't see the binary files in my diffs. How to make the binary file should go(check-in) and available in PerForce with Jenkins build? (please note not the real SUBMIT).

Highly appreciate your help here. 

I use RB Tools version 0.7.5 

[Christian Hammond]

Diffs don't contain contents for binary files, so most tooling is unable to do anything with them other than state that a file is binary.

We're evaluating ways to go provide more information, including contents, of binary files in diffs for display, but given the lack of binary support in diffs, we have to come up with our own solution to this.

If you're not even seeing an entry for binary files, then something is likely excluding them from the diff building. I'd need to know what type of repository you're working with. For most, we call out to the repository command line tool's diff builder to generate these.

Also worth mentioning, RBTools 0.7.5 is 7 years old, and much has changed since then. If in doubt, try upgrading that.

Christian

You received this message because you are subscribed to the Google Groups "Review Board Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/1741ac4b-4fdd-4b54-a787-b0f62ee1984fn%40googlegroups.com.