Upgrade issues upgrading from 3.0.20 to 3.0.22

43 views
Skip to first unread message

tw bert

unread,
May 5, 2021, 11:42:30 AM5/5/21
to Review Board Community
RB breaks when upgrading, we reverted to backup.

Any clue? Previous upgrades always went fine.

pip install -U ReviewBoard==3.0.22

(ok)

root@srv-flux-dev-01:/# rb-site upgrade /var/www/reviews.XXX.XXX.com
WARNING:py.warnings:/usr/local/lib/python2.7/dist-packages/paramiko/transport.py:33: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in the next release.
  from cryptography.hazmat.backends import default_backend

Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

------------------ <begin log output> ------------------

[!] Unable to execute the manager command syncdb: cannot import name
    signals

[!] Unable to execute the manager command registerscmtools: cannot
    import name signals

[!] Unable to execute the manager command evolve: cannot import name
    signals
------------------- <end log output> -------------------

Resetting in-database caches.

[!] Unable to execute the manager command fixreviewcounts: No module
    named bleach_allowlist

Upgrade complete!

There are duplicate copies of diffs in your database that can be condensed.
These are the result of posting several iterations of a change for review on
older versions of Review Board.

Removing duplicate diff data will save space in your database and speed up
future upgrades.

To condense duplicate diffs, type the following:

    $ rb-site manage /var/www/reviews.XXX.XXX.com condensediffs


root@srv-flux-dev-01:/# tail -n30 /var/log/apache2/error.log
[Wed May 05 08:20:37.853326 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     self.load_middleware(), referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853350 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 45, in load_middleware, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853385 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     mw_class = import_by_path(middleware_path), referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853406 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py", line 26, in import_by_path, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853438 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     sys.exc_info()[2]), referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853458 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/django/utils/module_loading.py", line 21, in import_by_path, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853504 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     module = import_module(module_path), referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853525 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/django/utils/importlib.py", line 40, in import_module, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853556 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     __import__(name), referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853575 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/admin/middleware.py", line 9, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853621 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.accounts.backends.registry import get_enabled_auth_backends, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853653 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/accounts/backends/__init__.py", line 34, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853686 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.accounts.backends.registry import (AuthBackendRegistry,, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853705 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/accounts/backends/registry.py", line 15, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853736 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.accounts.backends.standard import StandardAuthBackend, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853756 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/accounts/backends/standard.py", line 17, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853787 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.accounts.models import LocalSiteProfile, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853806 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/accounts/models.py", line 23, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853838 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.reviews.models import Group, ReviewRequest, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853882 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/reviews/models/__init__.py", line 6, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853941 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.reviews.models.file_attachment_comment import \\, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.853964 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/reviews/models/file_attachment_comment.py", line 9, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854016 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.attachments.models import FileAttachment, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854037 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/attachments/models.py", line 16, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854078 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.attachments.mimetypes import MimetypeHandler, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854099 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/attachments/mimetypes.py", line 23, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854131 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from reviewboard.reviews.markdown_utils import render_markdown, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854150 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]   File "/usr/local/lib/python2.7/dist-packages/reviewboard/reviews/markdown_utils.py", line 7, in <module>, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854181 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160]     from bleach_allowlist import markdown_attrs, markdown_tags, referer: http://srv-reviewboard:8089/dashboard/
[Wed May 05 08:20:37.854214 2021] [wsgi:error] [pid 5063:tid 139949663827712] [client 192.168.4.87:53160] ImproperlyConfigured: Error importing module reviewboard.admin.middleware: "No module named bleach_allowlist", referer: http://srv-reviewboard:8089/dashboard/

Christian Hammond

unread,
May 5, 2021, 8:59:20 PM5/5/21
to revie...@googlegroups.com
Hi,

Looks like something went wrong with the release. You can get around this temporarily by doing:

    pip install bleach_allowlist

We'll put out a fixed build tonight.

Christian


--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/d47d52cf-ead9-4ea3-aad5-afeccb221a46n%40googlegroups.com.


--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

Christian Hammond

unread,
May 5, 2021, 9:16:10 PM5/5/21
to revie...@googlegroups.com
Just put out the 3.0.23 release, so you should be able to upgrade and be good. Sorry about that. There was a lingering but unnecessary usage of a dependency that we had removed in 3.0.22.

Christian

tw bert

unread,
May 6, 2021, 1:42:10 PM5/6/21
to Review Board Community
Hi Christian, thank you, that worked flawlessly.
We considered pip installing bleach, but like to keep stuff vanilla where possible.
Fixed.
For completeness, I've attached the output logs of pip install -U ReviewBoard==3.0.23 and the rb-site upgrade.
rbupgrade.log
rbupgrade2.log

Christian Hammond

unread,
May 6, 2021, 8:13:02 PM5/6/21
to revie...@googlegroups.com
I'm glad to hear it! Thanks for letting me know :) Sorry for the trouble before.

Christian

Reply all
Reply to author
Forward
0 new messages