Restrict Submitter

[santhosh K]

Hi 

Where do we have to change for not allowing submitter to be reviewer?

[David Trowbridge]

Hi,

This is not something that is currently possible, for several reasons.

We allow people to assign to themselves because in our experience, people often like to create and iterate on drafts privately before publishing to their peers. If they create it and assign it to themselves, they can do that, and then change the reviewers once they're ready for feedback.

We allow people to leave reviews on their own changes because we've seen often that it's useful for explanations. One thing I'll often do is publish and then find that there's some issue, and I'll leave a review on my own change telling people to hold off until I can update it.

David

On Tue, Dec 24, 2019 at 12:08 PM santhosh K <keshw...@gmail.com> wrote:

Hi 

Where do we have to change for not allowing submitter to be reviewer?

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/503472cc-4bfb-49c3-9c8c-3d319b9847a3%40googlegroups.com.

[santhosh K]

Hi

Thanks for response, can I edit search.py to only get people except submitter? Will this have impact else where?

[David Trowbridge]

That's a generic API endpoint which is also used for the quick search in the search box at the top. Beyond that it's possible it's used elsewhere, but I don't know off the top of my head.

What exactly is the problem you're trying to solve? This sounds more like a culture and process issue than a technical one.

David

On Wed, Dec 25, 2019 at 2:19 AM santhosh K <keshw...@gmail.com> wrote:

Hi

Thanks for response, can I edit search.py to only get people except submitter? Will this have impact else where?

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/b02cfe13-1bb0-4cfb-a85a-69145d6ece3a%40googlegroups.com.

[santhosh K]

Wanted to avoid submitter as reviewer so that commit to svn doesn’t happen without proper reviewer input. 

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAFS3VNWw1Voo0mvoiJhG-z5mLZ_m%3DYDYGg-rmY1DFRQhTgyF7w%40mail.gmail.com.

[z1p]

Hi Santosh,
I believe my first reaction to your question was inline with David`s last question. Which is why you feel you need thill enforces this restriction? I've been doing this work for many years and have found that in general engineers want to do the 'right' thing.

If you've found you have an engineer or two taking short cuts, then deal with them directly, don't take it out on your whole organization. If you aren't having issues and just want to put safeguards in place, don't! Engineers, like all employees, respond positively to trust, and negatively to distrust.

[Paul Mansfield]

as a thought. is it possible with RB to disallow the person submitting the review from being able to Ship-It?

also, is it possible to make RB block the landing a review without two ship-it's from two different people?

this would help enforce good practises, many orgs including ours require two ship-its for merging to master.

[Christian Hammond]

Hi Paul,

The former is certainly worth considering (though when people are testing/evaluating, it's not uncommon for someone to review and Ship It their own changes).

The latter can be done by overriding approval logic using ReviewRequestApprovalHook in an extension, and by using `rbt land` (which provides some enforcement, but weaker as it's client-side) and/or a repository-side pre-commit hook that checks the approved flag for the review request referenced in commit messages (stronger enforcement).

https://www.reviewboard.org/docs/manual/3.0/extending/extensions/hooks/review-request-approval-hook/

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/33cfd45e-93a0-4d35-b478-79eda0ceeb83%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board