reviewers idea

[Paul Mansfield]

As previously discusses some teams have a requirement that you get two ship-its before landing, it would nice if this could be a setting in RB.

It would also be nice if you have a "required reviewers" list so that something can't be landed without their say-so.

The other reviewers list could then be optional reviewers, or even "FYI".

Would it be possible to allow an admin to change the owner/author of a review?

thanks

[Christian Hammond]

Hey Paul,

This is all doable via a custom extension making use of ReviewRequestApprovalHook. This can define the logic by which a review request is marked as "approved," which `rbt land` respects, and any custom hooks on a repository can also look for (there's a flag returned by the API for review requests that says whether it's approved and, if not, the reason why).

This can be used to require two ship-its, or have a required reviewers list, or to draw a random number or determine if it's Happy Hour. Anything you might need (though, if you have to perform any "expensive" operations, like calling out to another server, it's best to limit this and cache the results).

We have longer-term plans to introduce a concept of User Roles in the product, which could be used alongside this to better track who should be required to give approval (and we might have some degree of built-in customization around that at that point).

As for changing the owners, any admin should be able to reassign a review request by just changing the Owner field on the review request to another user. This does require Review Board 3.0.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/CAMukpcAfu7xU4c9rFU_jDFd%2B9yrJDxq2PUTF99zMzawFN4PC7A%40mail.gmail.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board