Issue with resolve-check after upgrading to 4.0 beta1

34 views
Skip to first unread message

Charles Pigott

unread,
Jan 12, 2021, 2:12:18 PM1/12/21
to Review Board Community

I've been trying out 4.0 beta1 (mostly due to 20.04 largely dropping python2 support)

I had some issues with the upgrade process, specifically after altering the /static webserver config and running the instruction to update the config to say that this server update has been done:

rb-site manage <site> resolve-check static-media
You must specify a check to resolve

Not a particularly helpful error message. I tried a few things at this point - rb-site upgrade even segfaulted! (Though that may have been some confusion about py2/py3)

Eventually I dug through the code and found that the handle function in admin/management/commands/resolve-check.py wasn't actually getting any arguments passed to it. No idea why - the class structure disappears into djblets and I can't find where that function is getting called from.

Failing to come up with any other solution, I just hacked the code to set the correct argument ("static-media") there instead of erroring. After that, everything else worked fine, and initial inspections of 4.0-beta1 looks good.

Has anyone else seen this before? Is it a bug? Is there a workaround other than hacking the code to add the arguments manually?



Thanks

Christian Hammond

unread,
Jan 12, 2021, 4:44:29 PM1/12/21
to revie...@googlegroups.com
It’s a bug in beta 1. We’re releasing beta 2 in a few days to resolve this and other issues.

This happened with an upgrade with a pre-4.0 database, not a new install?

Christian


--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/72f044eb-4556-4125-a017-abda35548961n%40googlegroups.com.
--
--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

Tab10id

unread,
Jan 13, 2021, 12:06:49 AM1/13/21
to revie...@googlegroups.com
Yes. I fixed it in a same way.

вт, 12 янв. 2021 г., 22:12 'Charles Pigott' via Review Board Community <revie...@googlegroups.com>:

Charles Pigott

unread,
Jan 13, 2021, 4:46:19 AM1/13/21
to Review Board Community
Ah, excellent, thanks very much. Indeed - upgrade from 3.0 to 4.0

Charles

Christian Hammond

unread,
Jan 20, 2021, 4:08:04 PM1/20/21
to revie...@googlegroups.com
This is now fixed in beta 2. Thanks for the feedback!

Christian

Reply all
Reply to author
Forward
0 new messages