Posting and updating review request through REST API

[Aurustius]

Hi,

Currently I'm using Review Board 3 and RBTools in order to post/update a review request. The thing is - RBTools - while useful - gives me a lot of headache on deployment side. In order to make it work I had to modify its code before installation due to several issues, including proxy. I managed to get it to work, but I'm slightly dissatisfied with the fact that updating it in the future might be more troublesome than it should be due to modified codebase. As I have no need for any other functionality of it, I tried to do it myself using just REST API. The thing is - while I managed to make some rough, incomplete POST request to create a new review request, I am still missing diffs and some fields - like branch, for example. 

Could you please provide me logic flow behind rbt post command and/or fields that I need to provide for REST API requests in order to create/update review request? Complete POST request example would be enough for me to figure out what I need to do, too.

Thanks!

[David Trowbridge]

Hi,

It's not too hard to create a review request and then add a diff (POST to the review-requests resource, then POST to the linked diffs resource), but other than the RBTools code we don't have any examples. Filling the branch field is just a question of supplying that field in your POST/PUT request.

The major roadblock may be diff compatibility. Depending on what version control system you're using, the built-in VCS may produce diff files that are broken in various ways which the `patch` command can usually ignore but which Review Board depends on. For example, SVN has changed the format of their diff files at least 5 times in the last few years. RBTools has a lot of logic to fix up broken and inconsistent diffs before it uploads them to Review Board. If you're using an affected VCS, that's logic that you'd need to replicate.

Ideally, we recommend RBTools, due to the abovementioned issues and the general complexity of what has to be done to create review requests. I'm confused about what modifications you needed to make to get things working. The only thing you actually mention is a proxy, but RBTools has long supported the standard http_proxy/https_proxy environment variables and I'd wager that more than half of people using it have an HTTP proxy in place. If you can be more specific and maybe share what changes you had to make, we can figure out if you ran into actual bugs or just have something set up incorrectly.

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/72261be1-0b90-4981-8402-40558dc289b2%40googlegroups.com.