Select range of SVN commits?

[B T]

Is there a way to support the following workflow?

• A developer is working on a feature-specific SVN branch.  S/he makes a commit, and an automated process notices the commit and attempts to build the project.
• The build fails due to a syntax error; some extra text had been pasted in at the end and was not commented.
  
• The developer fixed the error by removing that text and commits the fix.
• The build succeeds, but as the developer tests functionality, notices something needs fixing.
• One or more additional commits provide the fixes.

The developer and reviewer both want the review to be the current/latest/complete version of the patch compared with the version prior to starting work on the patch.  Nobody wants the review to be a tortuous series of individual steps in how the code got to that state, identifying issues at each step that are fixed in the next.

However, the Review Board interface seems to make it so the only reviewable unit is one specific SVN commit compared with the immediate previous revision.

Is there a way to select a range of revisions to be lumped together for a review?

One workaround you might consider is to just not commit anything until the code is in its final reviewable state.  However, we want to encourage developers to commit early and often, for a host of other reasons.  The review unit should be able to be more complete and comprehensive than the commit unit.

As another example of a use case, a junior developer might first get a peer review, then make commits fixing things, and then wish to send a new clean review request to a senior developer for review, showing the version that's already cleaned up (i.e. as amended by later commits which fix issues in the earlier ones); the senior developer would also like to focus on the diff proposed to go into the code base rather than the steps toward getting there.

Is ReviewBoard able to support that?

[David Trowbridge]

Hi,

Review Board does support posting ranges of commits (including updating an existing review request with a new "diff revision" consisting of a new, broader range), but it requires using the RBTools command-line tools. See https://www.reviewboard.org/docs/rbtools/1.0/rbt/commands/post/#posting-committed-code

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/591c6c20-6778-4cc1-bf85-ebc2e8c78f0d%40googlegroups.com.

[B T]

Thanks for your reply.  It is nice to hear this is possible.

Does anybody know if this is something that could reasonably be added in the UI?

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.