Different output from rbt diff and rbt post

[Varunjay Varma]

Hi guys,

I added EXCLUDE_PATTERNS = ['regex1', 'regex2'] to my .reviewboardrc file. rbt diff is correctly excluding the files from its output. However, when I run rbt post, the excluded files are included in the diff. What is the correct way to exclude the files from rbt post as well?

[Christian Hammond]

Hi,

Both should respect that option. Diff generation is centralized.

Can you supply a debug log (-d as the first argument) for both commands?

Christian

On Tue, Aug 10, 2021 at 08:07 Varunjay Varma <varunja...@gmail.com> wrote:

Hi guys,

I added EXCLUDE_PATTERNS = ['regex1', 'regex2'] to my .reviewboardrc file. rbt diff is correctly excluding the files from its output. However, when I run rbt post, the excluded files are included in the diff. What is the correct way to exclude the files from rbt post as well?

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/2ffb67cf-fd92-4c49-a366-1f2a40bdd644n%40googlegroups.com.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

[Varunjay Varma]

Hi Christian,

I have attached the -d output for both commands. The diff command output includes the diff for repository. I have added the screenshot to display the post diff.

Regards,

Varunjay

[Varunjay Varma]

Hi Christian,

Do you have any updates regarding this issue?

Regards,

Varunjay

[Christian Hammond]

Hi Varunjay,

I'm sorry, I've been completely swamped with some work for customers with support contracts, and we have to give those requests priority.

What's the exact contents of the EXCLUDE_PATTERNS you're using? I had just realized you mentioned a regex, but this doesn't support regexes. You can use standard shell glob patterns, though (*.ext, */*.txt, etc.). I want to make sure those are going to be in the right format, and I'd like to set up a matching configuration for testing.

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/58587511-0728-466b-8e3e-5aaf5d3a7b82n%40googlegroups.com.

[Varunjay Varma]

Hey Christian,

I understand. The following is the EXCLUDE_PATTERNS for me:

EXCLUDE_PATTERNS = ['yarn.lock', 'package-lock.json']

Let me know if you need any more information from my side.

Regards,

Varunjay

[Christian Hammond]

Thanks, Varunjay.

I think we found the problem, and we're going to schedule a release. I don't have an ETA right now, but we'll try to get it soon.

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/4bb2f62a-b0cf-46e1-ac9f-e458ddf2cd0dn%40googlegroups.com.