"Change" field on non-committed reviews

[Danny Roux]

Hi,

When doing a review of committed code, the "change" field appears, showing the revision number (We're using subversion). I was wondering if there was a way to make this field appear on non-committed reviews, so that the person that post the review can enter a commit # after he committed it. It would be nice because it would allow us to search the reviews by commit #, which is more precise then searching with the JIRA, or other fields.

Thanks 

[Danny Roux]

We're using Reviewboard 3.0.15

[Christian Hammond]

Hi Danny,

This is a non-editable field, and that's pretty important as the value is unique across review requests for a repository. If we allowed editing of the field, and someone put in an ID that was incorrect, it could conflict with a real-world ID now or even years in the future, causing a failure to post the review request.

To ensure the value is correct, the field should only be set if it's actually coming from a commit, in which case it should be set at upload time (via RBTools or a custom script/integration if you're using one). It can also be set through the API, so if you really want to make this editable, you could have a script that simplifies setting it, or an extension that makes the field editable.

Christian

On Mon, Aug 12, 2019 at 10:18 AM Danny Roux <danny...@gmail.com> wrote:

We're using Reviewboard 3.0.15

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/da6e51f7-44b5-45b5-b3f7-acea97630e3d%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Danny Roux]

ok I see, thanks for the info. Just to make sure I read the doc correctly, it would be "rbt land" that would allow to not only commit the changes, but also to update the review to put the revision # in "change"?

On Monday, 12 August 2019 15:30:36 UTC-4, Christian Hammond wrote:

Hi Danny,

This is a non-editable field, and that's pretty important as the value is unique across review requests for a repository. If we allowed editing of the field, and someone put in an ID that was incorrect, it could conflict with a real-world ID now or even years in the future, causing a failure to post the review request.

To ensure the value is correct, the field should only be set if it's actually coming from a commit, in which case it should be set at upload time (via RBTools or a custom script/integration if you're using one). It can also be set through the API, so if you really want to make this editable, you could have a script that simplifies setting it, or an extension that makes the field editable.

Christian

On Mon, Aug 12, 2019 at 10:18 AM Danny Roux <danny...@gmail.com> wrote:

We're using Reviewboard 3.0.15

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/da6e51f7-44b5-45b5-b3f7-acea97630e3d%40googlegroups.com.