"There was an error displaying this diff"

16 views
Skip to first unread message

Illya Broder

unread,
May 3, 2020, 1:15:04 PM5/3/20
to Review Board Community
HI.

I'm getting this error along with "filedescriptor out of range in select()"

If I click on the "details" option it displays the following 

How do I solve this.

Regards,
Illya

raceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/reviews/views.py", line 179, in build_diff_comment_fragments
    comment.interfilediff)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 497, in get_last_line_number_in_diff
    f = get_file_from_filediff(context, filediff, interfilediff)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 481, in get_file_from_filediff
    request=request)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 429, in populate_diff_chunks
    chunks = list(generator.get_chunks())
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 756, in get_chunks
    for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 107, in get_chunks
    large_data=True)
  File "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py", line 295, in cache_memoize
    compress_large_data))
  File "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py", line 249, in cache_memoize_iter
    items = items_or_callable()
  File "/usr/lib/python2.6/site-packages/Djblets-0.9.3-py2.6.egg/djblets/cache/backend.py", line 292, in <lambda>
    lambda: [lookup_callable()],
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 106, in <lambda>
    lambda: list(self.get_chunks_uncached()),
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/chunk_generator.py", line 763, in get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 232, in get_patched_file
    return patch(diff, buffer, filediff.dest_file, request)
  File "/usr/lib/python2.6/site-packages/ReviewBoard-2.5.6.1-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 147, in patch
    stdout, stderr = p.communicate(diff)
  File "/usr/lib64/python2.6/subprocess.py", line 691, in communicate
    return self._communicate(input)
  File "/usr/lib64/python2.6/subprocess.py", line 1211, in _communicate
    rlist, wlist, xlist = select.select(read_set, write_set, [])
ValueError: filedescriptor out of range in select(

Christian Hammond

unread,
May 6, 2020, 7:41:18 PM5/6/20
to revie...@googlegroups.com
Hi Illya,

Hmm, that's an interesting one. This is coming from within Python itself, and I've never seen it before. It almost seems like it wasn't able to get a file handle, or keep it open, for reading/writing.

I just checked online, and it looks to be a bug in Python 2.6, which is horribly end-of-lifed (so is Python 2.7, but you can't run Review Board on Python 3 yet):


"Prior to Python 2.7, programs that used "ulimit -n" to enable communication with large numbers of subprocesses could still monitor only 1024 file descriptors at a time, which caused an exception: ValueError: filedescriptor out of range in select()"

Review Board 2.5 is also end-of-life'd, by the way. I'd suggest moving to Python 2.7 and Review Board 3.0.x, if possible. Review Board 3.0.x requires Python 2.7.

Review Board 4 is entering beta soon, and will be compatible with Python 2.7 and 3.6+.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/46025f9b-e476-4c9d-9fd2-0b1458c8ed8e%40googlegroups.com.


--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board
Reply all
Reply to author
Forward
0 new messages