--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/307d8c7a-5b4b-4451-bba5-2d8081d11f76%40googlegroups.com.
Hi,Hrm, I was sure we fixed this. At one point, the GitLab API didn't give us pagination information, but once it did we added support in places. It looks like branches never got that support.I'll look into it.However, I will strongly encourage you to use RBTools for posting changes for review, rather than manually selecting commits in the New Review Request page. It will give you a lot more flexibility in how you manage your commits locally and represent them on Review Board, and will avoid having to push to any centralized place prior to review (making it easier to amend your commits based on review feedback, rebase them prior to landing, etc.).Christian
--Hello,I managed to connect to my Gitlab repository and when I am creating new review I see the repository allright, I even see the branches and commits on them, but the problem is I don't see all the branches.
I only see exactly 20 of them. I am not sure if they are the newest ones or by which key they are selected. But I need all of the branches. The worst problem is I don't see master.
Is it some known issue? Is there some solution? I am not an experienced Git user, so maybe it might be just something trivial... I tested in several browsers, everywhere the same behavior.Gitlab version seems: GitLab Community Edition 12.10.1Reviewboard version: 3.0.12Thanks or any help and sorry if it is a noob question...
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/307d8c7a-5b4b-4451-bba5-2d8081d11f76%40googlegroups.com.
ERROR | - root - Unable to update new review request from commit ID 6a60ac36244fb185817055e6e9c404106b103260 on repository ID=2: HTTP Error 404: Not Found Traceback (most recent call last): File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\reviews\managers.py", line 165, in create draft.update_from_commit_id(commit_id) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\reviews\models\review_request_draft.py", line 419, in update_from_commit_id return self.update_from_committed_change(commit_id) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\reviews\models\review_request_draft.py", line 492, in update_from_committed_change commit = self.repository.get_change(commit_id) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\scmtools\models.py", line 509, in get_change return hosting_service.get_change(self, revision) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\hostingsvcs\gitlab.py", line 641, in get_change headers={'Accept': 'text/plain'}) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\hostingsvcs\service.py", line 188, in http_get return self.http_request(url, headers=headers, method='GET', **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\hostingsvcs\service.py", line 319, in http_request response = urlopen(request, context=context) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 154, in urlopen return opener.open(url, data, timeout) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 435, in open response = meth(req, response) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 467, in error result = self._call_chain(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 407, in _call_chain result = func(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 654, in http_error_302 return self.parent.open(new, timeout=req.timeout) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 435, in open response = meth(req, response) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 473, in error return self._call_chain(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 407, in _call_chain result = func(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 556, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 404: Not Found |
---|
ERROR | None - jiri.kortanek - /api/review-requests/ - djblets.log.middleware - Exception thrown for user jiri.kortanek at https://myserver.ad001.mycompany.net:444/api/review-requests/ HTTP Error 404: Not Found Traceback (most recent call last): File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\django\django\core\handlers\base.py", line 112, in get_response response = wrapped_callback(request, *callback_args, **callback_kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\django\django\views\decorators\cache.py", line 52, in _wrapped_view_func response = view_func(request, *args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\django\django\views\decorators\vary.py", line 19, in inner_func response = func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\resources\base.py", line 244, in __call__ request, method, view, api_format=api_format, *args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\webapi\base.py", line 338, in call_method_view request, method, view, *args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\resources\mixins\api_tokens.py", line 66, in call_method_view request, method, view, *args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\resources\mixins\oauth2_tokens.py", line 102, in call_method_view request, method, view, *args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\resources\base.py", line 369, in call_method_view return view(request, *args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\resources\base.py", line 470, in post return self.create(*args, **kwargs) File "build/bdist.macosx-10.11-x86_64/egg/rbpowerpack/extension/hooks.py", line 83, in _api_create_review_request File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\decorators.py", line 125, in _call return view_func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\webapi\decorators.py", line 169, in _check return view_func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\decorators.py", line 125, in _call return view_func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\decorators.py", line 146, in _checklogin return view_func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\decorators.py", line 125, in _call return view_func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\decorators.py", line 125, in _call return view_func(*args, **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\site-packages\djblets\webapi\decorators.py", line 311, in _validate return view_func(*args, **new_kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\webapi\resources\review_request.py", line 737, in create create_from_commit_id=create_from_commit_id) File "build/bdist.macosx-10.11-x86_64/egg/rbpowerpack/extension/hooks.py", line 79, in _create_review_request File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\reviews\managers.py", line 165, in create draft.update_from_commit_id(commit_id) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\reviews\models\review_request_draft.py", line 419, in update_from_commit_id return self.update_from_committed_change(commit_id) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\reviews\models\review_request_draft.py", line 492, in update_from_committed_change commit = self.repository.get_change(commit_id) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\scmtools\models.py", line 509, in get_change return hosting_service.get_change(self, revision) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\hostingsvcs\gitlab.py", line 641, in get_change headers={'Accept': 'text/plain'}) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\hostingsvcs\service.py", line 188, in http_get return self.http_request(url, headers=headers, method='GET', **kwargs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\apps\reviewboardpowerpack\htdocs\Lib\site-packages\ReviewBoard-3.0.12-py2.7.egg\reviewboard\hostingsvcs\service.py", line 319, in http_request response = urlopen(request, context=context) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 154, in urlopen return opener.open(url, data, timeout) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 435, in open response = meth(req, response) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 467, in error result = self._call_chain(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 407, in _call_chain result = func(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 654, in http_error_302 return self.parent.open(new, timeout=req.timeout) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 435, in open response = meth(req, response) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 467, in error result = self._call_chain(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 407, in _call_chain result = func(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 654, in http_error_302 return self.parent.open(new, timeout=req.timeout) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 435, in open response = meth(req, response) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 473, in error return self._call_chain(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 407, in _call_chain result = func(*args) File "C:\App\Bitnami\reviewboardpowerpack-3.0.12-1\python\lib\urllib2.py", line 556, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 404: Not Found |
---|
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/be0a286d-952e-4f75-99bb-6782e718623c%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/be0a286d-952e-4f75-99bb-6782e718623c%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/ba6bc547-24e2-4aa7-b378-5dd29c069ed9%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/ba6bc547-24e2-4aa7-b378-5dd29c069ed9%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/653fefda-9df3-431a-b3fc-2e95a8b7df0c%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/653fefda-9df3-431a-b3fc-2e95a8b7df0c%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/51322cc0-077a-433e-bfd3-f4d22a39cf37%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/51322cc0-077a-433e-bfd3-f4d22a39cf37%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/5c23cf64-b3e3-4ad8-9b21-abf2a60abb38%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/5c23cf64-b3e3-4ad8-9b21-abf2a60abb38%40googlegroups.com.
ERROR
py", line 169, in _check return view_func(*args, **kwargs) File &qu
--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/a3aef212-6852-4925-8404-62dc8cd816ddo%40googlegroups.com.
/r/41/diff/1/fragment/20/ - root - Fetching file 'Project/Emitter_Unit/source/application/Communication/TimeSynchronization/CServerUDP.cpp' rf26817a5eeeef5799a477b0d858b135781470b41 (base commit ID 9ba489121bb89c93900020b3838cb50f232df3ed) from GIT Leia - emitter took 0.343000 seconds
"
The error before was caused by him using wrong Review Board login user name :-) The error message was so vague though, that we found out by accident just recently. We will try to work with it further, but we would still rather have the browser form working...
To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/a3aef212-6852-4925-8404-62dc8cd816ddo%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/db9f55d7-a009-4562-abbc-a833d4fd3e26o%40googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/db9f55d7-a009-4562-abbc-a833d4fd3e26o%40googlegroups.com.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/65dec50e-7d64-42bf-af88-c83b0b7d59b6o%40googlegroups.com.
Well, it seems that they are using API token for non-API urls. That's not allowed (since one ot the many security updates). Therefore it can work only with public projects which don't protect these paths at all...
Not sure how they want to solve it other than clone the repository instead of using gitlab web URLs...
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/65dec50e-7d64-42bf-af88-c83b0b7d59b6o%40googlegroups.com.
--
--
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/fe478dc7-2068-4fa1-b83b-9b1432516bc5o%40googlegroups.com.
We're not planning to work on this.
What about the possibility #4 - fetch the git repository?
Unit tester/Team manager
Siemens, s.r.o.
Siemens Advanta Development
The colleague testing the RBTools was using this guide https://www.reviewboard.org/docs/rbtools/1.0/workflows/git/#rbtools-workflow-git</a
I think we are on the end of the road. The last statement from GitLab guys:
"We're not planning to work on this.
What about the possibility #4 - fetch the git repository?
"I don't suppose possibility #4 will work for you. So there goes using a convenient way of code review :-/There is still the RBTools left. Unfortunately the guy who should have tested it just went for paternal leave. I will try to find some time and test it myself.In any case, thanks for you patient support and have a nice day:-)Jiri KortanekUnit tester/Team manager
Siemens, s.r.o.Siemens Advanta Development
Dne úterý 23. června 2020 12:48:57 UTC+2 Christian Hammond napsal(a):
Yeah, it wasn't until I dug into this again (and actually wrote 95% of a patch for the Diff API) that I realized I had done all this investigation (and patch writing) already.It's not a bug on their end. It's an intentional change. However, it's a change that didn't have an equivalent for those that needed diffs from a commit.
Here's the ticket in question for the change in behavior: <a href="https://gitlab.com/gitlab-or
--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/dc74c041-a23b-4e13-8c66-93fc452b8b00o%40googlegroups.com.