DIFF error after upgrading from 2.5.16 to 3.0.15.

[Tahir Shehzad]

Hi Guys,

I did an upgrade from 2.5.16 to 3.0.15. No I cannot see diff file on new server. Please can you help with this.

Error I get:

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/views.py", line 345, in get
    response = renderer.render_to_response(request)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/renderers.py", line 58, in render_to_response
    return HttpResponse(self.render_to_string(request))
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/renderers.py", line 76, in render_to_string
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 299, in cache_memoize
    compress_large_data))
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 253, in cache_memoize_iter
    items = items_or_callable()
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 296, in <lambda>
    lambda: [lookup_callable()],
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/renderers.py", line 75, in <lambda>
    lambda: self.render_to_string_uncached(request),
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/renderers.py", line 89, in render_to_string_uncached
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/diffutils.py", line 750, in populate_diff_chunks
    chunks = list(generator.get_chunks())
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 786, in get_chunks
    for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 107, in get_chunks
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 299, in cache_memoize
    compress_large_data))
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 253, in cache_memoize_iter
    items = items_or_callable()
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 296, in <lambda>
    lambda: [lookup_callable()],
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 106, in <lambda>
    lambda: list(self.get_chunks_uncached()),
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 793, in get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/diffutils.py", line 271, in get_patched_file
    diff = tool.normalize_patch(filediff.diff, filediff.source_file,
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/models.py", line 250, in _get_diff
    return self.diff_hash.content
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/models.py", line 68, in content
    return bz2.decompress(self.binary)
IOError: invalid data stream

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/reviews/views.py", line 379, in build_diff_comment_fragments
    comment.interfilediff)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/diffutils.py", line 819, in get_last_line_number_in_diff
    f = get_file_from_filediff(context, filediff, interfilediff)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/diffutils.py", line 803, in get_file_from_filediff
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/diffutils.py", line 750, in populate_diff_chunks
    chunks = list(generator.get_chunks())
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 786, in get_chunks
    for chunk in super(DiffChunkGenerator, self).get_chunks(cache_key):
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 107, in get_chunks
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 299, in cache_memoize
    compress_large_data))
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 253, in cache_memoize_iter
    items = items_or_callable()
  File "/usr/local/lib/python2.7/dist-packages/djblets/cache/backend.py", line 296, in <lambda>
    lambda: [lookup_callable()],
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 106, in <lambda>
    lambda: list(self.get_chunks_uncached()),
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/chunk_generator.py", line 793, in get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/diffutils.py", line 271, in get_patched_file
    diff = tool.normalize_patch(filediff.diff, filediff.source_file,
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/models.py", line 250, in _get_diff
    return self.diff_hash.content
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/diffviewer/models.py", line 68, in content
    return bz2.decompress(self.binary)
IOError: invalid data stream

  

checking on board this refer to a bug that was cleared in 2.0.X release.

after the upgrade did not see the Repository  on reviewbaord so add them again manually by web GUI. After that compared  table reviewboard.scmtools_repository and corrected the ID as it were in old databases. restarted apache and mariadb.

I still got the same issue. 

rb-site --version

rb-site 3.0.15

Python 2.7.15+ (default, Oct  7 2019, 17:39:04)

[GCC 7.4.0]

Installed to /usr/local/lib/python2.7/dist-packages/reviewboard

Thanks In Advance.

Regards,

Tahir

[David Trowbridge]

Is this a new server in addition to the upgrade? If so, make sure you copy the SECRET_KEY from the old settings_local.py file to the new one.

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/5811abf4-e0c8-4f35-912b-194262f4c36c%40googlegroups.com.

[Tahir Shehzad]

Hi David,

Thanks for the your reply, I copy the old SECRET_KEY and paste in new server settings_local.py  and restart the apache. 

Still get the same error. There is one thing very weird about it. Some of the reviews before February 2016 works ok, But after Jan 2016 all gives the same error.

Please can you help with this.

Thanks,

Tahir

To unsubscribe from this group and stop receiving emails from it, send an email to revie...@googlegroups.com.

[niraj pandey]

Hello Tahir ,

Recently we upgraded review board from 2.5.x to 3.0.15 successfully.

I followed the following steps, see if this 

 for you.

1. Restore the DB on new host where we had installed version 3.0.15

2. Converted all tables of review board db from MyIsam to Innodb

3. Executed rb-site install /var/www/reviewboard

4. Copied secret key from old host to new host.

Thanks

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/6546e7e2-fc7b-46d0-b51c-09420efb73cf%40googlegroups.com.

[Tahir Shehzad]

Hi Niraj,

Thanks for the reply. I followed the same steps. Question here is that:

 did you copy the secret_key before the rb-site install /var/www/reviewboard or after?

did you copy /var/ww/reviews.old to new /var/www/reviews and did rb-site upgrade /var/www/reviewboard?

 did you just copied /htdocs/media/uploaded/files from old to new  and did rb-site install /var/www/reviewboard?

are you using perforce ? any issue with perforce or any other repositories.

Thanks,

Tahir

Thanks

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/6546e7e2-fc7b-46d0-b51c-09420efb73cf%40googlegroups.com.

[niraj pandey]

1- installed the key at last after configure the rb-site install.

2- No old setup copied , just ran rb-site install /var/www/reviewboard

3- Yes we are using perforce. Make sure python perforce module installed on host.

To validate this just run from python prompt

from P4 import P4.

Thanks

Niraj

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/26cea136-8e05-4392-9833-c4424e141f89%40googlegroups.com.