RBTools Ticket #4990: use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs

[Shubha Ramani]

To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/

New ticket #4990 by shubhar For Beanbag, Inc. ▸ RBTools use p4 fstat to capture 'headType' (file type) so that it can be displayed in ReviewBoard diffs What version are you running? 4.0.10 Describe the enhancement and the motivation for it. We would like filetypes to be displayed along with the diff'd files. The motivation is that people often check-in files with the wrong filetypes, which causes havoc in production. Information here: https://www.perforce.com/manuals/p4web/help/help_filetypes.html Please provide any additional information below. https://www.perforce.com/manuals/p4web/help/help_filetypes.html New Priority:Medium Type:Enhancement

[Christian Hammond]

To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/

New update by chipx86 For Beanbag, Inc. ▸ RBTools ▸ Ticket #4990 We agree, and have begun baking in some ability to capture data like that. The limiting factor is that diff formats generally don't include metadata like this, and Perforce diffs certainly don't. The long-term plan is to move our Perforce diff implementation over to DiffX, which later Review Board 4.0.x versions support. That'll allow us to capture data like that in RBTools. We still need to add UI for this in Review Board, and we're looking at that for Review Board 6 (in development) or 7. Status: - New + Confirmed

[Shubha Ramani]

To reply, visit https://hellosplat.com/s/beanbag/tickets/4990/

New update by shubhar

For Beanbag, Inc. ▸ RBTools ▸ Ticket #4990

Nice. Glad you're investigating a solution via DiffX. Thank You ! Shubha