Re: Review Board Ticket #4932: Error creating a review request with a SVN repository

14 views
Skip to first unread message

Christian Hammond

unread,
Jul 8, 2021, 10:03:50 PM7/8/21
to Christian Hammond, Daniel Morgan, reviewboa...@googlegroups.com
To reply, visit https://hellosplat.com/s/beanbag/tickets/4932/

New update by chipx86

For Beanbag, Inc. ▸ Review Board ▸ Ticket #4932 

Hmm, interesting. There must be a situation our unit tests aren't covering. Wonder what that diff looks like.


We'll get a fix into 4.0.4.
Status:
- New
+ Confirmed
Milestones:
+ Release-4.0.x
Tags:
+ SCM:Subversion
Assigned to:
+ chipx86

Christian Hammond

unread,
Jul 8, 2021, 10:03:55 PM7/8/21
to Christian Hammond, Daniel Morgan, reviewboa...@googlegroups.com

New update by chipx86

For Beanbag, Inc. ▸ Review Board ▸ Ticket #4932 

Are there any changes in that diff aside from standard modifications to files, deleted files, or newly-introduced files?

Daniel Morgan

unread,
Jul 11, 2021, 6:38:13 PM7/11/21
to Christian Hammond, Daniel Morgan, reviewboa...@googlegroups.com

New update by dkmorgan 

As far as I can tell no.
I got the same error with the addition of the attached file to the repository. (created for testing purposes)
It looks like 'modified_file_details' is undefined in this case.
If I comment out the following two lines, I no longer get the error, but obviously this isn't a very good workaround...


590        if parsed_file.modified_file_details.endswith(b'(nonexistent)'):
591            parsed_file.deleted = True
Files:
+

test.c

Yoshiaki JITSUKAWA

unread,
Jul 16, 2021, 4:05:08 AM7/16/21
to Yoshiaki JITSUKAWA, Daniel Morgan, Christian Hammond, reviewboa...@googlegroups.com

New update by unicodon 

Hi, I ran into the same issue with a simple diff (attached) on 4.0.3.


    if parsed_file.modified_file_details is not None and parsed_file.modified_file_details.endswith(b'(nonexistent)'):





also works for me as a workaround.


This error occurs on linenum=4 started with "@@", just after the first parse of diff header.
The line is not distinguished as "is_diff_header" by the DiffParser class and modified_file_details remains None. However SVNDiffParser tries to invoke modified_file_details.endswith() and results in an AttributeError exception.
Files:
+

main.c.patch
Reply all
Reply to author
Forward
0 new messages