Review Board Ticket #4932: Error creating a review request with a SVN repository

10 views

Skip to first unread message

Daniel Morgan

unread,

Jun 27, 2021, 7:38:49 PM6/27/21

to Daniel Morgan, reviewboa...@googlegroups.com

To reply, visit https://hellosplat.com/s/beanbag/tickets/4932/

New ticket #4932 by dkmorgan

For Beanbag, Inc. ▸ Review Board

Error creating a review request with a SVN repository

What version are you running?

4.02

What's the URL of the page containing the problem?

<root_url>/r/new/

What steps will reproduce the problem?

Create a new review request
Select a SVN repository
Select a commit

What is the expected output? What do you see instead?

Expect to be able to create a new review request but an error is shown instead.

What operating system are you using? What browser?

Server side: Ubuntu 18.04 LTS Client side: Windows 10, Edge browser

Please provide any additional information below.

The error in the log is as follows:

File "/usr/local/lib/python2.7/dist-packages/reviewboard/scmtools/svn/init.py", line 590, in parse_diff_header if parsed_file.modified_file_details.endswith(b'(nonexistent)'): AttributeError: 'NoneType' object has no attribute 'endswith'

The original code on lines 590-591 did not produce an error with Review Board 3.x. My guess is that the merge into the 4.x branch had some adverse effects.