Review Board Ticket #4879: Error when dispatching a webhook with auth credentials: AttributeError: 'SplitResult' object has no attribute 'params'

5 views

Skip to first unread message

Amir Yalon

unread,

Sep 10, 2020, 4:41:51 AM9/10/20

to Amir Yalon, reviewboa...@googlegroups.com

To reply, visit https://hellosplat.com/s/beanbag/tickets/4879/

New ticket #4879 by amiryal

For Beanbag, Inc. ▸ Review Board

Error when dispatching a webhook with auth credentials: AttributeError: 'SplitResult' object has no attribute 'params'

What version are you running?

3.0.18

What's the URL of the page containing the problem?

The error shows up in server logs:

2020-09-10 07:54:27,439 - INFO -  - root - Dispatching webhook for event review_request_published to https://username:pass...@example.com/path?param=value
2020-09-10 07:54:27,440 - ERROR -  - root - Could not dispatch WebHook to https://username:pass...@example.com/path?param=value: 'SplitResult' object has no attribute 'params'
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/reviewboard/notifications/webhooks.py", line 299, in dispatch_webhook_event
    url_parts.params, url_parts.query))
AttributeError: 'SplitResult' object has no attribute 'params'

Please provide any additional information below.

See my comment on the failing code, which still lives in latest master.

Both Python 3 and legacy Python 2 have the same interface, so it shouldn’t matter that my site is still running on Python 2.

New Priority:Medium Type:Defect

Amir Yalon

unread,

Sep 14, 2020, 6:57:40 AM9/14/20

to Amir Yalon, reviewboa...@googlegroups.com

To reply, visit https://hellosplat.com/s/beanbag/tickets/4879/

New update by amiryal

For Beanbag, Inc. ▸ Review Board ▸ Ticket #4879

I now have a fix running our production site and a forward-ported version of the fix up for review. The proposed patch series also includes additional logging and a fix for sending credentials unconditionally to servers that do not respond with 401.

Amir Yalon

unread,

Sep 21, 2020, 3:43:35 AM9/21/20

to Amir Yalon, reviewboa...@googlegroups.com

To reply, visit https://hellosplat.com/s/beanbag/tickets/4879/

New update by amiryal

For Beanbag, Inc. ▸ Review Board ▸ Ticket #4879

New version of the fix: https://reviews.reviewboard.org/r/11191/

New version of the logging and fix for sending credentials: https://reviews.reviewboard.org/r/11192/ https://reviews.reviewboard.org/r/11193/

Reply all

Reply to author

Forward

0 new messages