Review Board Ticket #4836: Diff parsing error when file name is weird

2 views
Skip to first unread message

Wenqin Wang

unread,
Jul 25, 2019, 2:39:25 PM7/25/19
to Wenqin Wang, reviewboa...@googlegroups.com
To reply, visit https://hellosplat.com/s/beanbag/tickets/4836/

New ticket #4836 by wenqinwang

For Beanbag, Inc. Review Board

Diff parsing error when file name is weird

What version are you running?

Reviewboard 3.0.5

What's the URL of the page containing the problem?

N/A

What steps will reproduce the problem?

1.create a repo 2.file name is /java-library/src/mp/{{ product_name }}-impl/src/main/java/com/linkedin/{{ product_name | replace(/"-/", /"/") }}/HelloMP.java 3. create a review request

What is the expected output? What do you see instead?

it should parse correctly see RB file name as "b/java-library/src/mp/{{ product_name }}-impl/src/main/java/com/linkedin/{{ product_name | replace(/"-/", /"/") }}/HelloMP.java"

and

"a/java-library/src/mp/{{ product_name }}-impl/src/main/java/com/linkedin/{{ product_name | replace(/"-/", /"/") }}/HelloMP.java"

What operating system are you using? What browser?

Chrome

Please provide any additional information below.

New Priority:Medium Type:Defect
Reply all
Reply to author
Forward
0 new messages