Gerrit UI "hide commit" is not show - server version 3.6.1

[Guy Levkowitz]

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

incoming review

After review is done – the author left change without actions – for some (unrelevant) reason

 I now do not want to see the change in the list of Incoming reviews

is this option was remove in the new UI ?

thanks

Guy

[Luca Milanesio]

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

Luca.

incoming review

After review is done – the author left change without actions – for some (unrelevant) reason

 I now do not want to see the change in the list of Incoming reviews

is this option was remove in the new UI ?

thanks

Guy

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/7a106ca9-05ad-46e5-b3f7-00a2bd7e2415n%40googlegroups.com.

[Sven Selberg]

On Wednesday, November 30, 2022 at 2:47:07 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

I believe Guy is talking about the "Ignore" feature that was removed in 3.5 together with "stars" feature .
Tried to find more but the removal doesn't seem to be very documented.

[Luca Milanesio]

On 30 Nov 2022, at 14:07, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 2:47:07 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

I believe Guy is talking about the "Ignore" feature that was removed in 3.5 together with "stars" feature .
Tried to find more but the removal doesn't seem to be very documented.

Do you have a screenshot for this? 

(v3.5 vs. v3.6)

Luca.

 

Luca.

incoming review

After review is done – the author left change without actions – for some (unrelevant) reason

 I now do not want to see the change in the list of Incoming reviews

is this option was remove in the new UI ?

thanks

Guy

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/7a106ca9-05ad-46e5-b3f7-00a2bd7e2415n%40googlegroups.com.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/12add890-efcb-41ac-a3c6-5615c3fdc3c0n%40googlegroups.com.

[Sven Selberg]

On Wednesday, November 30, 2022 at 3:18:38 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 14:07, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 2:47:07 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

I believe Guy is talking about the "Ignore" feature that was removed in 3.5 together with "stars" feature .
Tried to find more but the removal doesn't seem to be very documented.

Do you have a screenshot for this? 

(v3.5 vs. v3.6)

It's removed in 3.5 (FWICT) so you'd need a screenshot v3.(2|3|4) vs 3.5.

[Luca Milanesio]

On 30 Nov 2022, at 14:31, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 3:18:38 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 14:07, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 2:47:07 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

I believe Guy is talking about the "Ignore" feature that was removed in 3.5 together with "stars" feature .
Tried to find more but the removal doesn't seem to be very documented.

Do you have a screenshot for this? 

(v3.5 vs. v3.6)

It's removed in 3.5 (FWICT) so you'd need a screenshot v3.(2|3|4) vs 3.5.

$ docker run -ti -p 80:8080 -h localhost gerritcodereview/gerrit:3.4.5

I could run locally, but I have no idea of an “ignore commits” feature or button, so I won’t know where to look :-(

Can you run the above and take the screenshot?

Luca.

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/87e22aed-54cd-4674-bfdb-098d60fd60fcn%40googlegroups.com.

[Sven Selberg]

On Wednesday, November 30, 2022 at 3:35:39 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 14:31, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 3:18:38 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 14:07, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 2:47:07 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

I believe Guy is talking about the "Ignore" feature that was removed in 3.5 together with "stars" feature .
Tried to find more but the removal doesn't seem to be very documented.

Do you have a screenshot for this? 

(v3.5 vs. v3.6)

It's removed in 3.5 (FWICT) so you'd need a screenshot v3.(2|3|4) vs 3.5.

$ docker run -ti -p 80:8080 -h localhost gerritcodereview/gerrit:3.4.5

I could run locally, but I have no idea of an “ignore commits” feature or button, so I won’t know where to look :-(

Can you run the above and take the screenshot?

Sorry!

It's a change-action so in the action drop-down (top right) on the change-screen.
I checked 3.4 but it wasn't present there, must have been removed earlier.

[Luca Milanesio]

On 30 Nov 2022, at 14:56, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 3:35:39 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 14:31, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 3:18:38 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 14:07, Sven Selberg <sven.s...@axis.com> wrote:

On Wednesday, November 30, 2022 at 2:47:07 PM UTC+1 lucamilanesio wrote:

On 30 Nov 2022, at 13:19, Guy Levkowitz <sil...@gmail.com> wrote:

Hi

In the old UI (old version 3.2.3) it was possible to hide commit that is not relevant anymore
Now I do not see such link anymore.

I don’t recall any option to hide commits from a change: can you share a screenshot?

I believe Guy is talking about the "Ignore" feature that was removed in 3.5 together with "stars" feature .
Tried to find more but the removal doesn't seem to be very documented.

Do you have a screenshot for this? 

(v3.5 vs. v3.6)

It's removed in 3.5 (FWICT) so you'd need a screenshot v3.(2|3|4) vs 3.5.

$ docker run -ti -p 80:8080 -h localhost gerritcodereview/gerrit:3.4.5

I could run locally, but I have no idea of an “ignore commits” feature or button, so I won’t know where to look :-(

Can you run the above and take the screenshot?

Sorry!

It's a change-action so in the action drop-down (top right) on the change-screen.
I checked 3.4 but it wasn't present there, must have been removed earlier.

<action-menu.png>

This is my screenshot of the v3.2.14: I don’t see any “ignore commits” change action on the change-screen:

@Guy do you have any screenshot to share with the “ignore commits” feature that was removed?

Luca.

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/c79a9f2d-e658-41cd-9829-7c710e4865afn%40googlegroups.com.
<action-menu.png>

[Ben Rohlfs]

The change action was called just "Ignore".

Here is the change that removed it (for 3.6 I think): 321608: Completely remove the "Ignore" feature from Gerrit's web app | https://gerrit-review.git.corp.google.com/c/gerrit/+/321608

From the change message:

"If you want to ignore a change, then you can remove yourself from the
attention set or the list of reviewers/ccs. That makes it also clearer
to your collaborators that you don't want to participate."

-Ben

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/7CE6235A-0203-4F93-B0A8-37A1CB97A143%40gmail.com.

[Luca Milanesio]

On 30 Nov 2022, at 15:43, Ben Rohlfs <bro...@google.com> wrote:

The change action was called just "Ignore".

Here is the change that removed it (for 3.6 I think): 321608: Completely remove the "Ignore" feature from Gerrit's web app | https://gerrit-review.git.corp.google.com/c/gerrit/+/321608

Thanks, Ben, for the pointer, I can see that it appears if you are the reviewer of a change.

From the change message:

"If you want to ignore a change, then you can remove yourself from the
attention set or the list of reviewers/ccs. That makes it also clearer
to your collaborators that you don't want to participate."

Yeah, it looks like it was misleading anyway: after having hit “ignore” I am still in the list of reviewers and in the attention-set.

However, the change could have been excluded by adding the predicated "-is:ignored” to the change query.

Honestly, I’ve never used it and it did not impact my dashboard either.

None of our setups used it also, and nobody on GerritHub.io ever complained: we have tens of thousands of active users on it !

This is one of the things that were overlapping with the attention-set feature and therefore make sense to remove for the consistency of the product.

I am going to update the Gerrit v3.5 release notes to list this into the “Breaking Changes” section.

@Guy would the work for you?

Luca.

-Ben

[Luca Milanesio]

On 30 Nov 2022, at 16:14, Luca Milanesio <luca.mi...@gmail.com> wrote:

On 30 Nov 2022, at 15:43, Ben Rohlfs <bro...@google.com> wrote:

The change action was called just "Ignore".

Here is the change that removed it (for 3.6 I think): 321608: Completely remove the "Ignore" feature from Gerrit's web app | https://gerrit-review.git.corp.google.com/c/gerrit/+/321608

Thanks, Ben, for the pointer, I can see that it appears if you are the reviewer of a change.

<Screenshot 2022-11-30 at 16.09.25.png>

From the change message:

"If you want to ignore a change, then you can remove yourself from the
attention set or the list of reviewers/ccs. That makes it also clearer
to your collaborators that you don't want to participate."

Yeah, it looks like it was misleading anyway: after having hit “ignore” I am still in the list of reviewers and in the attention-set.

However, the change could have been excluded by adding the predicated "-is:ignored” to the change query.

Honestly, I’ve never used it and it did not impact my dashboard either.

None of our setups used it also, and nobody on GerritHub.io ever complained: we have tens of thousands of active users on it !

This is one of the things that were overlapping with the attention-set feature and therefore make sense to remove for the consistency of the product.

I am going to update the Gerrit v3.5 release notes to list this into the “Breaking Changes” section.

Done with:

https://gerrit-review.googlesource.com/c/homepage/+/353494

Luca.

[Guy Levkowitz]

First of all, thank all for this Investigation,
this request comes from one of our developers 

I am going to update the Gerrit v3.5 release notes to list this into the “Breaking Changes” section.   - what do you mean - is this feature will be added in the future Gerrit version?   or just as update news that this option was remove ? 

ב-יום רביעי, 30 בנובמבר 2022 בשעה 18:26:23 UTC+2, lucamilanesio כתב/ה:

[Luca Milanesio]

On 1 Dec 2022, at 07:22, Guy Levkowitz <sil...@gmail.com> wrote:

First of all, thank all for this Investigation,
this request comes from one of our developers 

I am going to update the Gerrit v3.5 release notes to list this into the “Breaking Changes” section.   - what do you mean - is this feature will be added in the future Gerrit version? 

The change was actually on Gerrit v3.6, see it included in the release notes at [1].

 or just as update news that this option was remove ? 

Is an update on the release notes: the feature has been already removed a long ago but NOT properly mentioned, until now.

Thanks again for pointing this out and allowing us to identify the gap in the notes.

Luca.

[1] https://www.gerritcodereview.com/3.6.html#breaking-changes

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/4b6bdc43-9b4b-4223-89de-04a7b2bc9fc1n%40googlegroups.com.