Gerrit 3.7.0 bulk voting

[Cory Todd]

Hi all,

We are having some trouble with bulk voting and I am hoping it is something I am doing wrong or misunderstanding. This issue affects users without the Code Review permission (we know that Code Review cannot be done in bulk because of [0]).

The scenario is that we a project_foo and two changes change_a and change_b.

- a user selects these two changes from the open changes list using the check boxes

- user clicks vote

- user is give the option to cancel or vote

- user clicks vote (there is no option for -1/+1)

- success message is shown but no votes are cast

Is there a configuration that affects this that I should be looking at?

[0] https://gerrit-review.googlesource.com/c/gerrit/+/334260

[Dhruv Srivastava]

- user clicks vote (there is no option for -1/+1)

User clicks vote when there are no labels shown to them?

Can you attach a screenshot of what the vote dialog looks like?

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/33563918-e062-4963-9258-b0d57eb1ff04n%40googlegroups.com.

[Cory Todd]

Correct, this is what I see

[Dhruv Srivastava]

This is what the dialog is supposed to be, with the warning explaining why CR is not possible.
I am not sure why you do not see this warning.

> - user clicks vote (there is no option for -1/+1)

I am a bit surprised why the user is clicking vote in this case(what are they expecting to happen).
Looking at the dialog, it should be clear that no voting is possible. :)

Nevertheless, it is a bug. Here is the fix. Thanks for reporting. :D

359020: Disable bulk vote flow button if no votes possible | https://gerrit-review.git.corp.google.com/c/gerrit/+/359020

[Dhruv Srivastava]

Maybe the user does not see the warning because they don't have the permission.
(Should have read closely :D)

[Cory Todd]

> This is what the dialog is supposed to be, with the warning explaining why CR is not possible.
> I am not sure why you do not see this warning.

> Maybe the user does not see the warning because they don't have the permission

We see that explanation/warning if the user has Code Review -2/+2 privileges but not -1/+1. 

Permissions seem to be the cause of the missing text problem, thank you :)

> 359020: Disable bulk vote flow button if no votes possible

Under what conditions are bulk votes possible? That's really what we're after here since we deal with pretty 

large patch sets so bulk votes would be a nice feature. I don't have visibility into that bug report to learn more.

[Dhruv Srivastava]

359020: Disable bulk vote flow button if no votes possible | https://gerrit-review.googlesource.google.com/c/gerrit/+/359020

This URL should work for you. :)

[Dhruv Srivastava]

359020: Disable bulk vote flow button if no votes possible | https://gerrit-review.googlesource.com/c/gerrit/+/359020 (3rd time's the charm?).

[Matthias Sohn]

I guess you meant

https://gerrit-review.googlesource.com/c/gerrit/+/359020

you changed the displayed text but not the URL ;-)

To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/CAPdu4sMYyLF0tL%2BTqfo6OBtuwWf8y%3DoeiujbHmCZii1O6rPcWw%40mail.gmail.com.

[Cory Todd]

Thanks for the url and the quick fix on that! We tested locally and that does disable the vote button for us.

I see now that we would need to introduce some other label against which bulk votes could be cast.