verify-status-plugin on polygerrit UI (sponsored development?)

200 views
Skip to first unread message

Alexander Lutay

unread,
Jul 31, 2019, 9:16:33 AM7/31/19
to Repo and Gerrit Discussion
Hi all,

Our company is using Gerrit 2.16.10 with plugin 'verify-status' and happy about it.
Most of our developers are using old interface as verify-status "condensed view" is missing in PolyGerrit UI,
You can find "condensed view" description on the main picture here:

At the moment we cannot migrate to Gerrit 3.0+ as old web interface has been removed there.

The discussion has been started at least twice, but still topical:

Also we have been pointed to possible solution with plugin 'checks' (see attached picture).
Unfortunately no documentation available to configure and try it locally:

Personally I like the plugin "checks" style. I looks solid with PolyGerrit UI, but cannot try it locally due to missing documentation.
Keeping in mind years with plugin 'verify-status' and huge amount of results in 'verify-status' DB I would to stay with 'verify-status'.

This is a topic to request support PolyGerrit UI for plugin 'verify-status'.
Better options are welcome!

We are open for sponsored development here, so looking for a hero!

P.S. Maybe it is possible to teach plugin 'checks' to show results from plugin 'verity-status' DB?

Tnx!

Screenshot from 2019-07-31 15-00-31.png

Luca Milanesio

unread,
Jul 31, 2019, 9:45:54 AM7/31/19
to Alexander Lutay, Luca Milanesio, Repo and Gerrit Discussion
Sponsored development? What do you mean exactly?

BTW ... the Gerrit Code Review for Jenkins (see https://wiki.jenkins.io/display/JENKINS/Gerrit+Code+Review+Plugin) will very soon fully support the checks API and  will then provide the nice-UI integrated with PolyGerrit.
Instead of pointing to a "dead horse", I would rather look into moving to the new plugin. WDYT?

Luca.


P.S. Maybe it is possible to teach plugin 'checks' to show results from plugin 'verity-status' DB?

Tnx!


--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/9f7825a2-cf27-4f1d-830c-25eb6108240a%40googlegroups.com.
<Screenshot from 2019-07-31 15-00-31.png>

Kévin Raymond

unread,
Jul 31, 2019, 9:52:02 AM7/31/19
to Alexander Lutay, Repo and Gerrit Discussion
Hi Alexander,

I've just checked today If I sent this from the right email account
not having received any answer. Of course open source projects prefers
to deal with community hackers but sponsored development is probably
not forbidden.

My last idea is to move from the verify-status to custom label only
and as you've expected using the 'checks' plugin. I haven't tried it
yet but it is really new (read old thread for gerrithub about this).

Yes Luca, same here, I felt alone using this "dead horse" moving to
something new should probably be the best idea.
However, I really liked the idea to smartly aggregate results (direct
link to test results, time spent, select the verified label depending
on specific results…)
Following the Gerrit development, this check things looks promising.

Alexander Lutay

unread,
Jul 31, 2019, 10:48:21 AM7/31/19
to Repo and Gerrit Discussion
Hi,

First of all, thank you for the fast replies here.

> Sponsored development? What do you mean exactly?

We can consider to pay for the development here as our business depends on the software we are using.
This is a common practice in an open-source world for not-yet-available features. Is it forbidden here?

> the Gerrit Code Review for Jenkins (see https://wiki.jenkins.io/display/JENKINS/Gerrit+Code+Review+Plugin)
> will very soon fully support the checks API and  will then provide the nice-UI integrated with PolyGerrit.

I see some problems:
1) The word 'will' doesn't allow us to migrate to new PolyGerrit WEB now. Also Gerrit 2.16 will be unsupported very soon.
2) We are on Gerrit 2.16 in production and plugin "checks" is in Gerrit 3.0+, so we will not be able to test it before the Gerrit upgrade. And we cannot upgrade without testing new polyWEB with our team.
3) AFAIK "Gerrit+Code+Review+Plugin" is upcoming replacement for Jenkins "Gerrit+Trigger" and not a replacement for Gerrit 'verify-status' AS IS.
So migration there might be even more complex and expensive. IMHO this is separate and not related discussion here. Sure we will check it when it is ready.

> Instead of pointing to a "dead horse", I would rather look into moving to the new plugin. WDYT?

We are also a software development company and we are also on a fast track.
I do understand your willing to "bury a dead horse" but for us it is still alive in Gerrit 2.16 era
and there is no replacement we can try as for today.

For sure I am open for migration to something better, so I would like to give a try for plugin "checks".
AFAIK it is not ready for production usage right now. As I can see it is under the heavy and active development
(at least 8 people have committed something into plugin 'checks' codebase recently). Maybe someone can commit

> Of course open source projects prefers to deal with community hackers but sponsored development is probably not forbidden.

Even hackers want to eat sometimes. ;-)


> I felt alone using this "dead horse" moving to something new should probably be the best idea.
...
> Following the Gerrit development, this check things looks promising.

I am open for move but there is no options as for today.
All possible solutions are in development and will not be available in Gerrit 2.16.
For us it is important to separate migration to the new plugin and further gerrit upgrade.
I prefer small steps often, instead a huge jump into the abyss.

It looks like we will have to stay on 2.16 (for the next couple years?) until new concept is ready and then consider migration.
With a modern GitHub/GitLab functionality maybe it will be a right choise to jump directly there.

Thank you for the replies here once again!

Luca Milanesio

unread,
Jul 31, 2019, 10:55:05 AM7/31/19
to Alexander Lutay, Luca Milanesio, Repo and Gerrit Discussion

On 31 Jul 2019, at 09:48, Alexander Lutay <a.l...@gmail.com> wrote:

Hi,

First of all, thank you for the fast replies here.

> Sponsored development? What do you mean exactly?

We can consider to pay for the development here as our business depends on the software we are using.
This is a common practice in an open-source world for not-yet-available features. Is it forbidden here?

In the Gerrit Code Review project itself you *cannot* be paid by the community to work on it OR (the other way around) you cannot pay the community to work on it.
The Gerrit Community isn't an entity per-se and isn't a charity or a non-profit: it cannot spend or receive money or even donations.

Companies pay their employees (or contractors) to work on Gerrit and you can for sure engage with private individuals and setup a SOW and a contract with them.

If you are interested, companies also make business with Gerrit (e.g. GerritForge) and you may want to engage with them to get your Gerrit customisations and plugins supported, extended and having also brand-new development done for you.

Hope this clarifies the "sponsored development" topic :-)

Luca.
 

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Alexander Lutay

unread,
Jul 31, 2019, 11:09:39 AM7/31/19
to Repo and Gerrit Discussion
Hi,

On Wednesday, July 31, 2019 at 4:55:05 PM UTC+2, lucamilanesio wrote:
...

Hope this clarifies the "sponsored development" topic :-)


The part is clear. Thank you!

Dear "companies also make business with Gerrit", feel free to contact me directly if you are willing to help us with "verify-status" PolyGerrit support. Tnx!

Nasser Grainawi

unread,
Jul 31, 2019, 4:00:07 PM7/31/19
to Alexander Lutay, Repo and Gerrit Discussion
On Jul 31, 2019, at 8:48 AM, Alexander Lutay <a.l...@gmail.com> wrote:

Hi,


Hi!

It's not verify-status, but the 'task' plugin [1] does have support for 2.16 and we plan to support it for 3.0 and beyond as well. There is documentation on how to configure it [2], though I'm sure it works differently than verify-status.

Just another option to consider.

Nasser




--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/6b8ddfe8-8707-4a6b-831c-a2279965f0f8%40googlegroups.com.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project

Luca Milanesio

unread,
Aug 1, 2019, 8:41:54 AM8/1/19
to Nasser Grainawi, Luca Milanesio, Alexander Lutay, Repo and Gerrit Discussion
I believe Alexander's goal is to reuse and render all *existing* verify-status plugin data that is on the DBMS.
Then, porting the verify-status plugin to PolyGerrit and render that data similarly to what the checks plugin does is the only viable option for them.

Luca.




-- 
-- 
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/6b8ddfe8-8707-4a6b-831c-a2279965f0f8%40googlegroups.com.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project


-- 
-- 
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

--- 
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Björn Pedersen

unread,
Aug 2, 2019, 1:39:15 AM8/2/19
to Repo and Gerrit Discussion
Hi,

See also https://groups.google.com/forum/#!topic/repo-discuss/Tq7iao1lTTo where I tried to at least provide a simple adoption, but got stuck at the gwt part...

Alexander Lutay

unread,
Aug 2, 2019, 10:38:01 AM8/2/19
to Repo and Gerrit Discussion
Hi,

>  It's not verify-status, but the 'task' plugin...

> Just another option to consider.

Thank you Nasser, for sharing plugin 'task'. Correct me if I am wrong,
but it looks like the main goal for the plugin 'task' is "workflow control"
(e.g. what should be triggered on Jenkins on new patchset upload, etc).
And representing results is just a side-effect functionality.

In our case "verify-status" is just a visualization solution.
The CI/Jenkins jobs orchestrations happens on Jenkins side
(in Git/Jenkins-Jobs-Builder in our case) and we would like to keep it.

Thank you for sharing the plugin name, I will check it more carefully next week.

==============

> I believe Alexander's goal is to reuse and render all *existing* verify-status plugin data that is on the DBMS.

Correct. But we can consider to migrate test results from
the "verify-status"-PostgreSQL-DB to some new plugin DB
if some (stable) API is available.

> Then, porting the verify-status plugin to PolyGerrit and render that data similarly to what the checks plugin does is the only viable option for them.

This is a thread to count amount of users which uses "verify-status" plugin and would like to have it in PolyGerrit UI.

As I said, we consider to migrate to "checks" and will have to migrate to "Gerrit+Code+Review+Plugin" one day (at least to be in trend),
but as for now we are solving the problem of migration to new PolyGerrit UI for our developers providing them all the necessary information in Gerrit review.

============================

> See also https://groups.google.com/forum/#!topic/repo-discuss/Tq7iao1lTTo where I tried to at least provide a simple adoption, but got stuck at the gwt part...

Tnx Björn! I saw those thread, but I know nothing about GWT. I am from VoIP world.
I can really help you with testing there, but not with development. My Java level is "read only" :-)

Have fun!

DmitryB

unread,
Aug 3, 2019, 8:58:00 AM8/3/19
to Repo and Gerrit Discussion
Hello, everyone

I had a simillar task to port HideCI.js test_result_table to PolyGerrit UI. This script collects Verified verdicts from change comments and fill the table with it.
For now a have a PoC for such polygerrit plugin https://pastebin.com/hw81K8AV
Hope it helps.

screenshot.png


Paladox none

unread,
Aug 3, 2019, 12:03:12 PM8/3/19
to Repo and Gerrit Discussion
@DmitryB hi, that looks awesome! What license would you put it under? Apache-2.0 (https://www.apache.org/licenses/LICENSE-2.0)?

Paladox none

unread,
Aug 3, 2019, 12:19:07 PM8/3/19
to Repo and Gerrit Discussion
Do you mind creating a github repo, with the license so that users can properly attribute you (by linking to it, if the user decides to install it?).

I would like to try this at the wikimedia foundation (but i would need to properly attribute it to you) (when we upgrade to 2.16).

DmitryB

unread,
Aug 3, 2019, 1:07:01 PM8/3/19
to Repo and Gerrit Discussion
Uploaded to https://github.com/dburm/pg-test-result-plugin
MIT license should be enough i guess.

Paladox none

unread,
Aug 3, 2019, 1:12:04 PM8/3/19
to Repo and Gerrit Discussion
Thanks!

David Howden

unread,
Aug 4, 2019, 6:52:20 PM8/4/19
to Repo and Gerrit Discussion
Also we have been pointed to possible solution with plugin 'checks' (see attached picture).
Unfortunately no documentation available to configure and try it locally:

We are also looking at integrating our CI system (largely based on a simple Google Cloud Build process) into Gerrit and have been waiting for the Checks plugins to "come of age" since we're already running Gerrit 3.

Is there a planned timetable for the full docs?

Thanks,

David.

Björn Pedersen

unread,
Aug 16, 2019, 5:28:28 AM8/16/19
to Repo and Gerrit Discussion
Hi,

I created a crude polyui integration now.


Björn
Reply all
Reply to author
Forward
0 new messages