Gerrit 3.8.0 and LFS plugin

418 views
Skip to first unread message

szjo...@gmail.com

unread,
May 22, 2023, 9:59:18 AM5/22/23
to Repo and Gerrit Discussion
Hello There is plans for and updated lfs plugin, it seems the one form 3.7 and from master is not compatible with gerrit 3.8.0

```
java.lang.NoClassDefFoundError: com/google/gerrit/server/ProjectUtil
        at com.googlesource.gerrit.plugins.lfs.LfsApiServlet.getLargeFileRepository(LfsApiServlet.java:85)
        at org.eclipse.jgit.lfs.server.LfsProtocolServlet.doPost(LfsProtocolServlet.java:182)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
        at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:290)
        at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:280)
```
```
java.lang.NoClassDefFoundError: com/google/gerrit/server/ProjectUtil
        at com.googlesource.gerrit.plugins.lfs.LfsApiServlet.getLargeFileRepository(LfsApiServlet.java:85)
        at org.eclipse.jgit.lfs.server.LfsProtocolServlet.doPost(LfsProtocolServlet.java:182)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
        at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:290)
        at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:280)
```

Tom Powell

unread,
May 24, 2023, 2:27:08 AM5/24/23
to Repo and Gerrit Discussion
It's busted. I fixed it for our install, the patch is at https://zifnab.net/~zifnab/0001-3.8-updates.patch, I've also put a jar at https://zifnab.net/~zifnab/lfs.jar (but you shouldn't trust this and should build it yourself).

Thanks,
Tom

Luca Milanesio

unread,
May 24, 2023, 3:41:46 AM5/24/23
to Repo and Gerrit Discussion, Luca Milanesio, Tom Powell

On 23 May 2023, at 18:45, Tom Powell <zif...@zifnab06.net> wrote:

It's busted. I fixed it for our install, the patch is at https://zifnab.net/~zifnab/0001-3.8-updates.patch, I've also put a jar at https://zifnab.net/~zifnab/lfs.jar (but you shouldn't trust this and should build it yourself).

Thanks, Tom.

Why don’t you become a contributor to the LFS plugin? See the contributors’ guide at:

Luca.


Thanks,
Tom

On Monday, May 22, 2023 at 6:59:18 AM UTC-7 szjo...@gmail.com wrote:
Hello There is plans for and updated lfs plugin, it seems the one form 3.7 and from master is not compatible with gerrit 3.8.0

```
java.lang.NoClassDefFoundError: com/google/gerrit/server/ProjectUtil
        at com.googlesource.gerrit.plugins.lfs.LfsApiServlet.getLargeFileRepository(LfsApiServlet.java:85)
        at org.eclipse.jgit.lfs.server.LfsProtocolServlet.doPost(LfsProtocolServlet.java:182)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
        at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:290)
        at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:280)
```
```
java.lang.NoClassDefFoundError: com/google/gerrit/server/ProjectUtil
        at com.googlesource.gerrit.plugins.lfs.LfsApiServlet.getLargeFileRepository(LfsApiServlet.java:85)
        at org.eclipse.jgit.lfs.server.LfsProtocolServlet.doPost(LfsProtocolServlet.java:182)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:707)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
        at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:290)
        at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:280)
```

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/279b874a-12db-4828-af8e-dbc4d2c01543n%40googlegroups.com.

Thomas Broyer

unread,
Jun 2, 2023, 1:15:56 PM6/2/23
to Repo and Gerrit Discussion
On Wednesday, May 24, 2023 at 9:41:46 AM UTC+2 Luca Milanesio wrote:

On 23 May 2023, at 18:45, Tom Powell <zif...@zifnab06.net> wrote:

It's busted. I fixed it for our install, the patch is at https://zifnab.net/~zifnab/0001-3.8-updates.patch, I've also put a jar at https://zifnab.net/~zifnab/lfs.jar (but you shouldn't trust this and should build it yourself).

Thanks, Tom.

Why don’t you become a contributor to the LFS plugin? See the contributors’ guide at:

We're facing that same issue. I'm preparing a patch that I'll push for review, but shouldn't there be a stable/3.7 branch (or whatever) created from the current master for the pre-3.8 versions?
How should the gerrit-ci-scripts be updated then?

(fwiw, https://www.gerritcodereview.com/plugins.html#plugin-matrix is out of date: doesn't list 3.8 and 3.7 branches)

Fabio Ponciroli

unread,
Jun 2, 2023, 1:28:38 PM6/2/23
to Thomas Broyer, Repo and Gerrit Discussion
Hi Thomas,


Thanks for reposting it. I have created a patch for the outdated list [1].
As soon as it will be merged the matrix will be updated.

--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.

Thomas Broyer

unread,
Jun 2, 2023, 1:42:56 PM6/2/23
to Repo and Gerrit Discussion
On Friday, June 2, 2023 at 7:15:56 PM UTC+2 Thomas Broyer wrote:
On Wednesday, May 24, 2023 at 9:41:46 AM UTC+2 Luca Milanesio wrote:

On 23 May 2023, at 18:45, Tom Powell <zif...@zifnab06.net> wrote:

It's busted. I fixed it for our install, the patch is at https://zifnab.net/~zifnab/0001-3.8-updates.patch, I've also put a jar at https://zifnab.net/~zifnab/lfs.jar (but you shouldn't trust this and should build it yourself).

Thanks, Tom.

Why don’t you become a contributor to the LFS plugin? See the contributors’ guide at:

We're facing that same issue. I'm preparing a patch that I'll push for review

Two patches actually:
Reply all
Reply to author
Forward
0 new messages