Dashboard "Status: Ready" vs submit requirements

143 views
Skip to first unread message

Karol Latecki

unread,
Feb 9, 2023, 7:35:16 PM2/9/23
to Repo and Gerrit Discussion
Hi all!

How does main dashboard "Status" column relate to patch submission conditions?

I am using following configuration in my project.config.
What I am trying to achieve here is that the change to be only possible to merge with +1 Verified and double +2 Code-Review votes.

[label "Code-Review"]
    function = NoBlock
    defaultValue = 0
    value = -2 This shall not be submitted
    value = -1 I would prefer this is not submitted as is
    value = 0 No score
    value = +1 Looks good to me, but someone else must approve
    value = +2 Looks good to me, approved
    copyCondition = changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN
[label "Verified"]
    function = NoBlock
    value = -1 Fails
    value = 0 No score
    value = +1 Verified
    defaultValue = 0
    copyCondition = changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE
[submit-requirement "Verified"]
    submittableIf = label:Verified=MAX
    canOverrideInChildProjects = true
[submit-requirement "Code-Review"]
    submittableIf =  label:Code-Review=MAX,count>1 -label:Code-Review=MIN
    canOverrideInChildProjects = true                                            

This seems to work well when I am reviewing the change. CR label condition is not satisfied.
cr-conditions.png
However when looking up the change in the main Gerrit dashboard:
dashboard-conditions.png
Both "Status" and "CR" columns present status other than I'd expect. I assumed this would show up as "1 missing" for Status and "Unsatisfied" for CR.

Am I missing something in my configuration or is this a bug?

Thanks!

Ben Rohlfs

unread,
Feb 10, 2023, 3:43:32 AM2/10/23
to Karol Latecki, Repo and Gerrit Discussion
That looks like a bug.
The dashboard is based on the search index, so there can be a mismatch between dashboard and change page, if something went wrong during indexing.
What happens, if you force the change to be re-indexed, for example by leaving a resolved comment?


--
--
To unsubscribe, email repo-discuss...@googlegroups.com
More info at http://groups.google.com/group/repo-discuss?hl=en

---
You received this message because you are subscribed to the Google Groups "Repo and Gerrit Discussion" group.
To unsubscribe from this group and stop receiving emails from it, send an email to repo-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/repo-discuss/0f0613c1-8eec-4663-a17d-3cd2d8f60cd0n%40googlegroups.com.

Karol Latecki

unread,
Feb 12, 2023, 6:26:43 AM2/12/23
to Repo and Gerrit Discussion
Doing some actions like adding a comment and/or changing CR vote to 0 and then back to +2 resulted in dashboard status getting updated.
It now properly shows "1 missing" condition and CR column says "+2" instead of satisfied.
dashboard-conditions.png

Karol Latecki

unread,
Feb 16, 2023, 8:44:23 AM2/16/23
to Repo and Gerrit Discussion
Should I report this separately in "Issue tracker" or is it enough to just keep track of this here?
Reply all
Reply to author
Forward
0 new messages