loop inside savecontent

[ADK]

In cfscript I am trying to loop over a query inside of a savecontent block (basically generating an HTML table inside of a cfc method for output).

In the tag based version of cfsavecontent this works easily with either a cfoutput query or a cfloop query, however for the life of me I cannot get anything but the last query row to output inside the savecontent block? I've tried various versions of nested cfoutput's and writeoutput's etc. but cannot seem to come up with the right combination to make this work (or perhaps it's impossible with cfscript?)

[Igal @ getRailo.org]

should be something like:

savecontent variable="output" {

  loop query=someQuery {

    echo(someQuery.column1);
  }
}

echo(output);

On 9/22/2014 2:34 PM, ADK wrote:

In cfscript I am trying to loop over a query inside of a savecontent block (basically generating an HTML table inside of a cfc method for output).

In the tag based version of cfsavecontent this works easily with either a cfoutput query or a cfloop query, however for the life of me I cannot get anything but the last query row to output inside the savecontent block? I've tried various versions of nested cfoutput's and writeoutput's etc. but cannot seem to come up with the right combination to make this work (or perhaps it's impossible with cfscript?)

--
Did you find this reply useful? Help the Railo community and add it to the Railo Server wiki at https://github.com/getrailo/railo/wiki
---
You received this message because you are subscribed to the Google Groups "Railo" group.
To view this discussion on the web visit https://groups.google.com/d/msgid/railo/cdc6c47f-dcee-4405-a9b4-a97182d8453f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

-- 
Igal Sapir
Railo Core Developer
http://getRailo.org/

[ADK]

Thanks Igal - that's how I have it. That works if just the query. However I am trying to generate a table, so inside my loop would require tr's and the query column values outputted inside td's. THis is where it's breaking down.

[Mark Drew]

Post your code or gtfo. 

Mark Drew

To view this discussion on the web visit https://groups.google.com/d/msgid/railo/fb564cdc-c318-4aab-a036-c7c9525f09d1%40googlegroups.com.

[ADK]

savecontent variable="table" {
    echo('
    <table class="table table-striped table-super-condensed">
        <thead>
            <tr>
                <th>Date</th>
                <th>PO Number</th>
                <th>Ship Method</th>
                <th>Terms</th>
                <th>Buyer</th>
                <th class="text-right">Total</th>
                <th class="text-right">Status</th>
            </tr>
        </thead>
        <tbody>
        loop query="qPOs" {
            echo(
            <tr>
                <td>#DateFormat(qPOs.EnteredOn,"yyyy-mm-dd")#</td>
                <td>#qPOs.PONO#</td>
                <td>#qPOs.ShipMethod#</td>
                <td>#qPOs.Terms#</td>
                <td>#qPOs.EnteredBy#</td>
                <td>#DollarFormat(qPOs.Total)#</td>
                <td>#qPOs.isClosed#</td>
            </tr>
        )}
        </tbody>
    </table>           
    ');

[Igal @ getRailo.org]

you can call echo() inside a loop, but you can not do a loop inside echo().

To view this discussion on the web visit https://groups.google.com/d/msgid/railo/7c093e08-f12f-4500-b6b6-a1979573f57d%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[ADK]

Thanks Igal. So is there a way in cfscript to achieve this tag based solution:

<cfsavecontent variable="table">

<table class="table table-striped table-super-condensed">
    <thead>
        <tr>
            <th>Date</th>
            <th>PO Number</th>
            <th>Ship Method</th>
            <th>Terms</th>
            <th>Buyer</th>
            <th class="text-right">Total</th>
            <th class="text-right">Status</th>
        </tr>
    </thead>
    <tbody>

    <cfoutput>
    <cfloop query="qPOs">

        <tr>
            <td>#DateFormat(qPOs.EnteredOn,"yyyy-mm-dd")#</td>
            <td>#qPOs.PONO#</td>
            <td>#qPOs.ShipMethod#</td>
            <td>#qPOs.Terms#</td>
            <td>#qPOs.EnteredBy#</td>
            <td>#DollarFormat(qPOs.Total)#</td>
            <td>#qPOs.isClosed#</td>
        </tr>

    </cfloop>
    </cfoutput>
    </tbody>
</table>
</cfsavecontent>

[Igal @ getRailo.org]

yes, split your echo() calls

savecontent variable="table" {
    echo('
    <table class="table table-striped table-super-condensed">
        <thead>
            <tr>
                <th>Date</th>
                <th>PO Number</th>
                <th>Ship Method</th>
                <th>Terms</th>
                <th>Buyer</th>
                <th class="text-right">Total</th>
                <th class="text-right">Status</th>
            </tr>
        </thead>
        <tbody>

    ');    // close echo() call

        loop query="qPOs" {
            echo(
            <tr>
                <td>#DateFormat(qPOs.

EnteredOn,"yyyy-mm-dd")#</td>
                <td>#qPOs.PONO#</td>
                <td>#qPOs.ShipMethod#</td>
                <td>#qPOs.Terms#</td>
                <td>#qPOs.EnteredBy#</td>
                <td>#DollarFormat(qPOs.Total)#</td>
                <td>#qPOs.isClosed#</td>
            </tr>

        );    // close echo() call
        }    // close loop

    echo('
        </tbody>
    </table>           
    ');
}

To view this discussion on the web visit https://groups.google.com/d/msgid/railo/4d7eac55-81ce-4b13-b2fc-48e19c98ae5b%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[ADK]

Thanks Igal - that was it. Well almost: the contents of the echo inside the loop need to be surrounded in single quotes too, but then it works.

[Adam Cameron]

On Monday, 22 September 2014 23:08:18 UTC+1, ADK wrote:

Thanks Igal. So is there a way in cfscript to achieve this tag based solution:

Why are you trying to reimplement code that is an absolute sitter for being tags, in CFScript?

-- 

Adam 

[ADK]

short answer: it's a method in a script-based cfc that renders data in various formats based on certain logic. Of course, this specific situation could be pulled out to a view cfm page, but this turned into an exercise in "why does this work so simply in tags, but such a PITA in script?" etc.

I suppose I'll chalk this up to another situation like cfquery that just works better as a tag...

[Adam Cameron]

On Tuesday, 23 September 2014 08:22:01 UTC+1, ADK wrote:

short answer: it's a method in a script-based cfc that renders data in various formats based on certain logic. Of course, this specific situation could be pulled out to a view cfm page, but this turned into an exercise in "why does this work so simply in tags, but such a PITA in script?" etc.

Because tag-centric code kinda will work better than trying to use script to achieve the same thing. Apples/oranges.

That said, in your case it was more than you just did it wrong than it being particularly "worse". You just needed your CFML constructs outside your string. Once you've done that, the code isn't that different form the tag version.

But it would still be better than being left as tags (and included- / called-into your script-based CFC). Your situation is demonstrating the code probably wasn't that well organised to start with, I'm afraid.

 

I suppose I'll chalk this up to another situation like cfquery that just works better as a tag...

Yup. Tags are great in their place. It's just "their place" is nowhere near as ubiquitous as CFML devs seem to think it is.

-- 

Adam