minor ChezScheme build error, bad option to git

34 views
Skip to first unread message

John Clements

unread,
Jul 15, 2019, 7:48:44 AM7/15/19
to Racket Developers, Matthew Flatt
This may be unimportant, but there’s an error during the remote builds of all of the Chez Scheme configurations, to wit:

error: unknown option `exclude=*'
usage: git describe [options] <commit-ish>*
or: git describe [options] --dirty

--contains find the tag that comes after the commit
--debug debug search strategy on stderr
--all use any ref
--tags use any tag, even unannotated
--long always use long format
--first-parent only follow first parent
--abbrev[=<n>] use <n> digits to display SHA-1s
--exact-match only output exact matches
--candidates <n> consider <n> most recent tags (default: 10)
--match <pattern> only consider tags matching <pattern>
--always show abbreviated commit object as fallback
--dirty[=<mark>] append <mark> on dirty working tree (default: "-dirty")


This doesn’t seem to affect the remainder of the build. I did a quick git grep for this text, and it looks like the problem is in the ChezScheme repository, in the file `s/update-revision` which is short:

#!/bin/sh
if [ -d ../../.git ]; then
git describe --always --exclude='*' --abbrev=40 --dirty
echo 'git'
elif [ -d ../../.hg ]; then
DIRTY="$(hg status -n --color never --pager never | head -1)"
hg log --limit 1 --template '{node}' --pager never
if [ -n "${DIRTY}" ]; then
echo '-dirty'
else
echo ''
fi
echo 'hg'
elif [ -f ../../.hg_archival.txt ]; then
# hg archive and hgweb embed this file by default (see .hgrc archivemeta)
sed -n 's/^node: \(.*\)/\1/p' < ../../.hg_archival.txt
echo 'hg'
else
# use export-subst git attribute to populate revision for git archive
echo '$Format:%H$'
echo ‘git’

fi

It appears that the “—exclude” option to git describe is present in version 2.22, but not in the version 1.7 that’s present on the build machines.

It looks to me like this file might be used to generate text for a human-readable revision file. Presumably this error means that that revision file doesn’t actually contain the information that it’s supposed to contain, so it might be worth fixing?

Should I just file an issue against Chez, or can we just ignore this?

John

Matthew Flatt

unread,
Jul 15, 2019, 8:11:16 AM7/15/19
to John Clements, Racket Developers
Probably `--exclude=*` can be changed to `--match='[]'`, which includes
all tags that match nothing instead of excluding all tags that match
anything.

I made that change at some point, but probably discarded it because the
output didn't affect anything relevant for the Racket on Chez Scheme
build.
Reply all
Reply to author
Forward
0 new messages