Default 'revisions_to_keep'

38 views
Skip to first unread message

donoban

unread,
May 19, 2018, 3:27:59 PM5/19/18
to qubes-users
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

I tough 'revisions_to_keep' was default to 3. I created a new pool
yesterday and specify 3 when creating it, but then a VM that I moved
to there had 1. (I discovered it after trying to restore config
because it doesn't boot fine).

Then I started to look at all other VM's and all private volumes have
1 'revisions_to_keep', also they had 'save_on_stop'. So I think this
is not very useful, when you halt the vm your are overwriting the only
snapshot you have.

Does delay 'save_on_start' too much?

Maybe this is due I started with some RC and then upgraded to
current-testing.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEznLCgPSfWTT+LPrmFBMQ2OPtCKUFAlsAerYACgkQFBMQ2OPt
CKVDYw/+JYfgZ9hXWuU0mG1kX0RabQlxP6/hzh/SJM1437RSWkt1pX8Xo72hFg+f
SGs/F723668ZP2Q4ihzwiZ8MAznyfYr4LWWhP+uSSs6nFFEv2UfDCXJSAmXFQq8U
7sWOhC+uv+kGR1Tz8hJ7X9gtJDkF5hiCdO9JJQ5IrUaW2YM2bLJRUaWwSprem7Yu
nXHOem0UNHM+KGs0uWHH2QuF3d63IIzYq4gIbQd06Q/YWp4VVOyFc1N//uGY8fOJ
KRiLKC2QVYxjI39QyHLr7N4wAV85/hUQdC0NSj93q6opAIc+Bu+g0MC0JNepc27l
huXXoDhnx/jrJD/LFyu1f8v1qlSLugZGpp+zpygFpE78yswKaPmW+bK3wmlcCl/N
vngsFnsX+sS7KI/x6NUHemcHyjDt0T1Ow3jM0mGBseygSYFIiGaQ62Ne7RTFEVlV
nJn/WAyVGYOxcghnAuc3ieOCSdh4BaA+yr0+EFKydxnEna0nJx6Oeg8RgRKokN3J
HPMyk+ikS/I1x09k8J4TyI5/h+qShX/Wiv7Doh1v36MlA5YcFMb229j9ukn65Zwb
nEhn8PvPZ+yoobZP5ScJOrQXb0vGN9eNBlInlTM/bdGImPwNHUPqEJ2DgLfUsGfR
/Q0VrcrgmJUKCcmOxT66I2F1HAM7XDjaCk8HkZgcyOYv2nMX/1Q=
=O/l8
-----END PGP SIGNATURE-----

Marek Marczykowski-Górecki

unread,
May 19, 2018, 9:58:25 PM5/19/18
to donoban, qubes-users
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Sat, May 19, 2018 at 09:27:53PM +0200, donoban wrote:
> Hi,
>
> I tough 'revisions_to_keep' was default to 3. I created a new pool
> yesterday and specify 3 when creating it, but then a VM that I moved
> to there had 1. (I discovered it after trying to restore config
> because it doesn't boot fine).
>
> Then I started to look at all other VM's and all private volumes have
> 1 'revisions_to_keep', also they had 'save_on_stop'. So I think this
> is not very useful, when you halt the vm your are overwriting the only
> snapshot you have.

Actually, revisions_to_keep is about previous revisions. So "1" means
you have one snapshot you can revert to (the state before you've started
the VM).

> Does delay 'save_on_start' too much?
>
> Maybe this is due I started with some RC and then upgraded to
> current-testing.

Probably, there was a bug about saving revisions_to_keep. Anyway,
default value is 1.

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlsA1joACgkQ24/THMrX
1yxqOAf9FW/v7Pe1/jDiVI3QhKWRAn0CPWVlQ8upuIOXga0fnl6mXUVaFXYuT7Go
zYj6ktsZ6hm47ZI3EcRLoOTbCeSOg6gBF3C+IBGaF0vlJOOH5BADgU4AphL/ld05
Cn+b+MHYUwFYfy6Mo+h7cRoVJnAW6ZS/yrUSufZyvr3qZxIAZSUNYx9EHbV10yJk
JtVr96n73Uq//uSPzeNMhCL8gfLwRXvLok7N9a8FsprogG2Z+bxZL+VrZZhMAzFy
fpYIZCblqT3/2IDI/C29mOYhYrblKTiNKVg7y1picrsiBkJrSkPqAmNIeRRYTW7g
Qdm+CsG87li5/+c42p1uT1HeUiZpBQ==
=IgD3
-----END PGP SIGNATURE-----

donoban

unread,
May 20, 2018, 5:28:03 AM5/20/18
to qubes-users
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/20/18 03:58, Marek Marczykowski-Górecki wrote:
> Actually, revisions_to_keep is about previous revisions. So "1"
> means you have one snapshot you can revert to (the state before
> you've started the VM).
>

But was (and will be) this snapshot saved when you shutdown the VM?

Imagine you accidentally delete an important file, how can you use the
snapshot for recover it? Doing revert with the VM running? If you
shutdown the VM the snapshot with the important file will be lost.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEznLCgPSfWTT+LPrmFBMQ2OPtCKUFAlsBP5kACgkQFBMQ2OPt
CKW94A/9FZiSXPyXJyLLxz28NwoQ7YL4EpKFJqzDfQ630uqzq1YyFytn3cgsiEBR
ZyUY//1KwWqsH4NkCzCT7hEv6lg5FDRyBDErzdsGleKBQ/scrN9XP852ff3uFoDp
noLekYo8f8+aJbeY06M42PGJj/xYh2GNc16e1I4douvbK+R+QVl6gYowBjB+V4aL
+ZGobJrCtQ3/MXNIw18Ggi/Cpznuva2YhepUPd0OouD+S8th10AbweZ97YaLrkIO
hn8h88IT7ggtpF+CB7TpyLrr7gC8A3MluvcRXQLPW2dhTmIMzuJDeVlhDL0bREw0
2+CroALSLm0D03yZH+6PdzHykbA2Or+PqoUoFpQCtkATM3TtuQZ+NH+uCTr1SJDa
JZfRdA91V1glxDlI0rWjo78qV4thQLWAES/okK+BEIFzk+JQGd70DHKQXtKEkNM/
B9O86wHwu5bCx1WPlY9j3s6sf85TMzc8e6aK2Q0gaJRBLF62qr2JisIiodCH0Ui4
T9s7JXu6tOlpd8kyCNJnINAPZtuw26y2AYAuuuiqFEvnONVNqfsb5dg3NKvI3YzL
KKw4IwsrmFF1zPq7xEyQ//UjPs1ob0FCCO3Z7BpO53X2bPNlVthEWwyyvvaUKXSB
zuLmlDZjZrWAekhjRcg88dyg+oMyLBcR/ovoW3O6gNTnNLdchQA=
=Q8CA
-----END PGP SIGNATURE-----

awokd

unread,
May 20, 2018, 11:42:02 AM5/20/18
to donoban, qubes-users
On Sun, May 20, 2018 9:27 am, donoban wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> On 05/20/18 03:58, Marek Marczykowski-Górecki wrote:
>> Actually, revisions_to_keep is about previous revisions. So "1"
>> means you have one snapshot you can revert to (the state before
>> you've started the VM).
>>
>
> But was (and will be) this snapshot saved when you shutdown the VM?
>
> Imagine you accidentally delete an important file, how can you use the
> snapshot for recover it? Doing revert with the VM running? If you
> shutdown the VM the snapshot with the important file will be lost.

I think it replaces the snapshot with a new one at VM start, not shutdown.
So if you delete a file, shutdown the VM, then revert immediately, you'll
be OK.


donoban

unread,
May 20, 2018, 6:59:09 PM5/20/18
to qubes-users
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/20/18 17:41, awokd wrote:> I think it replaces the snapshot with
a new one at VM start, not shutdown.
> So if you delete a file, shutdown the VM, then revert immediately,
> you'll be OK.

Oh yes! I've tested and worked fine.
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEznLCgPSfWTT+LPrmFBMQ2OPtCKUFAlsB/bMACgkQFBMQ2OPt
CKWq/g/9G2cD4XXF7yqk8UDx7fyOYcg3sOYFwn/eLSmRJHwbOoIEGLq6dfEG3Q8L
v7q68ms5YEPgBg1N48yaZASzmju77MyxH0uKAk5UvVrhvSg+Dhu3nNcw1doiX+2K
vKIja+N7AgjpoV1KINwyRarGuDflDsKv3VtfQu552HSFUqSkOGpgTLpnWCGNRdte
GAnDSNH7ZWVU7hY0IqbXQmdXpH1POtT3AUptvlNzG9W65Tj0hbyBesmkQnUcQ4LI
IGCK54vnEQSWlXpV3Rlj2U1/elv+B4dbp63xWn8uCDe6cIkXaorEIeWNI2x+tdb1
UWq7mNxiqEheobocHzDYIEv2+xj/BI58x4veCaqxKSCTtOxajoyOieDhjPtoMewW
mJJ9CwxmYQzq+xdhtd4nmglRRitdKdwRMp75+OfUT2hV/wtmuggRdk9uIOJ1m+Kz
9vAcbbkgkoeD/RWc56dfLcvZlI7ep4QwTasKYihj2WpkwPtiZIJ6vkQG65HczDhO
+cqBQEX6hmosY9UQx4Yufr4raXFncNbKggOlqt/VVdtnT3c8fcr5FEhbbs/B7ifL
IEm+ixaphZ+kefzI9yimQi08ddDEbO38x0/T3fie0EzKnR5Xs3GhmMHNgj+2H6B7
jK8sYtyIxoYXJiaDWUOLcU7JBVp8cUgbNFEVNaAltpdikKIsidc=
=p84L
-----END PGP SIGNATURE-----
Reply all
Reply to author
Forward
0 new messages