qubes-builder-fedora name

[Marek Marczykowski-Górecki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi all,

Recently Frédéric Pierret implemented proper src.rpm building support,
required for reproducible builds, Fedora 27 and more (thanks!).
The main code lives in qubes-builder-fedora repository. But we also have
qubes-builder-centos (incidentally, also initially implemented by
Frédéric!), which does something very similar - builds rpm packages and
then compose template from them. We've come to conclusion it would make
sense to merge those repositories to reduce code duplication (otherwise
it would be needed to copy all src.rpm handling code into
qubes-builder-centos too). But then, the name qubes-builder-fedora is
less accurate, because it handle both Fedora and CentOS now...

Now we have multiple options:

1. Do nothing - leave qubes-builder-fedora name for building both Fedora
and CentOS. This option definitely is the easiest one (renaming
repository means all qubes-builder users needs to update builder.conf).

2. Rename to qubes-builder-redhat - as both Fedora and CentOS are
(almost) directly developed by RedHat.

3. Rename to qubes-builder-yum - as both distributions use yum (or its
newer version dnf).

4. Rename to qubes-builder-rpm - right now this is the only builder
plugin targeting rpm packages. But is is unclear to me how similar would
be handling other rpm-based distributions (if any), not directly related
to Fedora or CentOS (OpenSUSE for example).


My favorite option right now is number 2. Any other opinions?

Relevant pull request is here:
https://github.com/QubesOS/qubes-builder-fedora/pull/23

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlrMsygACgkQ24/THMrX
1yzn8wf+KiJPglzFHc7hkkWOaPD9INbQTQ3FvLf5i/TrN2/OHWQoIotaLzr4RHI7
K3nhZuLHZ71vSYanS/xNfz2MNIcWhpzpIeRLRcj3JTookGEYnDZ6kd48Kb6WHbIV
CCm+1R/NiwDy9+4jZ2wOJcnvN1GFcINLwGPF7lD1Bt7Q9lIwmzjD936e+b/Q2hAM
BuCDNo8WCn9MRKc6BggSBFGepkc0nY9g/kZcS76S/B3XOtrIwemHsbe7r/EiYhGQ
gdRBxDCZDs3uF/TCZpJRWt/d6KOAG0gkF/Thdyhyb4+Wa5TQnVvPBIvuF1I+rQIw
Ef+Qvl4yF5co3vknSfJuEd/37VTMwQ==
=lIJl
-----END PGP SIGNATURE-----

[Konstantin Ryabitsev]

On 04/12/18 14:09, Marek Marczykowski-Górecki wrote:
> 2. Rename to qubes-builder-redhat - as both Fedora and CentOS are
> (almost) directly developed by RedHat.

You probably don't want to do that because "redhat" is a trademark. At
least do -rh or -rhrpm.

--
Konstantin Ryabitsev
Director, IT Infrastructure Security
The Linux Foundation

[Marek Marczykowski-Górecki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Thu, Apr 12, 2018 at 02:22:51PM -0400, Konstantin Ryabitsev wrote:
> On 04/12/18 14:09, Marek Marczykowski-Górecki wrote:
> > 2. Rename to qubes-builder-redhat - as both Fedora and CentOS are
> > (almost) directly developed by RedHat.
>
> You probably don't want to do that because "redhat" is a trademark. At
> least do -rh or -rhrpm.

Good point, that indeed makes more sense.

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlrMti0ACgkQ24/THMrX
1yzptQf+Js1wEKDbPKrLbdPrgqAB4qFmiztQUA/LUdNTN1bSiAhnsXeXNJ35wds3
GoCFC8jIBUzozaV5D2tfl/L6Ummw1zQ7RhRQaLbEurp1sycv0epFXxBa4KGVdlDG
SGGgsEfbKiSjch8d0rzD4eeA3offtgcJpDuoUkHqktnZkPTAjjY6Z+SRjbx2wolb
NzY41auxd3CK+JRu+pPbXFZSp8CK3g6L42op5cibhEf3/hdGSrcg6AmoGepk3BFM
MGzrIyiqsQOK9eIMJGDyZVeTYmj04K/x9KW3x6RWMJLUsg++deWhOEAVvOWV3sP7
sLwvHhBHyZAzXbj/hxRybuuE+XorMQ==
=qC5V
-----END PGP SIGNATURE-----

[Frédéric Pierret (fepitre)]

Hi,

I would prefer option 3 to avoid any 'RedHat' related naming.

I would also vote for option 4, if we consider in a 'near' future to handle other RPM related distro like OpenSuse(yast) or Mageia(urpmi). Of course some work will be necessary in "builder-fedora" but it is feasible.

So it is up to the global opinion :)

Best,
Frédéric

[Marek Marczykowski-Górecki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Thu, Apr 12, 2018 at 09:48:33PM +0200, Frédéric Pierret (fepitre) wrote:
> Hi,
>
> I would prefer option 3 to avoid any 'RedHat' related naming.
>
> I would also vote for option 4, if we consider in a 'near' future to
> handle other RPM related distro like OpenSuse(yast) or Mageia(urpmi). Of
> course some work will be necessary in "builder-fedora" but it is feasible.

It isn't clear to me how much distros using rpm but other package
managers would benefit from builder-fedora plugin. .spec.in processing
script probably will be the common part, but for example
prepare-chroot-* scripts might be totally different.
On the other hand, it will be probably easy to add yet another script
there. In the worst case, where 'generate-spec' would be the only common
part, we can probably attach builder-rpm as a submodule to
builder-other-rpm-distro and still avoid duplicating this part. But I
hope we will not need to use this method.

Anyway, I'm more and more convinced that qubes-builder-rpm is a better
choice.

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAlrN0DwACgkQ24/THMrX
1yy5agf/fmg9zfmmicImUrLWW8AlttmySUa2Eh3DUcSFM5WNkDoRteIoGK6WgMcZ
6TAgvZifGnezfTD7CCJrQXHQ5RTDlJsBFGuVQcEqDBCwBTd+csiSaBhEP0cK4UIZ
c+dhujYv6/4QRTZj4rAR7nyOrClgN9F0oyZyL3MXxN5QFCTvAfTUzAlUaoFV/uPY
kycwBm4wWD0Af1ezekG6VBZVMzQkBtFYJca7JCRE1bcMVMAB6yXmBfqGs7B5bqND
+EfbLQkR/tOtpRfLDLM3/QLVowUJSO5qByqJtYcP5Jx7hpAELWLQrON4uu2HK/1h
rlQcjdgm5hhaUwzXYthdKsY38kk3zw==
=UjIx
-----END PGP SIGNATURE-----