[PATCH] core-admin: qubes-hcl-report: add check for HAP/SLAT

[HW42]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

see attached patch
-----BEGIN PGP SIGNATURE-----

iQIsBAEBCgAWBQJXxhmtDxxodzQyQGlwc3Vtai5kZQAKCRDkrMknimRoFnuZEACn
1xxi5yO1g8VQYHzYAArRXfZ4NOLYTCLHKqlHuzZ2pUlreMARTarkiFuzz+QFv4TV
2SMpMdSSs+abDu6RAOqiN1FdyU7wz+ZlXmrL/FfMJUG27nxqrvOaZk3FM3MN9xcm
vKSY8TVJOVETTuEYV1FhKOG52lFjPNYj82pcpLXFkFpJtwk7bSiCa73QjW8ZKDVY
Zz8Cx89iURYvkNQ+GfSXGI5/Zlr24eSqIQ4pwkF9xraOskP4A/Lwop4l6BWD4A7k
sbxcpjR/bzS+f1cKdNrYYb3s68O3kNvvxvbhqzkakGvE0IVz2FIyUXG5ukTzoZmH
UIIxBA0y/OPmER7ce++FH0aemwMF7TTftCsVxNuISnR/cUR452jLWyC8Cup6wF0c
PbdwEJdXZTBcak07Swx69Eq95G5IXUAQCIqzEW8JOBA1yorNO5PI+8AcGMwquCoC
MQQTqWdMlYw44mmc+N4TOLlLuoBrn2PDgIpu44GUITJdnDHAuRD8NFFO1Ca+7I8p
I6bZZI/mlKkOqNzgybamIsJmIMI1KKl3OTZ364VmA/IzhLM+EroS8fqKTKFzwxxZ
Ylkus8vNIXxWZQDs8viteW6ZaVF9iPkSKcGf49CJJXcR3LiS4wVJ3sN2spOPSXII
I2Yi8CkRi5vLlZ0a2PJFegP8dh6qiWa+RLtfYmaahg==
=uPI/
-----END PGP SIGNATURE-----

[Marek Marczykowski-Górecki]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Applied, thanks!

There is (minor?) problem there - `xl dmesg` buffer size. After long
system uptime, startup messages will no longer be there, especially
after multiple sleep/resume cycles. This check is the only one affected,
as it is the only one using `xl dmesg` output.
Some solution would be to store `xl dmesg` output somewhere just after
system startup. In fact it is logged in
/var/log/xen/console/hypervisor.log, but that file is also rotated.

Anyway, it shouldn't be a big problem for qubes-hcl-report tool. And
some workaround would be a check for early startup message in `xl dmesg`
output, like "Xen version". And issue a warning if not found (suggesting
retrying after reboot).

PS Nice trick with ${HAP^} substitution. Since the script has
#!/bin/bash it's ok, but please remember to not use such bash-specific
tricks in #!/bin/sh scripts.

- --
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXx4uuAAoJENuP0xzK19csl34H/2cAGtthkLEc+ZzFdgX/xy9T
3l6l9bR1L08Mkt+sQjgth/gogE7v4SGFDLcGaCLYEBti1Dg1jI2oppqcPiSwJV7n
m4+pJm49t6luQTBH/VqADvmXsybQ89fy7vOHAiN+QHycv5hgmd3HzH4AWmIPI9l2
hTTgWtiYixRJuqO6mJrDsKMQHgDIlEuImC8RsefIfObRdZqOQqr5y/VVXAAgVsj0
MZ6BxpCnOZG26Azk5xLhxYLh9KROn7RGtOFZasrSc5XxLurJYXqt+bpw/ZeegQ9V
1xknJcAx5/+IeVtdKJ9DgI2vVifSfJG94dSNVxs8oMLhNBfcdBE0xhZ+bzJBS5I=
=HavV
-----END PGP SIGNATURE-----

[HW42]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Marek Marczykowski-Górecki:

> Applied, thanks!
>
> There is (minor?) problem there - `xl dmesg` buffer size. After long
> system uptime, startup messages will no longer be there, especially
> after multiple sleep/resume cycles. This check is the only one affected,
> as it is the only one using `xl dmesg` output.
> Some solution would be to store `xl dmesg` output somewhere just after
> system startup. In fact it is logged in
> /var/log/xen/console/hypervisor.log, but that file is also rotated.
>
> Anyway, it shouldn't be a big problem for qubes-hcl-report tool. And
> some workaround would be a check for early startup message in `xl dmesg`
> output, like "Xen version". And issue a warning if not found (suggesting
> retrying after reboot).

That's indeed a subtly bug. Attached patch checks for the "Xen version"
line in "xl dmesg" and warns otherwise.

While at it I also improved the log parsing.

> PS Nice trick with ${HAP^} substitution. Since the script has
> #!/bin/bash it's ok, but please remember to not use such bash-specific
> tricks in #!/bin/sh scripts.

In this case I actually cheked that it's bash. But yes, once you are
used to the bash features one quickly forget to check.
-----BEGIN PGP SIGNATURE-----

iQIsBAEBCgAWBQJXyN+fDxxodzQyQGlwc3Vtai5kZQAKCRDkrMknimRoFvMtD/0a
UKeYUK+TdCu3MW1VMw1JOwrD09MbGC4O3xCQrfZw5RLpdOtUfyfkFzCa235r1V9q
R6+XP1s3NW75jubblnSS/kl1MJj+jkQvuiwciaDkDxf3BJKNqGyeJwjgxCqMjFmN
fsjL4c7lsFD7jEs7Zu2NsdaUKwE8pLf+WH4h8VO5xTPySULKiReSjd3NniEP6uj9
5jRv7NO4u3dXaxY0S7qpMzhlYUk9bESfIPFieaXjmkyTnkBvsRN1JbGSCuE8/JQr
VmG0ZINkv5RbXX+Z28suN4TqUy3cu+rQEfVktphwAf0WD5AamJ7rY0tFR7W+W9H7
ICZY6vRMBU9sm6I4Sca8H3e1nKon+1UtcqblSPNhzXQjma7Fa0k/MzOfoiwU26kt
5g16RI7cokcO99xUT76ffjdR5pPTfeH/bJgton3UrzAvUfUDgp987L6ZMEZXS+Sa
f1SbBx2HgPsDlcNWFh/UVmW6CYU/gwfkV635fg7T9GTuxgN0RxmzhMwiZfYKcd9g
H1l+Mu8a1FRyUA28erH0ah9eLdcORe0ZF9BHNSDd1JWXIqOx+kj+wk4t3bi4GFL+
7aaX23s5KTnouJkKGsvahXNCqbSbl0uTVpGCM2NcTj4whR0+0SNtU2C+RVe9Kekl
5ceO55KidSIDhZ3zu/TtWpdte8bqm2lmjZRdOE2TLw==
=/L+D
-----END PGP SIGNATURE-----