Update to Maven 3.8.1

[Falko]

Hi everyone,

Maven 3.8.1 was released for good this time (see also [1]) and people are starting to migrate.

We already have on issue [2] related to the new "blocked" element in settings.xml.

I went ahead and bumped everything I could find, including using mvnw consequently in GH actions [3].

Once I get CI green in my fork, I'm going to create a PR.

WDYT? Any objections?

I'm not sure whether this is too big for 1.13.1 but then again the changes are much smaller than the jump from 3.6.3 to 3.8.1 may suggest [4].

[1] https://maven.apache.org/docs/3.8.1/release-notes.html#why-does-this-version-have-the-value-3-8-1

[2] https://github.com/quarkusio/quarkus/issues/16233

[3] https://github.com/quarkusio/quarkus/compare/main...famod:mvn-3.8.1

[4] https://maven.apache.org/docs/3.8.1/release-notes.html#overview-about-the-changes

Cheers,

Falko

[George Gastaldi]

Given that the settings.xml changed, I think it is safer to have it in 1.14.x instead, but I'm fine if the team decides to put in 1.13.x 

--
You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/bc246f61-c531-45dc-85d5-9310323198f7n%40googlegroups.com.

[Falko]

A few more details on the updated maven-resolver and maven-wagon components (since I had to resolve some dependency convergence issues):

resolver changes (note: there is no 1.5 or 1.6.0)

- 1.6.1: https://issues.apache.org/jira/projects/MRESOLVER/versions/12348853

- 1.6.2: https://issues.apache.org/jira/projects/MRESOLVER/versions/12350000

wagon changes:

- 3.4.0: https://issues.apache.org/jira/projects/WAGON/versions/12346512

- 3.4.1: https://issues.apache.org/jira/projects/WAGON/versions/12348210

- 3.4.2: https://issues.apache.org/jira/projects/WAGON/versions/12348348

- 3.4.3: https://issues.apache.org/jira/projects/WAGON/versions/12349719

You may need to be logged in to view those releases.

[clement escoffier]

The changes you made look good to me. 

However, most users won't read the release notes, and so, be prepared to explain how to switch to https for all repositories. 

Also, we would need to update the maven wrapper version in the quickstarts too. 

Clement

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/e51eaa44-64ce-4241-9c0b-6d0b6984f24an%40googlegroups.com.

[Falko]

I created the respective PR: https://github.com/quarkusio/quarkus/pull/16249

> However, most users won't read the release notes, and so, be prepared to explain how to switch to https for all repositories.

You have a point there. But I guess people will just assume that Quarkus works with Maven 3.8.1 so there is no real way around it, AFAICS.

Cheers,

Falko

[George Gastaldi]

FWIW I tested your PR and it fixes the issue reported in https://github.com/quarkusio/quarkus/issues/16233

Good job!

[clement escoffier]

@George Gastaldi did you test on Maven 3.6 and Maven 3.8? I didn't (I don't have 3.8 yet).

Clement

To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/7d7d38d1-a03c-4bf3-a221-80dd4a480357n%40googlegroups.com.

[Max Rydahl Andersen]

you are just talking about which maven version are used to build quarkus, right?

users, quickstarts, s2i builds etc. we wouldn't want to force 3.8.

/max

--

You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/bc246f61-c531-45dc-85d5-9310323198f7n%40googlegroups.com.

/max
https://xam.dk/about

[George Gastaldi]

Yes, I installed and switched through both versions using SDKMan

[Falko]

Update: This was merged today, so main is on Maven 3.8.1 now, including CI (via mvnw).

I'll have a look at the quickstarts next.

PS: As of now, the PR is not marked for backporting.

Cheers,

Falko