Specifying Reviewers for PR's

[originalb...@gmail.com]

Hi.  I just posted my first PR for a bug fix.  And I'm wondering what the culture is for tagging reviewers and who, if anyone I should tag?  I've had some discussions with Josef on this bug and another, and so if this was a PR at work I would tag him.  And I'd like to learn more about the culture/best practice on this.  

Thanks for the help,

Amelia

[josef...@gmail.com]

On Mon, Feb 15, 2021 at 3:32 PM originalb...@gmail.com <originalb...@gmail.com> wrote:

Hi.  I just posted my first PR for a bug fix.  And I'm wondering what the culture is for tagging reviewers and who, if anyone I should tag?  I've had some discussions with Josef on this bug and another, and so if this was a PR at work I would tag him.  And I'd like to learn more about the culture/best practice on this.  

I usually don't use or look at tags. Usually it is obvious from the topic or part of statsmodels who the maintainer is for that.

If it is ambiguous in which area an issue belongs, then we can ping and tag. 

Josef

 

Thanks for the help,

Amelia

--
You received this message because you are subscribed to the Google Groups "pystatsmodels" group.
To unsubscribe from this group and stop receiving emails from it, send an email to pystatsmodel...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/pystatsmodels/cb67cae6-10f6-4822-b2ba-f69f2913a7cdn%40googlegroups.com.

[originalb...@gmail.com]

Good to know.  Thanks!  I'll just leave it as is, then.