Docker module and new upstream repos

58 views
Skip to first unread message

Gareth Rushgrove

unread,
Jul 26, 2015, 12:31:24 PM7/26/15
to puppe...@googlegroups.com
Hi All

Docker Inc have moved their official repos, and at the same time
expanded them so they're shipped packages for lots more distros. Oh,
also the name of the package has changed, from lxc-docker to
docker-engine.

http://blog.docker.com/2015/07/new-apt-and-yum-repos/#comment-247448

I'm looking at shipping a 5.0 release of the garethr/docker module to
add support for this, WIP in
https://github.com/garethr/garethr-docker/pull/311

And I had a few questions which I reasoned I'd ask here.

* Previously the module defaulted to upstream docker packages for
Ubuntu, and used distro packages for everything else (because they
didn't exist). I'm proposing to change this, so everything by default
uses the upstream. And to document how you can use your distro of
choices version. Any reason why that's not the best option?

* The change in repo and the change in package-name mean a certain
level of juggling. Remove the old repo, remove the old package, add
the new, etc. I'm not sure that's best dealt with by the module, I'm
not sure I'd want updating the module to (for instance) remove docker
and every running containers on all hosts. Open to ideas about how
best to signpost this change however.

Any thoughts much appreciated, especially if you're using the module in anger.

Cheers

Gareth

--
Gareth Rushgrove
@garethr

devopsweekly.com
morethanseven.net
garethrushgrove.com

Clayton O'Neill

unread,
Jul 26, 2015, 3:07:52 PM7/26/15
to Puppet Developers, gar...@morethanseven.net
I have a work in progress version of a similar change locally also.  Replies inline below:

On Sunday, July 26, 2015 at 12:31:24 PM UTC-4, Gareth Rushgrove wrote:
I'm looking at shipping a 5.0 release of the garethr/docker module to
add support for this, WIP in
https://github.com/garethr/garethr-docker/pull/311

And I had a few questions which I reasoned I'd ask here.

*  Previously the module defaulted to upstream docker packages for
Ubuntu, and used distro packages for everything else (because they
didn't exist). I'm proposing to change this, so everything by default
uses the upstream. And to document how you can use your distro of
choices version. Any reason why that's not the best option?

I think some people may not want that because they have internal mirrors (like we do), but it's easy to turn off the use of the public repos.
 
* The change in repo and the change in package-name mean a certain
level of juggling. Remove the old repo, remove the old package, add
the new, etc. I'm not sure that's best dealt with by the module, I'm
not sure I'd want updating the module to (for instance) remove docker
and every running containers on all hosts. Open to ideas about how
best to signpost this change however.

At least on Ubuntu, docker-engine conflicts with lxc-docker, so installing it automatically removes both the old generic name and the version named package. 

Joshua hoblitt

unread,
Jul 27, 2015, 8:04:21 PM7/27/15
to puppe...@googlegroups.com
On 07/26/2015 09:31 AM, Gareth Rushgrove wrote:
> * Previously the module defaulted to upstream docker packages for
> Ubuntu, and used distro packages for everything else (because they
> didn't exist). I'm proposing to change this, so everything by default
> uses the upstream. And to document how you can use your distro of
> choices version. Any reason why that's not the best option?

I think it should be consistent as possible between platforms of either
using upstream packages or distro provided. For fast moving software or
packages which the distro intentionally doesn't update (apache on
EL6...), upstream is usually what the user wants. In fairness, most of
the distros have been pretty agressively upgrading docker versions but I
expect that will slow down as interations with other vendored packages
start to accumulate.

-Josh

--

Pete Brown

unread,
Aug 12, 2015, 7:08:21 PM8/12/15
to puppe...@googlegroups.com
How is this progressing?

Do you need some help testing?
> --
> You received this message because you are subscribed to the Google Groups
> "Puppet Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to puppet-dev+...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/puppet-dev/55B6C6F6.9090509%40hoblitt.com.
>
> For more options, visit https://groups.google.com/d/optout.



--
--
Pete Brown
Director and Primary Infrastructure Developer
Abstract IT Pty Ltd.

LinkedIn: https://au.linkedin.com/in/rendhalver
GitHub: https://github.com/rendhalver

Gareth Rushgrove

unread,
Aug 14, 2015, 4:45:46 AM8/14/15
to puppe...@googlegroups.com
On 13 August 2015 at 00:08, Pete Brown <pe...@abstractit.com.au> wrote:
> How is this progressing?
>
> Do you need some help testing?
>

I've still a few things to finish off but you can try it out from:

https://github.com/garethr/garethr-docker/pull/311

I'm just finishing adding support for Debian as well, once that lands
I'll release a 5.0 version of the garethr/docker module - I'd hope in
a bit over a week.

Cheers

Gareth
> To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAM8R_x8ngBZv_fLVa%2B4f6M-KN0n%2B3SZKkegBrfdDDyrsk3k4bg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--

Pete Brown

unread,
Aug 16, 2015, 7:49:40 PM8/16/15
to puppe...@googlegroups.com
On 14 August 2015 at 18:45, Gareth Rushgrove <gar...@morethanseven.net> wrote:
> On 13 August 2015 at 00:08, Pete Brown <pe...@abstractit.com.au> wrote:
>> How is this progressing?
>>
>> Do you need some help testing?
>>
>
> I've still a few things to finish off but you can try it out from:
>
> https://github.com/garethr/garethr-docker/pull/311

I might give that a go when I get a chance.

> I'm just finishing adding support for Debian as well, once that lands
> I'll release a 5.0 version of the garethr/docker module - I'd hope in
> a bit over a week.

Awesome news. :)
> To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAFi_6y%2BEtW69HzDmiui5e2XMqarFEGGXvVT-NT3bDyMDENgjMg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages