Wednesday, December 11th Pull Request Triage
26 views
Skip to first unread message
Andy Parker
Dec 11, 2013, 11:46:17 AM12/11/13
to puppe...@googlegroups.com
We'll be starting at 9am Pacific time in a google hangout at https://plus.google.com/hangouts/_/7ecpi0d68u0q6bt86mlvs8ddqs?hl=en
--
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperJoin us at PuppetConf 2014, September 23-24 in San Francisco
Andy Parker
Dec 11, 2013, 1:37:49 PM12/11/13
to puppe...@googlegroups.com
We made it through a few of the newer pull requests.
2137: looks good, but we'd like to see if there is a better way of doing the feature check. Ethan checked and didn't come up with anything. Still needs tests.
2136: it changes behavior for existing users. That will need to be taken into account somehow.
2024: for this and 2136 we need to be really clear about the existing behavior that will be changed by these.
We need to review the mailing list thread on crontab and clarify what that behavior is if it isn't clear.
2135: references pup (the project in the jira system), not a big deal since we roll it out on monday
2134: has a typo that needs to be fixed. actually it turns out it isn't a typo. it is a reference to a parameter, but wasn't obvious to any of us.
2133: needs an issue associated with it and some tests to catch this (maybe, they wouldn't be that useful in this case).
2132: looks good. We just need to fix the whitespace merge it.
2130: much larger than we expected. We'd like to take a look at the changes in a bit more isolation. Adrien is going to reopen the discussion around build_ vs package_options.
2136: it changes behavior for existing users. That will need to be taken into account somehow.
2024: for this and 2136 we need to be really clear about the existing behavior that will be changed by these.
We need to review the mailing list thread on crontab and clarify what that behavior is if it isn't clear.
2135: references pup (the project in the jira system), not a big deal since we roll it out on monday
2134: has a typo that needs to be fixed. actually it turns out it isn't a typo. it is a reference to a parameter, but wasn't obvious to any of us.
2133: needs an issue associated with it and some tests to catch this (maybe, they wouldn't be that useful in this case).
2132: looks good. We just need to fix the whitespace merge it.
2130: much larger than we expected. We'd like to take a look at the changes in a bit more isolation. Adrien is going to reopen the discussion around build_ vs package_options.
Reply all
Reply to author
Forward
0 new messages