Puppet PR Triage Notes 2014-07-02
12 views
Skip to first unread message
Andy Parker
Jul 2, 2014, 2:22:39 PM7/2/14
to puppe...@googlegroups.com
Joined: Andy, JoshC, Adrien, Whopper, Ashley, Joachim
Candidates for merging:
* Puppet/2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
* Puppet/2779: (PUP-2802) add slot support for packages in portage.rb
* Puppet/2770: Allow version and held states of a package to specified as separate properties
* Hiera/198: Add YAML output format to CLI
New:
Hiera:
198: Add YAML output format to CLI
- Consensus is that the feature addition is good
- Adrien to do any fix ups and get it merged
204: (HI-277) Remove Sid/Unstable from build defaults
- Will to merge.
293: The hierarchy should dynamically grow if an interpolated variable contains an Array type of value
- The request is reasonable within the user's context. Rather than adding yet more choices into hiera itself, we'd like to see this fixed by making the hierarchy mechanism plug able.
- Adrien to comment and close
Facter:
712: Add structured uptime fact
- Needs a ticket
- "uptime_hash", not a great name "_hash", maybe "system_uptime"
702: (FACT-598) Use `hostname -f` for `fqdn` if available.
- This would cause a change to how facter issues the fqdn fact, which could change a lot of stuff
- The user admits that they are using non-standard hostname setups
- This would be better done as a custom fact.
714: (FACT-606) Remove Sid/Unstable from build defaults
- Merged by Whopper
715: (MAINT) Switch bare 'sysctl' call to use Facter::Util::POSIX.sysctl
- Follow up with Whopper. Maybe merge it into 712
716: (FACT-595) Unbreak {is_,}virtual fact for OpenBSD when running on KVM.
- Simple fix. Merged by Adrien
Puppet:
2832: (doc) Fix "mangement" typo
- Simple typo fix
- Andy merging
2831: (CPR-42) file conflict upgrading from 2.7.26 to 3.6.2
- Needs to reference a PUP ticket
2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories
- Already in discussion on puppet-dev
2741: Maint/puppet 4/document event manager
- Simple docs change. Henrik already commented on a bit
- Merged
Puppet:
2797: (PE-3758) Puppet should support HTTP proxy authentication
- Needs a PUP ticket
- Needs to sign the CLA
2779: (PUP-2802) add slot support for packages in portage.rb
- Adrien needs to take it an review it for correctness/more intensive review
- Commits need to be updated to contributing guidelines
2770: Allow version and held states of a package to specified as separate properties
- Pull in for more intensive analysis
- Commits need to be updated to contributing guidelines
- Backwards compat problems because of the new parameters.
- Adrien to summarize discussion
2614: (PUP-2452) Refresh support for Package type
- Looks reasonable.
- There is a question from the contributor about if there needs to be something changed to use this.
- The answer to the question is, "yes, having a use of this is ideal".
- Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.
- Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.
- This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.
- Adrien to write up the concerns in the PR and start a thread on puppet-dev to come to a decision about how to better control refresh events.
2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
- Some questions about windows, but Peter thinks it should be fine
2709 (PUP-2701): Add PMT build metadata.json tests
- Joshua Partlow to verify these on a few platforms before merging
- Found some failures on centos6; will update prs and then ask if Kurt can continue
Facter:
689 (FACT-547) Limit the output of prtdiag on Solaris
- Felix leaving a line note about the pathing for the 'head' command on the pipe
Hiera:
188: Allow for return of complex values across hiera
- This will end up changing the behavior of some current queries.
- Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no
- Adrien provided a great example of the unexpected consequences it could have.
- Back in the contributor's court for them to figure out if there is another design.
--
Candidates for merging:
* Puppet/2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
* Puppet/2779: (PUP-2802) add slot support for packages in portage.rb
* Puppet/2770: Allow version and held states of a package to specified as separate properties
* Hiera/198: Add YAML output format to CLI
New:
Hiera:
198: Add YAML output format to CLI
- Consensus is that the feature addition is good
- Adrien to do any fix ups and get it merged
204: (HI-277) Remove Sid/Unstable from build defaults
- Will to merge.
293: The hierarchy should dynamically grow if an interpolated variable contains an Array type of value
- The request is reasonable within the user's context. Rather than adding yet more choices into hiera itself, we'd like to see this fixed by making the hierarchy mechanism plug able.
- Adrien to comment and close
Facter:
712: Add structured uptime fact
- Needs a ticket
- "uptime_hash", not a great name "_hash", maybe "system_uptime"
702: (FACT-598) Use `hostname -f` for `fqdn` if available.
- This would cause a change to how facter issues the fqdn fact, which could change a lot of stuff
- The user admits that they are using non-standard hostname setups
- This would be better done as a custom fact.
714: (FACT-606) Remove Sid/Unstable from build defaults
- Merged by Whopper
715: (MAINT) Switch bare 'sysctl' call to use Facter::Util::POSIX.sysctl
- Follow up with Whopper. Maybe merge it into 712
716: (FACT-595) Unbreak {is_,}virtual fact for OpenBSD when running on KVM.
- Simple fix. Merged by Adrien
Puppet:
2832: (doc) Fix "mangement" typo
- Simple typo fix
- Andy merging
2831: (CPR-42) file conflict upgrading from 2.7.26 to 3.6.2
- Needs to reference a PUP ticket
2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories
- Already in discussion on puppet-dev
2741: Maint/puppet 4/document event manager
- Simple docs change. Henrik already commented on a bit
- Merged
Puppet:
2797: (PE-3758) Puppet should support HTTP proxy authentication
- Needs a PUP ticket
- Needs to sign the CLA
2779: (PUP-2802) add slot support for packages in portage.rb
- Adrien needs to take it an review it for correctness/more intensive review
- Commits need to be updated to contributing guidelines
2770: Allow version and held states of a package to specified as separate properties
- Pull in for more intensive analysis
- Commits need to be updated to contributing guidelines
- Backwards compat problems because of the new parameters.
- Adrien to summarize discussion
2614: (PUP-2452) Refresh support for Package type
- Looks reasonable.
- There is a question from the contributor about if there needs to be something changed to use this.
- The answer to the question is, "yes, having a use of this is ideal".
- Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.
- Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.
- This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.
- Adrien to write up the concerns in the PR and start a thread on puppet-dev to come to a decision about how to better control refresh events.
2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
- Some questions about windows, but Peter thinks it should be fine
2709 (PUP-2701): Add PMT build metadata.json tests
- Joshua Partlow to verify these on a few platforms before merging
- Found some failures on centos6; will update prs and then ask if Kurt can continue
Facter:
689 (FACT-547) Limit the output of prtdiag on Solaris
- Felix leaving a line note about the pathing for the 'head' command on the pipe
Hiera:
188: Allow for return of complex values across hiera
- This will end up changing the behavior of some current queries.
- Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no
- Adrien provided a great example of the unexpected consequences it could have.
- Back in the contributor's court for them to figure out if there is another design.
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperRegister by May 30th to take advantage of the Early Adopter discount —save $349!
Reply all
Reply to author
Forward
0 new messages