Notes from the January 8th, 2014 PR Triage

19 views
Skip to first unread message

Andy Parker

unread,
Jan 8, 2014, 3:00:16 PM1/8/14
to puppe...@googlegroups.com
I'd call this one a wild success. Had several non-PL people show up (Joshua Hoblitt, Jeremy Bouse, Pedro Corte-Real, and probably a few others that I'm just forgetting right now). We spent the entire time on puppet PRs trying to get through the backlog that had built up over the holidays.

Puppet:


2227/2226/2225/2034/2130: Lots of code. This change has had a long, drawn out history. We want the parameter/property, but don't want to bring in a whole slew of ports utility code and vash (a validated hash). There was a lot of discussion about the status of the FreeBSD/OpenBSD modules and providers. We are going to take the simple 2034 patch, and broach the topic of larger support for these other systems on puppet-dev.
     https://groups.google.com/forum/#!topic/puppet-bsd/g5DDPd3PL-U
     https://github.com/toddfries/OpenBSD-ports-patches/tree/master/sysutils/ruby-puppet
     http://svnweb.freebsd.org/ports/head/sysutils/puppet/

     Andy: send email to puppet-dev to start talking about maintaining, contributing and so on for
     JHobblit (^conner): respond with an initial draft of what might be tier 1 vs. tier 2 platforms.

2215: Looks ok, but the commit message was a little wonky. Henrik to fix and merge in.
2212: Sending to Haus
2206: no big deal, will pull it in when we work on 2201
2201: Henrik has a number of concerns. Ignoring anything that doesn't parse isn't going to work for the catalog compilation use case. Will write up thoughts and send to puppet-dev
2200: Good change to have, but we can't regress. Josh is going to chime in with some information about how to ignore exit statuses.
2198: Can't do it this way. The real problem is that exec pipe doesn't protect us from different locales. Finch to file ticket and comment on PR
2196: Sooo simple. Merged
2186: Looks ok, merging in.
2182: Simple, easy. Finch going to just do some tests and merge it in.
2170: Looks like a good feature. Just want to get the name of the parameter changed
2168: For the most part good. Just need to rework it to fit with our changes to Puppet::FileSystem and address any windows concerns. We'll pull it into our next iteration
2162: We'll just pull it in as is. We'd like to get more work in that area to make it more robust since we've regressed a couple times, but this at least fixes one issue for now.
2161: Pull in for a sprint soon. Josh wants to take a look at a few parts, but thinks that is mostly good.
2156: We'll just merge in if the specs pass
2142: merged
2137: Looks good. Some oddities but nothing out of the ordinary. Adrien merging it in.


--
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software Developer

Join us at PuppetConf 2014September 23-24 in San Francisco
Reply all
Reply to author
Forward
0 new messages