Puppet PR Triage Notes 2014-06-18
11 views
Skip to first unread message
Andy Parker
Jun 18, 2014, 2:49:56 PM6/18/14
to puppe...@googlegroups.com
Joined: Andy, Peter, Erik, Felix
Candidates for merging:
* Puppet/2624: (PUP-2511) Add parser function digest: uses digest_algorithm to hash, not strictly md5
* Puppet/2637: Make puppet master compile honor configured logdest
- Candidate, but we'd like to have the contributor fix it up first (saves us the time)
* Puppet/2753: (PUP-2737) purge sshkeys with spaces in the title
* Puppet/2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
* Facter/671: (FACT-476) Make the 'processor' fact for OpenBSD consistent with other systems
* Facter/691: (FACT-547) Limit the output of prtdiag on Solaris
- Needs a small fix to change "head" to "/usr/bin/head"
New:
2614: (PUP-2452) Refresh support for Package type
- Looks reasonable.
- There is a question from the contributor about if there needs to be something changed to use this.
- The answer to the question is, "yes, having a use of this is ideal".
2624: (PUP-2511) Add parser function digest: uses digest_algorithm to hash, not strictly md5
- Makes sense/Looks good
2634: yumrepo: _none_ is also a valid value for parameter proxy
- Don't have an issue (Should be tied to PUP-2271)
- Don't have a test
- Commit doesn't have a good explanation of the change
2637: Make puppet master compile honor configured logdest
- Needs a ticket associated with it
- Other than that looks good
2642: possible typo?
- Quite a discussion already
- Looks like Adrien might be doing something that doesn't require this change anymore.
- Closing because it is superseded by GH-2670
2753: (PUP-2737) purge sshkeys with spaces in the title
- Looks alright.
2754: (maint) spec: allow expectations of resources from compiled manifests
- Looks like a useful helper method, but need an example of use.
2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
- Some questions about windows, but Peter thinks it should be fine
Facter:
680:
- This is a breaking change because it will alter what fqdn is for existing systems
681: Fix/facter 2/home expansion bug
- Closing in favor up 691
653: Patch blockdevices to work around Kernel bug
- No activity for a long time.
- The bug doesn't contain any information about how the bug exhibits, what kernels it affects, or any information about the bug in kernel mailing lists.
670: Fix/facter 2/fix threading with lang env
- A lot of strange little things here
- The use of Kernel.system() isn't portable to ruby 1.8
- We don't support threaded environments
- Peter will close because of these problems.
671: (FACT-476) Make the 'processor' fact for OpenBSD consistent with other systems
- Looks good. Previous behavior has just always been that way, but providing more information is probably better.
Hiera:
188: Allow for return of complex values across hiera
- This will end up changing the behavior of some current queries.
- Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no
Held over:
Facter:
689 (FACT-547) Limit the output of prtdiag on Solaris
- Felix leaving a line note about the pathing for the 'head' command on the pipe
Puppet:
2709 (PUP-2701): Add PMT build metadata.json tests
- Joshua Partlow to verify these on a few platforms before merging
- Found some failures on centos6; will update prs and then ask if Kurt can continue
2716 (PUP-???): zypper should always be the default package provider for SUSE osfamily
- Needs a PUP-ticket
- Those present are not totally sure if zypper is the appropriate default and whether
or not this could break existing Puppet installs. Adrien is contacting colleague
at Attachmate / Novell?
- Rug was the previous default, but modern systems appear to be defaulting to zypper
- Adrien will retarget to puppet-4 (and update ticket reference) because we don't want to change default providers in a minor release
2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related to the forge
- The changes that were blocking this have landed. Kylo pinging pvande again.
- Need to ping pvande again to verify / merge
- Still no response, will wait another week
- Pieter responded on 6/5 with some comments but won't have time to review more deeply until after PE release
--
Candidates for merging:
* Puppet/2624: (PUP-2511) Add parser function digest: uses digest_algorithm to hash, not strictly md5
* Puppet/2637: Make puppet master compile honor configured logdest
- Candidate, but we'd like to have the contributor fix it up first (saves us the time)
* Puppet/2753: (PUP-2737) purge sshkeys with spaces in the title
* Puppet/2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
* Facter/671: (FACT-476) Make the 'processor' fact for OpenBSD consistent with other systems
* Facter/691: (FACT-547) Limit the output of prtdiag on Solaris
- Needs a small fix to change "head" to "/usr/bin/head"
New:
2614: (PUP-2452) Refresh support for Package type
- Looks reasonable.
- There is a question from the contributor about if there needs to be something changed to use this.
- The answer to the question is, "yes, having a use of this is ideal".
2624: (PUP-2511) Add parser function digest: uses digest_algorithm to hash, not strictly md5
- Makes sense/Looks good
2634: yumrepo: _none_ is also a valid value for parameter proxy
- Don't have an issue (Should be tied to PUP-2271)
- Don't have a test
- Commit doesn't have a good explanation of the change
2637: Make puppet master compile honor configured logdest
- Needs a ticket associated with it
- Other than that looks good
2642: possible typo?
- Quite a discussion already
- Looks like Adrien might be doing something that doesn't require this change anymore.
- Closing because it is superseded by GH-2670
2753: (PUP-2737) purge sshkeys with spaces in the title
- Looks alright.
2754: (maint) spec: allow expectations of resources from compiled manifests
- Looks like a useful helper method, but need an example of use.
2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
- Some questions about windows, but Peter thinks it should be fine
Facter:
680:
- This is a breaking change because it will alter what fqdn is for existing systems
681: Fix/facter 2/home expansion bug
- Closing in favor up 691
653: Patch blockdevices to work around Kernel bug
- No activity for a long time.
- The bug doesn't contain any information about how the bug exhibits, what kernels it affects, or any information about the bug in kernel mailing lists.
670: Fix/facter 2/fix threading with lang env
- A lot of strange little things here
- The use of Kernel.system() isn't portable to ruby 1.8
- We don't support threaded environments
- Peter will close because of these problems.
671: (FACT-476) Make the 'processor' fact for OpenBSD consistent with other systems
- Looks good. Previous behavior has just always been that way, but providing more information is probably better.
Hiera:
188: Allow for return of complex values across hiera
- This will end up changing the behavior of some current queries.
- Better is to have it use another pseudo-function for "alias" that has rules that only one alias is allowed and no
Held over:
Facter:
689 (FACT-547) Limit the output of prtdiag on Solaris
- Felix leaving a line note about the pathing for the 'head' command on the pipe
Puppet:
2709 (PUP-2701): Add PMT build metadata.json tests
- Joshua Partlow to verify these on a few platforms before merging
- Found some failures on centos6; will update prs and then ask if Kurt can continue
2716 (PUP-???): zypper should always be the default package provider for SUSE osfamily
- Needs a PUP-ticket
- Those present are not totally sure if zypper is the appropriate default and whether
or not this could break existing Puppet installs. Adrien is contacting colleague
at Attachmate / Novell?
- Rug was the previous default, but modern systems appear to be defaulting to zypper
- Adrien will retarget to puppet-4 (and update ticket reference) because we don't want to change default providers in a minor release
2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related to the forge
- The changes that were blocking this have landed. Kylo pinging pvande again.
- Need to ping pvande again to verify / merge
- Still no response, will wait another week
- Pieter responded on 6/5 with some comments but won't have time to review more deeply until after PE release
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperRegister by May 30th to take advantage of the Early Adopter discount —save $349!
Felix Frank
Jun 19, 2014, 4:23:09 PM6/19/14
to puppe...@googlegroups.com
On 06/18/2014 08:49 PM, Andy Parker
wrote:
2756: (PUP-1177) make sure ssh_known_hosts is not created with mode 0600
- Some questions about windows, but Peter thinks it should be fine
Yes, also even though the provider is not restricted to *NIX
explicitly, I doubt that it will be functional on Windows in its
current state.
Cheers,
Felix
Cheers,
Felix
Reply all
Reply to author
Forward
0 new messages