Puppet PR Triage Notes 2014-08-06

[Adrien Thebo]

Felix is writing a book on Puppet! If you're interested in helping with technical review send him an email, and glory and riches will be yours!

Attended: Finch, Michael, Rob, Joshua, Felix

New:

Facter:

741: Fact 637 add lsbminordistrelease

  - Copyright information in the fact implementation and specs, not sure if we have a policy for this. Pinged Haus and Moses.

Puppet:

2933: (PUP-1527) After upgrade from 3.3.2-1 to 3.4.2-1 naginator fails to crea...

  - Commits need squashing

  - Contributor is having issues signing the CLA, will sort that out.

Held Over:

Puppet:

2919: Proposal for processing an external trusted OID yaml file

  - JIRA issue has been filed for this pull request

  - Needs spec tests, needs refining of the implementation. We'll continue work on this with the contributor.

2915: Set accept-encoding to identity when http_compression is false

  - Looks fine; waiting for one spec name fix from Contributor, and pinged Josh Cooper for any comments, as he was last to mention this code change in the ticket.

  - Josh commented on this indicating that the puppet module tool will need a similar fix; we don't have enough information on this to proceed, waiting for feedback from Andy.

2890: vendor json_pure in OSX package

  - Closed by Moses in favor of discussion on CPR-37.

2879: Clarify possible exit codes and behavior with negative exit codes on Windows

  - Pinging Josh Cooper for additional feedback on doc changes.

2649: Add slot support for portage package provider.

  - Duplicates GH-2779, decision is to ping both contributors to see if they can coalesce their individual PRs into a single branch. Finch commenting this week.

  - GH-2779 hasn't seen updates, closing that one in favor of this one. There's some concern about possibly using `:` as a special value in package resource titles but we don't want to go down that route.

2683: Add more config manipulation options

  - Needs a JIRA issue and tests are failing

  - Would be a good fix to have, if contributor doesn't get back to us might be worthwhile to fixup ourselves.

  - Adrien asking for a Ticket so we can pull it onto community board and tackle it.

  - No response/no ticket, Joshua to create ticket

2770: Allow version and held states of a package to specified as separate properties

  - This is a very big and sticky issue, and might be worth promoting into the platform team because of the wide ranging ramifications

  - Plan is to discuss how we promote issues like this, and respond to the contributor with our next steps forward

  - Pending contributor response, willing to wait on this since we're asking a lot of the contributor

2881: Revert compare_stream to stdlib 1.9.3 implementation

  - Closed in favor of GH-2938 which was merged

2870 (PUP-19708) Make the puppet agent retry failed requests.

  - Issue in commit message references projects.puppetlabs.com ticket, actual issue is https://tickets.puppetlabs.com/browse/PUP-2526

  - There are a lot of cases where HTTP retries aren't meaningful (catalog retrieval, report submission)

  - We haven't been able to come to an agreement with the contributor about what requests should be retried and how, and we might not have the resources to make the changes ourselves.

  - Felix to comment

2869 Allow Upstart jobs on Amazon Linux

  - Ticket filed, issues pending on the pull request

  - Waiting on contributor feedback

2866 PUP-1244 puppet4

  - Switches the yum provider to use RPM version comparison instead of semantic version comparison

  - This might be breaking but is more correct and has been requested since Puppet 0.24, document as a breaking change in Puppet 4

  - Commit messages need to be fixed up, Andy to handle

  - Has an error; @jantman will be looking into it this week; check back next week.

  - Still waiting on contributor for changes; Joshua to ping

2820: (PUP-2867) Support ~ in file paths, allows to deploy to ~<user> directories

  - Already in discussion on puppet-dev

  - Tests are failing, commits need squashing; waiting for contributor response

  - What happens when the path starts with `~/` - do we expand to the current user?

2779: (PUP-2802) add slot support for packages in portage.rb

  - Closed for lack of updates

2614: (PUP-2452) Refresh support for Package type

  - Looks reasonable.

  - There is a question from the contributor about if there needs to be something changed to use this.

  - The answer to the question is, "yes, having a use of this is ideal".

  - Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.

  - Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.

  - This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.

  - Adrien to file a ticket on finer grained refresh handling and start a thread on puppet-dev to come to a decision about how to better control refresh events.

Facter

731: Display facts for aliases in *BSD

  - It looks like the code was written by a different contributor from the GitHub submitter, we need to work out the status of CLAs for the pull request

  - Code could use some refactoring, cleanup, and tests, but we can work with the contributor on that

  - Needs a JIRA issue

  - Still needs work; pending contributor response; check in next week. (2x)

--

Adrien Thebo | Puppet Labs

[Rob Reynolds]

     - How does this work or fail with Windows?

 

2779: (PUP-2802) add slot support for packages in portage.rb

  - Closed for lack of updates

2614: (PUP-2452) Refresh support for Package type

  - Looks reasonable.

  - There is a question from the contributor about if there needs to be something changed to use this.

  - The answer to the question is, "yes, having a use of this is ideal".

  - Adrien noted that using the :methods system for the feature is hard to control. Better is to require that the provider just explicitly declare the feature, which it already does.

  - Another concern came up about getting refresh events that will cause unintended reinstalls. Such a case is when a class contains a package and is the target of a notify.

  - This is a larger change to functionality that we need to bring up on puppet-dev to figure out how to deal with the unintended consequences of adding this functionality.

  - Adrien to file a ticket on finer grained refresh handling and start a thread on puppet-dev to come to a decision about how to better control refresh events.

Facter

731: Display facts for aliases in *BSD

  - It looks like the code was written by a different contributor from the GitHub submitter, we need to work out the status of CLAs for the pull request

  - Code could use some refactoring, cleanup, and tests, but we can work with the contributor on that

  - Needs a JIRA issue

  - Still needs work; pending contributor response; check in next week. (2x)

--

Adrien Thebo | Puppet Labs

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CALVJ9SJ_gxdGyjDKi%3DBPCZXnEmH3ZA80qhBkEbMgg5MF8OPG5g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Rob Reynolds

Developer, Puppet Labs

Join us at PuppetConf 2014, September 20-24 in San Francisco

Register by September 8th to take advantage of the Final Countdown —save $149!