Core Pull Request Triage time / format

[Kylo Ginsberg]

Hey folks,

For those of you sometimes attend (or would like to attend) the Core PR triage sessions which we have Wednesdays at 10 am Portland time, a couple improvement ideas:

1) At the Contributor Summit last week, we got some feedback on the current PR triage time and format. There were at least two ideas floated including:

* a later-in-the-day time (so US East Coast people could chime in after work)

* pre-announced focus for triage sessions (or ad-hoc sessions?)

If we did the time change, I think we'd want to do it alternate weeks or something so we don't have insane hours for Europe.

I kind of like the idea of having focus for triage sessions pre-announced (e.g. a "next week we're going to focus on X project or Y tix"), although it's worth mentioning that we generally open it up for nominees at the time. I.e. if you show up and say "I want to talk about PR 123" we'll give it a shot.

2) We're trying out putting the triage notes up on github (we'll still send out email as well). E.g. last triage's notes are at:

https://github.com/puppet-community/community-triage/blob/master/core/notes/2014-09-10.md

And, to save the first few minutes of bookkeeping, I put up pre-triage notes (i.e. removing PRs that were merged/closed and updating PRs that weren't) for tomorrow at:

https://github.com/puppet-community/community-triage/blob/master/core/notes/2014-10-01.md

So: thoughts about any of the above? Tell us what's working or what's not, be it wrt times / notes / etc.

Thanks!

Kylo

--

Kylo Ginsberg | ky...@puppetlabs.com | irc: kylo | twitter: @kylog

[Felix Frank]

On 10/01/2014 04:01 AM, Kylo Ginsberg wrote:
> * a later-in-the-day time (so US East Coast people could chime in
> after work)

*mumble, grumble* Well, I guess that would free up my Wednesday every
other week... ;-)

> * pre-announced focus for triage sessions (or ad-hoc sessions?)

Not sure what precipitated this. I kind of like the current "look at
whats up with Facter, Hiera and finally Puppet" thing and going through
the PRs in whatever order. In a perfect world, we'd have enough headway
at most times to touch on almost all open PRs.

ad-hoc sessions, well - sure, if someone can just drag the PR team from
IRC to a hangout, that could be worthwhile. Other than that, I
personally like to be able to plan for the "main event" triages (leaving
from work early, not doing other things etc.)

> 2) We're trying out putting the triage notes up on github (we'll still
> send out email as well). E.g. last triage's notes are at:

Here's another idea - I feel that "held over" PRs are limiting triage
throughput. It might just be me, but we're usually spending more than
half the time revisiting the stuff that was not yet concluded. Perhaps
it would be easier to

1. restructure the notes to form a lookup list, that allows the
moderator to look for notes on a specific PR when that PR comes up
2. use a strict "least recently updated" order of PRs to look at
3. perhaps prefaced with a "most recently updated" for such PRs that had
activity within the last seven days, i.e. since the previous triage

Additionally, the week to-do list for the PR team should likely
separated from the triage notes, so that it's more easier for you guys
to check things off it.

I'm not sure that this would work any better than what we do now,
looking forward to more discussion.

Cheers,
Felix

[Kylo Ginsberg]

On Wed, Oct 1, 2014 at 5:36 AM, Felix Frank <Felix...@alumni.tu-berlin.de> wrote:

On 10/01/2014 04:01 AM, Kylo Ginsberg wrote:
> * a later-in-the-day time (so US East Coast people could chime in
> after work)

*mumble, grumble* Well, I guess that would free up my Wednesday every
other week... ;-)

Well, let's see if we have consensus before we change anything :) Also I *just* at this moment realized that those of us who moderate triage have a swath of meetings Wed afternoons (our sprints are Wed-based), so couldn't actually do anything then. So, hmmm, let's see what kind of consensus we build here.

ad-hoc sessions, well - sure, if someone can just drag the PR team from
IRC to a hangout, that could be worthwhile.

Good point, and actually we do just that at times. Basically just as a general note to contributors: if you have the right people's attention on IRC and the conversation could use IRL dialog, you can always ask for an impromptu hangout. 

 

Here's another idea - I feel that "held over" PRs are limiting triage
throughput. It might just be me, but we're usually spending more than
half the time revisiting the stuff that was not yet concluded.

1. restructure the notes to form a lookup list, that allows the
moderator to look for notes on a specific PR when that PR comes up

Totally agree on too much time on "held over": last time it felt like a 30 minute preamble of bookkeeping, etc. That's actually what motivated me to try out the pre-triage notes experiment (linked above). I'm hoping that means we can just dive more directly into tackling PR code. So let's see if that change works and we can improve as we go. 

 

2. use a strict "least recently updated" order of PRs to look at
3. perhaps prefaced with a "most recently updated" for such PRs that had
activity within the last seven days, i.e. since the previous triage

Ooh, that makes a lot of sense: so I think you're saying: first do a MRU sort just to pick up changes in the last week, then switch to LRU for long-neglected PRs that need a nudge.

looking forward to more discussion.

Likewise. Thanks, as always, for your time!

Kylo

[Trevor Vaughan]

Well, I'm certainly happy to have it later in the day EST :-D.

There's no real day that's better for me than another but it would be nice to be able to participate outside of normal work hours.

Thanks,

Trevor

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CALsUZFH74%3D1iCPtGezHtPKK7Psw%2B1cOE0L7%3D5FbH84coMtGWtQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
Trevor Vaughan
Vice President, Onyx Point, Inc
(410) 541-6699
tvau...@onyxpoint.com

-- This account not approved for unencrypted proprietary information --