[Puppet-dev] Notes from Puppet PR Triage for 2014-05-07

[Ethan Brown]

Pull request triage - 2014-05-07

Joined: Ethan, Rob, Haus, Adrien, Kurt, Andy, JoshuaP, BrianL, Jeff (community), PeterH, Charlie, Ken Barber, Jeremy (community), Henrik, Arty Bel (community)

Candidates for merging:

  - 2492: (PUP-1381) issue warnings to current users of cron purging

  - 2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption

     - Adrien to fixup the commit / rebase / merge

  - 2472: (PUP-2040) Allow excluding files from module build package

     - Needs to be rebased

  - 2479: (PUP-2031) unless_uid on user is completely broken wrt ranges

     - Needs a little rework by PeterH

  - 2553: (PUP-2303) looks good to merge, being added to this weeks sprint

  - 2569: (PUP-1736) Andy to merge - Log master and agent locale information

  - 2571: (PUP-2339) looks good to merge to multiple branches, being added

          to this weeks sprint

  - 2574: Rob to merge this after cleaning up commit msg to reference (doc)

  - 2589: Josh Partlow to merge and update PUP-2369 ticket

  - 2594: Henrik to merge this documentation ticket from NickF

  - 2582: Adrien to merge this documentation ticket from NickF, update DOCUMENT-56

  - 2591: Andy to merge this documentation ticket from NickF, update DOCUMENT-57

  - 2581: Kylo to merge loglevel ticket from NickF / update DOCUMENT-5

  - 2600: Kylo to rebase to verify no TravisCI fails, merge and update DOC-738

  - 2602: Kylo to rebase to verify no TravisCI fails, merge and update DOC-739, DOC-740, DOC-742

  - 2609: Andy to merge this Haus STDERR fix

  - 559: (FACT-233) Add dhcp_server fact

      merged, but requires follow-up given there may need to be a new ticket for F20

Held over:

Puppet:

2262 - Fix yum/rpm version comparison to work the way RPM actually does:

  - We'll take this into puppet 4.

  - Also waiting for the puppet-4 branch. (2x)

  - Next step Jantman to rebase onto puppet 4 branch.

  - Closed in favor of opening a new pr against puppet-4

2492: (PUP-1381) issue warnings to current users of cron purging

  - Sending back to felix with the suggestion that he try option 3.

  - Felix to keep tinkering on it, Andy to look more closely.

2473: (PUP-1775) Acquire and block for Yum's lock to prevent corruption

  - domcleal verified it works, Adrien to pull into this week's sprint

  - Adrien commented that using 'yum update-check' might be better

  - Discussion is still ongoing

  - It looks like yumhelper could get completely deleted per Adrien / Charlie

  - Adrien to take on fixing up the timeout issue, rebasing and merging

2472: (PUP-2040) Allow excluding files from module build package

  - ping Alex or Ryan and ask where they want to take this. (2x)

  - Still no clear direction from Ryan and Co about where this should go (I think we should close it)

2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed

  - This is a modules/forge team, Adrien to ping everybody remotely related to the forge

  - The changes that were blocking this have landed. Kylo pinging pvande again.

  - Need to ping pvande again to verify / merge

2603 (PUP-2511): Add parser function digest, that calculates a checksum using the configured `digest_algorithm`

  - PR was originally 2453, and has been re-opened 

  - Was originally PUP-1820,b ut that has been closed, so creating new JIRA ticket (per Rob)

 

2479: (PUP-2031) unless_uid on user is completely broken wrt ranges

  - This removes pseudo ranges from unless_uid, adds comma separated values

  - Further simplify inputs to [String | Integer | Array<String | Integer>]

  - PeterH to take

  - PeterH didn't get to it. PeterH to take now

2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction

  - What sort of hooks do we want to define over the application lifetime?

  - Implement validate method on Type ancestor class, change method name something like `#check_constraints`

  - Latest set of changes looks good, but the pre_run_check should happen on the catalog evaluation

  - Adrien to ping Felix based on TravisCI failures

Facter:

New:

Puppet:

2569: (PUP-1736) Log master and agent locale information

  - Think this should be a more universal debug message.

  - Awaiting TravisCI build results, needs review

  - Andy to merge

2501: (maint) Return last serial from SSL inventory

  - Adrien pinged dalen, if he doesn't respond by 5/14, we should pull in to sprint and merge

2521: add caching to autolad

  - JoshuaP very reluctant to pull this in without a lot of testing, etc

  - Andy curious about the users environment, and why the speedup is significant

  - JoshuaP to close PR, follow up with contributor to open a ticket

2575: (PUP-2360) Yumrepo type allows invalid values

  - Adrien to ping contributor about additional tests

  - Basically looks good to merge once tests are in place

2577: (PUP-2356) Added some extra yumrepo options

  - Charlie to follow up with contributor on test failures

  - Otherwise, Adrien and Charlie give this the +1

2576: (PUP-2361) Make shellquote functino cope with empty args

  - After discussion, decided that this is not the responsibility of Puppet code,

    as there may be command line apps that expect quoted empty strings or quoted

    whitespace

  - Andy to close ticket in JIRA and PR

2583: (PUP-2537) Validate non-productive expressions

  - Requires rebasing by Henrik, will likely be pulled into next sprint

--

--

Ethan Brown

et...@puppetlabs.com

Software Engineer

Join us at PuppetConf 2014, September 22-24 in San Francisco

Register by May 30th to take advantage of the Early Adopter discount —save $349!