Global log_level param for Puppet

37 views
Skip to first unread message

Stefan Goethals

unread,
Mar 4, 2014, 9:17:46 AM3/4/14
to puppe...@googlegroups.com
Hello,

I am trying to create a global log_level param for puppet to set the maximum log level (reduce Puppet logging noise)

i have tried this so far


This 'seems' not very wrong as passing it on the cli works but it does not get set :-(

Can anyone help me along and tell me :

- i'm completely barking up the wrong tree with this code
- what i'm overlooking
- what i'm doing wrong...

Or point me to some doc/example that could help me along?

Thank you,

Stefan - Zipkid - Goethals.

Stefan Goethals

unread,
Mar 4, 2014, 11:37:32 AM3/4/14
to puppe...@googlegroups.com
After some advice from Erik on Github i updated my code and this seems to be doing what i expect.


I suppose there is more that must be done before i could PR this.

docs & testing

If anyone can help me (get started) on this that would be wonderful.

Stefan - Zipkid - Goethals.

Andy Parker

unread,
Mar 4, 2014, 2:36:06 PM3/4/14
to puppe...@googlegroups.com
On Tue, Mar 4, 2014 at 8:37 AM, Stefan Goethals <ste...@zipkid.eu> wrote:
After some advice from Erik on Github i updated my code and this seems to be doing what i expect.



I left a few comments as well.
 
I suppose there is more that must be done before i could PR this.


A little bit. There needs to be a ticket opened up in Jira explaining the feature, why it is useful, etc. Then update the commits to reference the ticket (see https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md#making-changes for the guidelines).
 
docs & testing


Testing this is a bit odd. Since it has to do with such an integral setup step it is hard for us to isolate that functionality fully. Of course that in itself means that we have some problems with our design :)

I think we might need to just forego some automated tests on this, unless you want to tackle some reworking of the logging system's design.

Docs for this are just in the desc attribute of the setting.
 
If anyone can help me (get started) on this that would be wonderful.

Stefan - Zipkid - Goethals.


On Tue, Mar 4, 2014 at 3:17 PM, Stefan Goethals <ste...@zipkid.eu> wrote:
Hello,

I am trying to create a global log_level param for puppet to set the maximum log level (reduce Puppet logging noise)

i have tried this so far


This 'seems' not very wrong as passing it on the cli works but it does not get set :-(

Can anyone help me along and tell me :

- i'm completely barking up the wrong tree with this code
- what i'm overlooking
- what i'm doing wrong...

Or point me to some doc/example that could help me along?

Thank you,

Stefan - Zipkid - Goethals.


--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CAJqH209ZNBohrB%2B%2BwZQisffaK%3DHBF%2B6Z1uvESgfe5izP7XnU-Q%40mail.gmail.com.

For more options, visit https://groups.google.com/groups/opt_out.



--
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software Developer

Join us at PuppetConf 2014, September 23-24 in San Francisco - http://bit.ly/pupconf14
Reply all
Reply to author
Forward
0 new messages