Puppet PR Triage Notes 2014-06-11

[Joshua Partlow]

Joined: Andy, JoshC, JoshP, Adrien, FelixF, Henrik, Peter, Branan

Candidates for merging:

  - 2736: (PUP-2454) Don't purge system users on OpenBSD

      - Formerly 2547, currently failing TravisCI build

      - Passing now; Josh to merge

  - 683 (FACT-484): check dmi sysfs file for readability instead of just existence

      - Adrien to merge, should be on facter-2 branch

      - Moved to #690

      - and merged last week

  - 2666: (maint) Resolve some documentation TODOs in Puppet::Type

      - There are concerns about #uniqueness_key being public API, and composite

        namevars are not well supported. We need to decide if we want to really

        support those.

      - Peter to review and merge

New:

Facter:

689 (FACT-547) Limit the output of prtdiag on Solaris

  - Felix leaving a line note about the pathing for the 'head' command on the pipe

687 (FACT-179) Resolve fqdn fact when domain is empty

  - JoshC merging

686 (FACT-464) Improved support of Mandrake-derived osfamily detection

  - Some questions about whether platforms still exist, at least some do

  - JoshP merged

685 (FACT-197) Backport Solaris processorcount fix

  - Peter to merge

2721 (PUP-2622) Use non-zero exit codes for unknown subcommands

  - JoshP to merge

Puppet:

2758 (PUP-2747) Add support for multiple profilers

  - Concern that changes tie the use of a profiler to the global system Puppet::Util::Profiler, and that we should still be able to use a profiler independently.

  - Andy commenting on PR

Held over:

Puppet:

2638 (PUP-2520): implements 'manual' environment directories

  - JoshP to contact contributor on PR

  - commits should reference PUP-2520 instead of 2520

  - dubious value, and other higher priority work on environments ongoing

  - will consider pulling into a future sprint, but no time presently, most

    likely landing in Puppet 4

  - JoshP will close and apologize to Brice for getting this started

2707 (PUP-2635): Use generate instead of eval_generate to purge ssh keys

  - Andy to investigate prioritizers and comments made on PR

  - requires additional review before considering merge

  - Following up with #2744

2744 (maint): Stop enforcing the random prioritizer for evaluation in spec tests

  - Andy to merge to stable

  - merged

2709 (PUP-2701): Add PMT build metadata.json tests

  - Joshua Partlow to verify these on a few platforms before merging

  - Found some failures on centos6; will update prs and then ask if Kurt can continue

2716 (PUP-???): zypper should always be the default package provider for SUSE osfamily

  - Needs a PUP-ticket

  - Those present are not totally sure if zypper is the appropriate default and whether

    or not this could break existing Puppet installs.  Adrien is contacting colleague

    at Attachmate / Novell?

  - Rug was the previous default, but modern systems appear to be defaulting to zypper

  - Adrien will retarget to puppet-4 (and update ticket reference) because we don't want to change default providers in a minor release

2734 (PUP-2579): Improve regular expression for options of ssh_authorized_keys

  - Josh to review, noticed "type" is now a reserved word and will file additional ticket for that

  - Follow up with contributor about adding tests, which are non-trivial

  - Need CLA from contributor

  - JoshC is adding a spec; also commit message is truncated

2738 (maint): Reduce redunandcy in Puppet::Util::Posix

  - requires some minor tweaks to naming - ie 'the_thing' should be 'group_or_user' 

  - Adrien merged

2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed

  - This is a modules/forge team, Adrien to ping everybody remotely related to the forge

  - The changes that were blocking this have landed. Kylo pinging pvande again.

  - Need to ping pvande again to verify / merge

  - Still no response, will wait another week

  - Pieter responded on 6/5 with some comments but won't have time to review more deeply until after PE release

2704: (PUP-2569) (maint) Return last serial from SSL inventory

  - Andy to log a ticket, continue discussion on ticket, e.g. revoke all certificates for a specified name

  - PR needs to be updated with issue # in commit, revoke all certificates with a given name, preserve existing API

  * formerly 2501, which is closed now

  - Andy to make some small changes and merge in

  * merged

2558: (PUP-1069) upgradeable OpenBSD package provider

  - Second PR to adding this functionality

  - Adrien to comment in the PR that we want this but will need to defer another week (2x)

  - Adrien merging

2605: (PUP-2576,PUP-1381) Read all crontabs

  - Felix to update PR with JIRA ticket for 4.0

  - Felix to file separate deprecation_warning ticket for 3.7

  - Felix to update pull request with points from triage discussion

  - JoshC will merge to puppet-4

--

Josh Partlow

jpar...@puppetlabs.com

Developer, Puppet Labs

Join us at PuppetConf 2014, September 20-24 in San Francisco

Register by July 31st to take advantage of the Early Bird discount —save $249!