Notes from PR Triage on March 19th, 2014

19 views
Skip to first unread message

Andy Parker

unread,
Mar 19, 2014, 2:10:35 PM3/19/14
to puppe...@googlegroups.com

Joined:

zaphod42, finch, petems, Dominic, jpartlow, helindbe, peterhu, zipkid, Brian

Held over:

Puppet:
2276: Remove debian as provider for ubuntu. No response from contributor, we will fix ourselves. - Finch to grab this week Merged by Adrien
2067: zypper, pushed to 3.6 - Peter is looking into this, seeking a SLES12 box from release Merged by Peter
2342: Cron user/target properties. Good to go, needs one spec test fix then Charlie to merge in. New ticket for long-term solution. - Charlie still to merge? Merged by Charlie
2414 -> JoshC is going to review for merge Peter will take over
2387: yum lock: concerns about leaving the db open. Finch to ask for a reproduction case. -- Dominic Cleal is going to comment on this, not mergeable as is Dominic commented and discovered that it relies on a buggy method, suggested some changes. Dominic will try putting together a new patch.
2385: Charlie to merging -- Charlie will merge Merged by Charlie
2383: suse chkconfig behavior. No tests or ticket, Adrien to comment with some questions. -- Peter is taking this as well Closed in favor of 2447
2378: factoring tar to work more x-platform. Adrien to find out about gzip and help with specs -- Andy is merging Merged by Adrien
2366: pkgdmg errors on eject due to (at least) spotlight. Needs a ticket. Moses: just do the eject (the temp copy is another way to fail). Adrien to add comments. -- still waiting to hear back  Asking Garry Larizza for his opinion.
2327: Consensus reached! We'll pull it in for 3.6 -- Charlie to pull in
2331: Pull in for 3.6.0 -- defering to next week Charlie to take when he has time
2311: We'd like to try this out and see if there's a better way to handle there not being any provider. -- Joshua will take this
2112: Finch to fix up and merge in. -- Finch still to do Merged by Adrien
2309: Would rather see held stay as ensure and a version parameter pulled out. Finch to add comment -- Adrien will start a puppet-dev conversation   Push to lollipopman to start puppet-dev convo
2415: Dominic to rework using Puppet::Util::RubyGems Andy to take a look at and merge (also look into whether this should go onto stable branch).
2425: Charlie to tag commmit with maint and then merge Merged by Charlie
2397: There is an issue that binread produces ASCII-8BIT -- Josh is closing, need a new method that respects line endings without changing the encoding Rejected by Josh
2422: Peter will merge in Merged by Peter
2429: Peter Souter to fix specs PererH to take, since he is the "install options" man!

Facter:
559: Adrien is going to convert to a structured fact for 2.1 Because of the 2.0.1 and 2.1 timelines we'll just hold this open for now.
566: Passing over for next week, Adrien may need to change it Adrien to try to pull into this next sprint
580: Skipping over for next week Kicking over to Kylo for some guidance on where to take this work.
594: JoshC will comment on regex used for major release, waiting to hear back Adrien to pull in to make it into 2.0.1
595: Blocked on us backporting GCE facts to Facter-2 branch, also there's a sudo call in one of the execs, may need to confine to root, Adrien will touch base with Alex on this  Same limbo as 559
608: Needs commit message updated to include ticket number - Adrien
609: Josh C is updating Closed with the suggestion that the submitter reopen if they can fix it up.
610: Adrien to pull into stable Merged by Adrien
617: replaced by 642 and Adrien will follow up with Moses 

642: Still waiting for Moses. Adrien to harass Moses.

New:

Hiera:

184: Andy to take and comment. We can't take it as is because it is backwards incompatible.
182: Henrik to open up a hiera ticket, fix up commits to reference it, and merge it in.

Puppet:

2428: Joshua to just merge it in.
2449: Just needs a quick review. Seems good, though. Andy will grab.
2413: Henrik to take this and help Stefan learn to do the rebase.
2444: Most likely good. Andy to pull into this sprint.
2427: PeterH to close it as a dup of 2441
2420: Don't know what the fix is for. Asked user to open a ticket with a reproduction case.
2323: Ping Haus and Moses again.
2129: Adrien to make sure it is still good and merge it in. 

--
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software Developer

Join us at PuppetConf 2014September 23-24 in San Francisco - http://bit.ly/pupconf14

Erik Dalén

unread,
Mar 19, 2014, 2:28:25 PM3/19/14
to Puppet Developers
Would it be possible to include the title of the PRs in these summaries? Would make them much easier to read without a ton of cross referencing.


--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/CANhgQXs9shOx%2BpaJcpEpVaNwAFoYFKpDkAHT2Ge98-s__gxgGg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.



--
Erik Dalén

Andy Parker

unread,
Mar 19, 2014, 3:47:32 PM3/19/14
to puppe...@googlegroups.com
On Wed, Mar 19, 2014 at 11:28 AM, Erik Dalén <erik.gus...@gmail.com> wrote:
Would it be possible to include the title of the PRs in these summaries? Would make them much easier to read without a ton of cross referencing.


Are you telling me you don't have all of the numbers memorized? :)

Including the PR titles should be easy enough. I'll try to remember that for next time.
 

For more options, visit https://groups.google.com/d/optout.



--
Reply all
Reply to author
Forward
0 new messages