Hey everyone,
thanks for your feedback. We appear to see some support for all options
except #1. That one is apparently universally despised.
I'll try and summarize the discussion. Pros get a + plus and cons a - dash.
Option 2: Override ENC environment but only from the commandline.
+ convenient override
+ CLI invocation works as expected (by most)
- config options behave differently from CLI vs. config file, which is
confusing
- explicitly setting the default on the CLI is different from skipping
it or doing it in the config, which is surprising
Option 2a:
+ convenient override
+ configuration options in files and parameters behave identically
- explicitly setting the default in the config has other semantics than
skipping it, which is surprising
Option 3:
+ ENC is important for most masterless folks, who will want it to
override local shenanigans
+ easily overridden via --node_terminus=plain
+ regular use case: ENC is chosen via parameter anyway for masterless,
not for any `apply` run, via dedicated script, and should overrule
environment from the config then
+ apply behaves more like agent (omg consistency)
- will confuse users who pass an environment which won't take effect
All things considered, we find ourselves in a fine position to choose
our poison. There were more votes from the 2/2a camps, but also good
points from RI in favor of 3.
This leads me to believe that whatever we choose, a priority should be
for `apply` to be very vocal about which environment is in effect, and
how it was chosen. I don't think we have so much as a debug message
right now. I propose a notice to always comment on the environment.
Perhaps even a warning when the user is apparently trying to do
something that can't work.
I was just about to suggest just taking 2a for all the votes it received
and for being the closest to current behavior (minus insanity). But then
the list of arguments in favor of 3 is rather impressive. Its negatives
aren't too bad, and can be mitigated through UI design.
Call to the 2/2a supporters - are you at all swayed by those?
Cheers,
Felix