PUP-5296

42 views
Skip to first unread message

Alex Harvey

unread,
Mar 13, 2016, 7:59:50 PM3/13/16
to Puppet Developers
Hi all,

I have just discovered the bug PUP-5296 using the latest Puppet 4 and the Puppet Labs CentOS 7 vagrant box.

This bug, reported 6 months ago, breaks idempotence in any module that tries to use an Init-style service in the wonderful world that is Systemd.  E.g.

[root@centos-72-x64 ~]# puppet apply /tmp/apply_manifest.pp.ZEj2Kr
Notice: Compiled catalog for centos-72-x64.wg.dir.telstra.com in environment production in 2.10 seconds
Notice: /Stage[main]/Kibana4::Service/Service[kibana4]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 18.70 seconds

[root@centos-72-x64 ~]# puppet apply /tmp/apply_manifest.pp.ZEj2Kr
Notice: Compiled catalog for centos-72-x64.wg.dir.telstra.com in environment production in 2.26 seconds
Notice: /Stage[main]/Kibana4::Service/Service[kibana4]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 18.61 seconds

A workaround might be to raise a PR to add optional provider overrides for every module in the world that tries to manage a SysV style service on a platform.

But the bug report indicates that we already know what the fix is for this bug?  Can't we just fix it?

Thanks,
Alex

--
Partner
RAZOR Consulting
t: +61 409 665 227

Henrik Lindberg

unread,
Mar 13, 2016, 9:07:34 PM3/13/16
to puppe...@googlegroups.com
Thanks for raising the awareness, seems like that ticket had fallen
through the cracks. I assigned the ticket to the Client Platform Team
and pinged Kylo Ginsberg.

- henrik

--

Visit my Blog "Puppet on the Edge"
http://puppet-on-the-edge.blogspot.se/

Rob Nelson

unread,
Mar 13, 2016, 9:33:29 PM3/13/16
to puppe...@googlegroups.com
Fwiw, I'm not seeing this in any modules on EL7, I assume because all the packages I use support systemd, so it may not be that widespread across EL7 users.
--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/47bb57e7-30ef-4494-8230-c326829f740d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


--

Alex Harvey

unread,
Mar 13, 2016, 9:39:58 PM3/13/16
to Puppet Developers
Fair enough.  I have hit it twice in 11 modules that I'm using to build an ELK solution on CentOS 7.  Perhaps I'm just unlucky.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@googlegroups.com.


--

Alex Harvey

unread,
Mar 13, 2016, 10:38:17 PM3/13/16
to Puppet Developers
Actually no it's affecting way more than that:

[root@centos-72-x64 ~]# puppet apply -e 'include profile::logstash::indexer'
Notice: Compiled catalog for centos-72-x64.wg.dir.telstra.com in environment production in 0.54 seconds
Notice: /Stage[main]/Profile::Logstash::Indexer/Service[logstash-indexer]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 0.99 seconds

[root@centos-72-x64 ~]# puppet apply -e 'include profile::logstash::shipper'
Notice: Compiled catalog for centos-72-x64.wg.dir.telstra.com in environment production in 0.47 seconds
Notice: /Stage[main]/Profile::Logstash::Shipper/Service[logstash-shipper]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 0.92 seconds

[root@centos-72-x64 ~]# puppet apply -e 'include profile::redis'
Notice: Compiled catalog for centos-72-x64.wg.dir.telstra.com in environment production in 0.73 seconds
Notice: /Stage[main]/Disable_transparent_hugepage/Service[disable-transparent-hugepage]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 1.79 seconds

[root@centos-72-x64 ~]# puppet apply -e 'include profile::kibana4'
Notice: Compiled catalog for centos-72-x64.wg.dir.telstra.com in environment production in 0.44 seconds
Notice: /Stage[main]/Kibana4::Service/Service[kibana4]/enable: enable changed 'false' to 'true'
Notice: Applied catalog in 0.72 seconds

[root@centos-72-x64 ~]# puppet resource service network enable=true
Notice: /Service[network]/enable: enable changed 'false' to 'true'
service { 'network':
  ensure => 'running',
  enable => 'false',
}

On Monday, March 14, 2016 at 12:33:29 PM UTC+11, Rob Nelson wrote:
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@googlegroups.com.


--

Eli Young

unread,
Mar 14, 2016, 2:08:53 AM3/14/16
to Puppet Developers

My guess, based on similar behavior in Chef, is that, for SysV init scripts, it's trying to use the SysV init system directly either via the service command or by calling the scripts themselves directly. Unfortunately, this doesn’t play super nicely with SysV init scripts that have been started by systemd. Forcing the provider to be systemd should restore idempotence.

 

Sent from my Windows 10 phone

To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.



--

 

--

You received this message because you are subscribed to the Google Groups "Puppet Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/8917427f-b679-49df-8ad5-0d32387b802a%40googlegroups.com.

Kylo Ginsberg

unread,
Mar 14, 2016, 12:39:50 PM3/14/16
to puppe...@googlegroups.com
Yep, thanks for raising awareness.

This ticket looks like it might be addressed by (or should be considered while reviewing) two active PRs:

Kylo


For more options, visit https://groups.google.com/d/optout.



--
Kylo Ginsberg | ky...@puppetlabs.com | irc: kylo | twitter: @kylog

Reply all
Reply to author
Forward
0 new messages