Pull request triage - 2014-05-28
46 views
Skip to first unread message
Andy Parker
May 28, 2014, 2:53:51 PM5/28/14
to puppe...@googlegroups.com
Pull request triage - 2014-05-28
This triage time was spent trying to burn down the backlog of PRs where we had already made decisions on. We spent nearly the entire time just working on the final review, test, cleanup, and merge. No new PRs were covered.
Joined: Charlie, Ethan, Jeremy, JoshC, Kylo, Peter, Andy, JoshuaP
Candidates for merging:
- 2492: (PUP-1381) issue warnings to current users of cron purging
- Andy Merged
- 2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction
- Josh Merging
- 2577: (PUP-2356) Added some extra yumrepo options
- Charlie Reviewing
- 2547: (PUP-2454) Don't purge system users on OpenBSD
- Removing from candidate since it needs work from submitter after some review.
- 559: (FACT-233) Add dhcp_server fact
- merged, but requires follow-up given there may need to be a new ticket for F20
- Kylo merged followup
- 2616: (PUP-1070) Cleanup empty/invalid lock file
- Ethan Merging
- 2639: (PUP-1843) Restore hiera indirector terminus
- Joshua removing duplication and merging
Held over:
Puppet:
2492: (PUP-1381) issue warnings to current users of cron purging
- Sending back to felix with the suggestion that he try option 3.
- Felix to keep tinkering on it, Andy to look more closely.
- Ready for review, Andy to pull into sprint for 3.7.x
- Merged in during this PR triage meeting
2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related to the forge
- The changes that were blocking this have landed. Kylo pinging pvande again.
- Need to ping pvande again to verify / merge
- Still no response, will wait another week
2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction
- Adrien to ping Felix based on TravisCI failures
- Thumbs up, Adrien to pull into next sprint or two
- Kicked out of the 05/14 - 05/21 sprint, hopefully we'll get to it this week
2501: (PUP-2569) (maint) Return last serial from SSL inventory
- Andy to log a ticket, continue discussion on ticket, e.g. revoke all certificates for a specified name
- PR needs to be updated with issue # in commit, revoke all certificates with a given name, preserve existing API
- Kylo to update pull request
2577: (PUP-2356) Added some extra yumrepo options
- Charlie to follow up with contributor on test failures
- Otherwise, Adrien and Charlie give this the +1
- PR spec tests updated, pulling into 05/21 - 05/28 sprint
2639: (PUP-1843) Restore hiera indirector terminus
- Andy commented that this duplicates code, waiting on Erik
2557: (PUP-2578) Unbreak OpenBSD services from packages which set local flags
- Needs tests, Rob to comment
- Our current sprint is pretty full, won't be able to pull into this week's sprint
- Sprint is still pretty full, deferring for another week
2558: (PUP-1069) upgradeable OpenBSD package provider
- Second PR to adding this functionality
- Adrien to comment in the PR that we want this but will need to defer another week (2x)
2547: (PUP-2454) Don't purge system users on OpenBSD
- Current behavior is dangerous on OpenBSD & Debian, this would provide incremental improvement
- Pull request updated for Debian but Debian system UIDs are 100 - 999, comment added
- Peter worked on during the PR Triage. Jasper needs to fix up.
2605: (PUP-1381) Read all crontabs
- Felix to update PR with JIRA ticket for 4.0
- Felix to file separate deprecation_warning ticket for 3.7
- Felix to update pull request with points from triage discussion
2616: (PUP-1070) Cleanup empty/invalid lockfile
- Puppet used to use an empty lockfile to mean the agent is administratively disabled
- Andy and Adrien to add comments
- Adrien to not overcommit us for another sprint, we're going to defer on this.
2666: (maint) Resolve some documentation TODOs in Puppet::Type
- There are concerns about #uniqueness_key being public API, and composite
namevars are not well supported. We need to decide if we want to really
support those.
--
This triage time was spent trying to burn down the backlog of PRs where we had already made decisions on. We spent nearly the entire time just working on the final review, test, cleanup, and merge. No new PRs were covered.
Joined: Charlie, Ethan, Jeremy, JoshC, Kylo, Peter, Andy, JoshuaP
Candidates for merging:
- 2492: (PUP-1381) issue warnings to current users of cron purging
- Andy Merged
- 2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction
- Josh Merging
- 2577: (PUP-2356) Added some extra yumrepo options
- Charlie Reviewing
- 2547: (PUP-2454) Don't purge system users on OpenBSD
- Removing from candidate since it needs work from submitter after some review.
- 559: (FACT-233) Add dhcp_server fact
- merged, but requires follow-up given there may need to be a new ticket for F20
- Kylo merged followup
- 2616: (PUP-1070) Cleanup empty/invalid lock file
- Ethan Merging
- 2639: (PUP-1843) Restore hiera indirector terminus
- Joshua removing duplication and merging
Held over:
Puppet:
2492: (PUP-1381) issue warnings to current users of cron purging
- Sending back to felix with the suggestion that he try option 3.
- Felix to keep tinkering on it, Andy to look more closely.
- Ready for review, Andy to pull into sprint for 3.7.x
- Merged in during this PR triage meeting
2468 (PUP-2079): Add mechanism to allow template files to be copied without getting parsed
- This is a modules/forge team, Adrien to ping everybody remotely related to the forge
- The changes that were blocking this have landed. Kylo pinging pvande again.
- Need to ping pvande again to verify / merge
- Still no response, will wait another week
2549: (PUP-2298) add support for Type#in_valid_catalog? methods to transaction
- Adrien to ping Felix based on TravisCI failures
- Thumbs up, Adrien to pull into next sprint or two
- Kicked out of the 05/14 - 05/21 sprint, hopefully we'll get to it this week
2501: (PUP-2569) (maint) Return last serial from SSL inventory
- Andy to log a ticket, continue discussion on ticket, e.g. revoke all certificates for a specified name
- PR needs to be updated with issue # in commit, revoke all certificates with a given name, preserve existing API
- Kylo to update pull request
2577: (PUP-2356) Added some extra yumrepo options
- Charlie to follow up with contributor on test failures
- Otherwise, Adrien and Charlie give this the +1
- PR spec tests updated, pulling into 05/21 - 05/28 sprint
2639: (PUP-1843) Restore hiera indirector terminus
- Andy commented that this duplicates code, waiting on Erik
2557: (PUP-2578) Unbreak OpenBSD services from packages which set local flags
- Needs tests, Rob to comment
- Our current sprint is pretty full, won't be able to pull into this week's sprint
- Sprint is still pretty full, deferring for another week
2558: (PUP-1069) upgradeable OpenBSD package provider
- Second PR to adding this functionality
- Adrien to comment in the PR that we want this but will need to defer another week (2x)
2547: (PUP-2454) Don't purge system users on OpenBSD
- Current behavior is dangerous on OpenBSD & Debian, this would provide incremental improvement
- Pull request updated for Debian but Debian system UIDs are 100 - 999, comment added
- Peter worked on during the PR Triage. Jasper needs to fix up.
2605: (PUP-1381) Read all crontabs
- Felix to update PR with JIRA ticket for 4.0
- Felix to file separate deprecation_warning ticket for 3.7
- Felix to update pull request with points from triage discussion
2616: (PUP-1070) Cleanup empty/invalid lockfile
- Puppet used to use an empty lockfile to mean the agent is administratively disabled
- Andy and Adrien to add comments
- Adrien to not overcommit us for another sprint, we're going to defer on this.
2666: (maint) Resolve some documentation TODOs in Puppet::Type
- There are concerns about #uniqueness_key being public API, and composite
namevars are not well supported. We need to decide if we want to really
support those.
Andrew Parker
Freenode: zaphod42
Twitter: @aparker42
Software DeveloperRegister by May 30th to take advantage of the Early Adopter discount —save $349!
Brice Figureau
May 29, 2014, 5:36:42 AM5/29/14
to puppe...@googlegroups.com
Hi Andy,
On 28/05/2014 20:53, Andy Parker wrote:
> Pull request triage - 2014-05-28
>
> This triage time was spent trying to burn down the backlog of PRs where
> we had already made decisions on. We spent nearly the entire time just
> working on the final review, test, cleanup, and merge. No new PRs were
> covered.
I know I wasn't part from the hangout to lobby for PR 2638 (PUP-2520),
but I just wanted to remind you all about it, so that it doesn't fall
through the cracks :)
Let me know if there are still some work to do on it.
On another topic, I was wondering if there were some (easy?) tickets I
could work on. If any of you have one that they want to address, let me
know as I need my ruby fix :)
Many thanks,
--
Brice Figureau
My Blog: http://www.masterzen.fr/
On 28/05/2014 20:53, Andy Parker wrote:
> Pull request triage - 2014-05-28
>
> This triage time was spent trying to burn down the backlog of PRs where
> we had already made decisions on. We spent nearly the entire time just
> working on the final review, test, cleanup, and merge. No new PRs were
> covered.
but I just wanted to remind you all about it, so that it doesn't fall
through the cracks :)
Let me know if there are still some work to do on it.
On another topic, I was wondering if there were some (easy?) tickets I
could work on. If any of you have one that they want to address, let me
know as I need my ruby fix :)
Many thanks,
--
Brice Figureau
My Blog: http://www.masterzen.fr/
Erik Dalén
May 29, 2014, 7:30:19 AM5/29/14
to Puppet Developers
I have one assigned to me that should be pretty easy but I've been fairly busy lately:
first PR here: https://github.com/puppetlabs/puppet/pull/2501 but it was decided it should instead revoke all certs with the name specified instead of only the last.
If you want to take it feel free.
I've also meant to fix two locking issues that should be fairly easy, but also haven't had time yet, PUP-2573 & PUP-2574
Erik Dalén
Brice Figureau
May 29, 2014, 4:57:32 PM5/29/14
to puppe...@googlegroups.com
Hi Erik,
On 29/05/2014 13:30, Erik Dalén wrote:
> On 29 May 2014 11:36, Brice Figureau <brice-...@daysofwonder.com
> I've also meant to fix two locking issues that should be fairly easy,
> but also haven't had time yet, PUP-2573 & PUP-2574
I'll have a look after PUP-2569 if you haven't tackled those first.
Thanks!
On 29/05/2014 13:30, Erik Dalén wrote:
> On 29 May 2014 11:36, Brice Figureau <brice-...@daysofwonder.com
> <mailto:brice-...@daysofwonder.com>> wrote:
>
> Hi Andy,
>
>
> On 28/05/2014 20:53, Andy Parker wrote:
> > Pull request triage - 2014-05-28
> >
> > This triage time was spent trying to burn down the backlog of PRs
> where
> > we had already made decisions on. We spent nearly the entire time just
> > working on the final review, test, cleanup, and merge. No new PRs were
> > covered.
>
> I know I wasn't part from the hangout to lobby for PR 2638 (PUP-2520),
> but I just wanted to remind you all about it, so that it doesn't fall
> through the cracks :)
> Let me know if there are still some work to do on it.
>
> On another topic, I was wondering if there were some (easy?) tickets I
> could work on. If any of you have one that they want to address, let me
> know as I need my ruby fix :)
>
>
> I have one assigned to me that should be pretty easy but I've been
> fairly busy lately:
> https://tickets.puppetlabs.com/browse/PUP-2569
>
> first PR here: https://github.com/puppetlabs/puppet/pull/2501 but it was
> decided it should instead revoke all certs with the name specified
> instead of only the last.
>
>
> If you want to take it feel free.
I've started working on it. I should have a PR by tomorrow, thanks!
>
> Hi Andy,
>
>
> On 28/05/2014 20:53, Andy Parker wrote:
> > Pull request triage - 2014-05-28
> >
> > This triage time was spent trying to burn down the backlog of PRs
> where
> > we had already made decisions on. We spent nearly the entire time just
> > working on the final review, test, cleanup, and merge. No new PRs were
> > covered.
>
> I know I wasn't part from the hangout to lobby for PR 2638 (PUP-2520),
> but I just wanted to remind you all about it, so that it doesn't fall
> through the cracks :)
> Let me know if there are still some work to do on it.
>
> On another topic, I was wondering if there were some (easy?) tickets I
> could work on. If any of you have one that they want to address, let me
> know as I need my ruby fix :)
>
>
> I have one assigned to me that should be pretty easy but I've been
> fairly busy lately:
> https://tickets.puppetlabs.com/browse/PUP-2569
>
> first PR here: https://github.com/puppetlabs/puppet/pull/2501 but it was
> decided it should instead revoke all certs with the name specified
> instead of only the last.
>
>
> If you want to take it feel free.
> I've also meant to fix two locking issues that should be fairly easy,
> but also haven't had time yet, PUP-2573 & PUP-2574
Thanks!
Reply all
Reply to author
Forward
0 new messages