puppetlabs/puppet - Pull Request #2025

[glenn....@gmail.com]

Hi,

 

I originaly submitted PR 2021 but I didn't follow the contributing guidelines so I cancelled that PR and resubmitted part of it as PR 2025.  However I did this nearly a month ago and I don't think anyone has reviewed it, at least, they haven't left any comments.  I'm pretty sure I followed the contributing guidelines properly (although my branch name could've been better)

 

* Is this timeframe normal?  PR2021 had comments within 24 hours 

* I noticed in other Pull Requests that there's an entry for "All Contributors have accepted the CLA" and while I have accepted the CLA, it's not mentioned.

 

https://projects.puppetlabs.com/issues/21641

https://github.com/puppetlabs/puppet/pull/2025

[Henrik Lindberg]

Hi, we are now trying to triage the PR backlog once a week, but it is
hard given that there is also a 3.4.0 release being prepared and the
Americans have been off eating turkey...

Your contribution is valued, we will get around to reviewing it.

Windows and logging issues are not my strongest subject, but I will take
a look at your contribution and see if I have any comments that can help
getting it accepted faster.

Regards
- henrik

[Kylo Ginsberg]

On Sun, Dec 1, 2013 at 5:59 PM, Henrik Lindberg <henrik....@cloudsmith.com> wrote:

On 2013-02-12 2:04, glenn....@gmail.com wrote:

* Is this timeframe normal?  PR2021 had comments within 24 hours
* I noticed in other Pull Requests that there's an entry for "All
Contributors have accepted the CLA" and while I have accepted the CLA,
it's not mentioned.

 

Hi, we are now trying to triage the PR backlog once a week, but it is hard given that there is also a 3.4.0 release being prepared and the Americans have been off eating turkey...

Your contribution is valued, we will get around to reviewing it.

Hi Glenn,

Thanks for raising the issue.  As Henrik said, we've moved to regular (actually fortnightly) triage of the PR backlog on a google hangout, but we've been doing it in a time-limited manner which means we've gotten behind.  That, plus yes 3.4 and thanksgiving have all contributed to our getting behind.  I think we need a "catch-up" session or two on the PR backlog.

Meanwhile, please know that your contribution is really valued *and* we should have more bandwidth for PR triage now that we're over the 3.4/turkey hump.

On the CLA thing, the bot was misbehaving in the timeframe when you submitted 2025; I'll double-check on that tomorrow.

Thanks,

Kylo

[Felix Frank]

Are there code names for minor releases? If so, 3.4 should definitely
become "turkey hump" :-)

I feel you Glenn, got some starving children in that queue as well, but
let's practice faith in this spiritual season ;-)
Speaking of which - those patches aren't going anywhere, for my part I'd
be fine with discussing those come new year. No rush.

Cheers,
Felix

[Andy Parker]

On Sun, Dec 1, 2013 at 5:59 PM, Henrik Lindberg <henrik....@cloudsmith.com> wrote:

On 2013-02-12 2:04, glenn....@gmail.com wrote:

Hi,
I originaly submitted PR 2021 but I didn't follow the contributing
guidelines so I cancelled that PR and resubmitted part of it as PR
2025.  However I did this nearly a month ago and I don't think anyone
has reviewed it, at least, they haven't left any comments.  I'm pretty
sure I followed the contributing guidelines properly (although my branch
name could've been better)
* Is this timeframe normal?  PR2021 had comments within 24 hours
* I noticed in other Pull Requests that there's an entry for "All
Contributors have accepted the CLA" and while I have accepted the CLA,
it's not mentioned.
https://projects.puppetlabs.com/issues/21641
https://github.com/puppetlabs/puppet/pull/2025

Hi, we are now trying to triage the PR backlog once a week, but it is hard given that there is also a 3.4.0 release being prepared and the Americans have been off eating turkey...

Your contribution is valued, we will get around to reviewing it.

Just a quick follow up to give some background on what is happening.

When I first joined the team back in 2012 we were trying to do a weekly rotation where each PL employee on the core team tried to review redmine issues and deal with pull requests for the week. After a bit of time it was turning out that we were having a hard time keeping on top of the pull requests and understanding the issues. It really takes a lot of time and effort to understand what is being presented deeply enough to be able to give a meaningful response. It also meant that it became hard for us to concentrate on some other issues for long periods of time.

We got help on the redmine issue front with Charlie Sharpsteen taking over trying to triage (and sometimes fix!) the issues that were reported. He helped us out immensely by being able to link things together and notice some larger trends, not only from what was being reported from the open source users, but also from what our support customers were seeing. Charlie is still doing that, even though he has been pulled off it some recently to work on our migration from Redmine to Jira.

So for a long time (from about November 2012 to August 2013) we had "Community Developers". That was Jeff McCune and then later Adrien Thebo joined him. This all was working hunky dory, but I always felt a little bad about it since it was a very useful, but also a very unrewarding job for them to do. Internally we kept talking about how to keep up the amazing response time and quality that they had worked out, but also spread the load and let Adrien (Jeff has moved on to internal tooling work) join the rest of us on day to day development tasks. I also wanted to do it so that the rest of us didn't lose contact with all of you out here.

So when we starting trying to split the one large puppet team into 2 (server team: Me, Henrik, Josh Partlow; agent team: Josh Cooper, Ethan, Rob, Kylo, Adrien) we decided to try and take the plunge of rolling Adrien back into the rest of the group. As part of doing that we've also been trying out how to stay on top of the stuff coming in, which we've fallen behind on a little. So far it has been the following mechanisms:

  * Fortnightly google hangout that is open to everyone (9am Pacific on Wednesday, link posted in #puppet-dev) to triage the open PRs and decide on next actions

  * Making an effort to pull in requests to our iterations, especially if they overlap with other items that we wanted to work on already

So far I've found that doing this as a group has been pretty beneficial since there are so many different aspects within puppet that it is really hard for any one person to have the complete knowledge on many parts of the system to make a completely informed decision. There are also many parts (usually OS specific issues) where we might have little to no knowledge and so having some others join it can really help out (this is also the reason why I've been responding with "put it in a module, please" so often :).

Ok, I guess that wasn't so quick.

 

Windows and logging issues are not my strongest subject, but I will take a look at your contribution and see if I have any comments that can help getting it accepted faster.

Regards
- henrik

--
You received this message because you are subscribed to the Google Groups "Puppet Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-dev/l7gpie%24htj%241%40ger.gmane.org.

For more options, visit https://groups.google.com/groups/opt_out.

--

Andrew Parker

an...@puppetlabs.com

Freenode: zaphod42

Twitter: @aparker42

Software Developer

Join us at PuppetConf 2014, September 23-24 in San Francisco

[Felix Frank]

On 12/02/2013 09:27 PM, Andy Parker wrote:
>
> Ok, I guess that wasn't so quick.

That was great, Andy. Thanks for the insight!

Cheers,
Felix