Module PR Triage Notes 2014-06-26

[Morgan Haskel]

This week we triaged PRs for puppetlabs-ruby, puppetlabs-apache, and puppetlabs-apt.

puppetlabs-ruby:

Merged:

 - 34: Change the defaults for ruby_package and rubygems_package on ubuntu 14.04

 - 33: Correct ruby-switch argument when using ruby<VERSION>-full

 - 32: simplify array handling

Reviewed/Commented on:

 - 35: Add beaker tests

    - Need further understanding of why some changes were made, commented on the PR.

 - 31: Managing rake and bundler packages. Rake and bundle resources.

    - Needs further review.

Closed:

 - 30 - gem is provided by ruby in Ubuntu Trusty

    - handled by 34

puppetlabs-apache

Merged:

 - 774: Start synchronizing module files

 - 767: Pin rspec to 2.x

   - This is just for the 1.1.x branch, see 763

 - 763: RSpec3 conversion

   - For the master branch

 - 760: Add logroot_mode parameter

 - 752: Add the Satisfy parameter to the directory fragment

 - 743: Provide configuration file for negotiation module

 - 704: Add fastcgi external server defined type

Reviewed/Commented on:

 - 773: Auto enable strict_variables for unit tests when puppet > 3.5

   - needs rebase

 - 772: Fix mod_php acceptance tests by copying some files onto the master

   - would like the patch to be reworked.

 - 771: Just wondering why there's not such a parameter

   - needs docs + test

 - 769: optional vhost management

   - dangerous by default on RHEL, want additional check added

 - 764: Support parameters along with proxy_pass

   - would like to see some reworking of the patch

 - 753: Add support for custom vhost block templates

   - would like to take a different approach to solving the problem

 - 750: Add package parameters to the dav_svn mod

   - needs rebase

 - 729: Allow global setting of ssl_protocol + doc. ssl_cipher

   - needs tests

 - 718: Add remote_ip module support, since RPAF is broken since ubuntu 13.10

   - needs tests

 - 717: Add options to mod info

   - needs rebase

 - 693: Add rewrites to vhost directories

   - needs rebase

 - 692: Add keepalive_request, hostname_lookups, start_servers, server_limit, max_clients, max_requests_per_child to the template and class

   - needs rebase

Closed: 

 - 748: Add define "apache::dotconf" to create config files

   - closed, opened https://tickets.puppetlabs.com/browse/MODULES-1180

puppetlabs-apt

Merged:

 - 316: Start synchronizing module files

 - 318: MODULES-780 Don't blow up on unicode characters

--

Morgan Haskel

mor...@puppetlabs.com

Module Engineer

Join us at PuppetConf 2014, September 20-24 in San Francisco

Register by July 31st to take advantage of the Early Bird discount —save $249!

[Igor Galić]

Hi folks,

This week we triaged PRs for puppetlabs-apt, puppetlabs-apache, puppetlabs-vcsrepo

puppetlabs-apt:

* Most PRs here are in limbo because they are still failing/missing tests.

* apenny merged 1.5.x

* it's time for a new release here.

puppetlabs-apache

Merged:

 - Add validate and lint tasks to travis script #788

 - Allow ssl_certs_dir to be unset. #787

 - Add param to ctrl purging of vhost dir #786

 - Update tests for strict variable testing #783

Reviewed/Commented on:

 - Add deflate params: types, notes #785

 - function to munge booleans to httpd's On/Off #782

   * this sparked a bit of a discussion, which I'll follow up in another email.

 - Changes $alias to $fcgi_alias to prevent Puppet complaining about using that name #781

Release: 

 - We should make a new release, it's about time.

puppetlabs-vcsrepo

Merged:

 - (MODULES-1014) Add rspec for noop mode #189

Discussed:

- This module needs a https://github.com/puppetlabs/modulesync

General:

most Puppetlabs modules' [Report Issues] links were still pointing to github/issues.

This should be fixed now. If we're missing anything, please point us to it!

(Unfortunately the forge is, as of yet, unable to crawl Jira to retrieve the issues & display them)

We also did a crawl through the open tickets, closing a bunch.

If you're looking for places to help, cleaning up Jira bugs, or providing patches for them is a

great place to start:

    https://tickets.puppetlabs.com/browse/MODULES

--

Igor Galić

Tel: +43 (0) 664 886 22 883
Mail: i.g...@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641

[Igor Galić]

Fellow humans,

This week we triaged PRs for puppetlabs-dhcp, puppetlabs-mysql, and bits of
puppetlabs-rabbitmq


puppetlabs-dhcp
===============

#32 Remove deprecation warnings for templates and use of concat::setup
#36 Add patches from foreman-dhcp
* we have a release pending here.

puppetlabs-mysql
================

Merged:
#545 Update mysqltuner.pl to version 1.3.0 #545
#517 Add Archlinux support (not officially supported)
#547 Prevent ERROR 1008 in mysql_database provider (bonus! I merged this one yesterday:)

closed:
#474 enable removal of mysql::server::backup — closed, we won't support absent, because it's a pain
#497 Ignore internal mysql databases when creating a backup (already fixed)
#492 parameterize mysqld config_dir (implemented better[?] in #508)
#537 Include mysql::server class (this will be fixed by decoupling mysql::db)
#542 Adding CentOS rules (duplicate of #544)

Needs rebase:
#506 added spec test for username validation
#405 run mysql_install_db if datadir is set annd mysql database is missing (I tried but gave up)
#352 Add timeout parameter to increase for long time running sql imports (I tried but gave up)
#440 Some mixup between usin PE and OSS and using puppet vs norm .box files.....

Comments:
#462 Defined type for managing conf.d entries — this needs a redesign, as suggested.

General:

We've discussed how to close in on the mariadb support in

https://tickets.puppetlabs.com/browse/MODULES-151

I'll be taking a look at this in the next couple of days.


puppetlabs-rabbitmq
===================

Actually, we didn't touch anything, because we're waiting for #192

This module still needs a https://github.com/puppetlabs/modulesync

Tests
=====

We're currently working on reducing acceptance tests.

In the past we've been quite naïve in writing these. Basically we've been
repeating alot of the unit tests by checking if a package is installed or a
service is running. Since this is basic puppet functionality, we don't really
need to cover that. The other thing that we also want to change is to simplify
those tests so we only use the resources available on *all* platforms. The best
example for this way forward is puppetlabs-postgresl:


https://github.com/puppetlabs/puppetlabs-postgresql/tree/master/spec/acceptance


We also discussed to make the Puppetlabs Modules Jenkins publicly accessible.
This Jenkins server runs acceptance tests for all supported Operating Systems,
how ever it only runs it on merge to master, not yet for all PRs. Baby steps ;)
At least that way people can can see how tests are even run at all, and we get
a better feel for a module's overal health.

Next week we'll do a crawl through Jira again, so if you have any open issues,
or any unopened issuese, get started:

https://tickets.puppetlabs.com/browse/MODULES

So long and thanks for all the <><


-- o/~ i

[Igor Galić]

Fellow Humans,


This week we triaged PRs for puppetlabs-firewal and briefly looked at puppetlabs-git and, once again, at puppetlabs-mysql (more in a next email).
puppetlabs-firewall
===================

merged:
* #388 Add cbt protocol, to be able to mitigate some DDoS attacks

discussed:
* #387 Add missing set_mark in the ip6tables provider #387
* #394 (MODULES-450) Enable rule inversion #394
* #387 Add missing set_mark in the ip6tables provider
* #348 add ipset support (closing in favour of #383)
* #380 Apply firewall resources alphabetically -- this is a can of worms... closed.
* #374 Fixed bug which arbitrarily limited iniface and outiface parameters -- this needs more input.
* #356 RHEL has a separate services for IPv4 and IPv6 iptables -- must be made optional

needs rebased:
* #383 add ipset support
* #381 Patch for Debian Jessie (testing)
* #378 Added support for statistic module
* #373 Revised Firewall Module README for review
* #372 Add support for 'NOTRACK' action -- also, NOTRACK is obsolete...
* #349 make extension parameter ordering easier to understand -- YES PLEASE!

puppetlabs-git
==============

merged:
* #30 User Config -- also fixes #28 and #18

puppetlabs-mysql
================

* #548 Add support for MariaDB > 10.0.0 - both Hunnur and me are admitting defeat: we have no idea how to test this properly.


Like always, there's a Jira Triage every two weeks, I'm sure someone else will have taken notes for that one ;)


So long, and thanks for all the <><

[Igor Galić]

Fellow humans,

I've been working on MODULES-151, and pushed my work in progress to

https://github.com/puppetlabs/puppetlabs-mysql/pull/548

this pr adds a mariadb provider to puppetlabs-mysql, boolean-confining it, based
on a version-check (for >= 10.0.0-MariaDB), if so, it adds a feature for long
username support.

however, both me, and Hunnur have so far failed to make this sensibly testable.
As you can see in the latest comments, I've tried stubbing out version_check()
in the unit test for the type, and, apparently, I'm doing it wrong.

Do I ignore this test in the type, and instead add it to the provider?
Am I trying to attach it to the wrong object? In the wrong context?

uhm.. yeah, I don't really know, so I'd really appreciate your input!

-- bye i