Jira (PUP-8135) Output of notify message in simulation (noop) is not similar to enforcing notify message

10 views
Skip to first unread message

Eric Sorenson (JIRA)

unread,
Nov 8, 2017, 4:38:03 PM11/8/17
to puppe...@googlegroups.com
Eric Sorenson moved an issue
 
Puppet / Bug PUP-8135
Output of notify message in simulation (noop) is not similar to enforcing notify message
Change By: Eric Sorenson
Affects Version/s: PE 3.8.1
Component/s: puppet
Key: PE PUP - 10490 8135
Project: Puppet  Enterprise [Internal]
Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db)
Atlassian logo

Eric Sorenson (JIRA)

unread,
Nov 8, 2017, 4:38:03 PM11/8/17
to puppe...@googlegroups.com

Eric Sorenson (JIRA)

unread,
Nov 8, 2017, 4:39:02 PM11/8/17
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 11, 2021, 3:20:02 PM6/11/21
to puppe...@googlegroups.com
Josh Cooper updated an issue
Change By: Josh Cooper
During a Demo to a partner with the noop/enforcing of a simple comment field change the partner identified that the notify output of puppet apply --noop and without noop is not the same. With noop the value is in '' and in enforce not. Please see example output from my console:

{noformat}
[root@centos6a ~]# cat root.pp
user { 'root':
  ensure           => 'present',
  comment          => 'New value for root',
}
[root@centos6a ~]# puppet resource user root
user { 'root':
  ensure           => 'present',
  comment          => 'root',
  gid              => '0',
  home             => '/root',
  password         => '$1$v4K9E8Wj$gZIHJ5JtQL5ZGZXeqSSsd0',
  password_max_age => '99999',
  password_min_age => '0',
  shell            => '/bin/bash',
  uid              => '0',
}
[root@centos6a ~]# puppet apply root.pp --noop
Notice: Compiled catalog for centos6a.pdx.puppetlabs.demo in environment production in 0.11 seconds
Notice: /Stage[main]/Main/User[root]/comment: current_value root, should be New value for root (noop)
Notice: Class[Main]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 1 events
Notice: Finished catalog run in 0.09 seconds
[root@centos6a ~]# puppet apply root.pp
Notice: Compiled catalog for centos6a.pdx.puppetlabs.demo in environment production in 0.13 seconds
Notice: /Stage[main]/Main/User[root]/comment: comment changed 'root' to 'New value for root'
Notice: Finished catalog run in 0.27 seconds

{noformat}
This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)
Atlassian logo

Josh Cooper (Jira)

unread,
Jun 11, 2021, 3:24:01 PM6/11/21
to puppe...@googlegroups.com

Josh Cooper (Jira)

unread,
Jun 11, 2021, 3:24:02 PM6/11/21
to puppe...@googlegroups.com
Josh Cooper assigned an issue to Josh Cooper

Josh Cooper (Jira)

unread,
Jun 11, 2021, 3:50:02 PM6/11/21
to puppe...@googlegroups.com
Josh Cooper commented on Bug PUP-8135
 
Re: Output of notify message in simulation (noop) is not similar to enforcing notify message

Quotes were added to the enforcing case in PUP-7616, so that part is fixed.

Ideally noop should call change_to_s in the same way that noop does, however, many people have written tests based on the output of puppet apply, etc, so I'm reluctant to change this.

I'm going to close this as a dup of PUP-7616. Please reopen if it is desirable to make the noop output exactly the same as enforcing , except for the '(noop)' label.

Reply all
Reply to author
Forward
0 new messages